From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F176ACD8C9F for ; Mon, 8 Jun 2026 11:34:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WQWRh8p2h3NDFUSWN1Rhl+a0kriaz+3CZ0URUglMXpg=; b=k07HU4vMS9D2v4D0UiZjbQ7mlQ 5ChZNXV1KfZ9CM0oNZcPLmmqI8qZOdE47hs+kKjlU9YJOCNQTHBtBGM6ZCpJtW3bAAC9aYi6iOPYm aJdnHyCZSJhiwEdbtHJL4AetihSZug6reH0TBMgFMweJ9bkIOoNKSLqS5m8XSntv4EXadvYOYvV70 ybj6sVzEHQwFRo69qql6Etu8G0c7rOaGzDgZYBO7fN1ws+kqKwUQrHZHKvnxeMb2Hyl1hfwS0i8gm CgjczbsVWMEzw1jX6yIM7l6PAkXVzVJWMpFwEd5mlKbP6QMH8ckMBoefSa2Ai/MXG5aap/Ompjfe3 dfsfWI0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWYFV-00000003R6r-2kLA; Mon, 08 Jun 2026 11:34:33 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWYFT-00000003R6e-3Dyh for linux-arm-kernel@lists.infradead.org; Mon, 08 Jun 2026 11:34:31 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A8DFD6001D; Mon, 8 Jun 2026 11:34:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF0311F00893; Mon, 8 Jun 2026 11:34:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780918469; bh=WQWRh8p2h3NDFUSWN1Rhl+a0kriaz+3CZ0URUglMXpg=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Aw7AcunF/5f93ie/u3gMYvj6jISdYUw6DKg6ZFuhbRqfdV1mfisbKb0zmEAqMS15k pPG5jKzDIJs3h+xaU1IS7UEoSi/ZWNq1sVtj5NW0Sn4MWnD+fxWK05TpBh3QVFR6n0 W/Ks/dmsjhEQh/Uo6h015Xp/cWmrcKtFFbUxUjuTAeIYPG8s95XKhA6ZBW9HWG5Pp+ n4FjOTqvXupLbst4pZvOxyQo97i1vUyYGiyQZ/sQs5Y1qd5Zu3qubah7KyNhbFZpvK 4Cyrkp5dtE1a2INg10y4im8nPs20kajr2/uKpuC9lVBwXOxVbBQM0OQWG7MD8t4nsf f1xWD0u5VO54w== Date: Mon, 8 Jun 2026 13:34:27 +0200 From: Maxime Ripard To: Luca Ceresoli Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Inki Dae , Jagan Teki , Marek Szyprowski , Marek Vasut , Stefan Agner , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Hui Pu , Ian Ray , Thomas Petazzoni , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 04/37] drm/display: bridge-connector: store the drm_device pointer Message-ID: <20260608-imposing-umber-tuatara-62daba@houat> References: <20260519-drm-bridge-hotplug-v1-0-45e2bdb3dfb4@bootlin.com> <20260519-drm-bridge-hotplug-v1-4-45e2bdb3dfb4@bootlin.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="rfvx3ud67pyds4m4" Content-Disposition: inline In-Reply-To: <20260519-drm-bridge-hotplug-v1-4-45e2bdb3dfb4@bootlin.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --rfvx3ud67pyds4m4 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 04/37] drm/display: bridge-connector: store the drm_device pointer MIME-Version: 1.0 Hi, On Tue, May 19, 2026 at 12:37:21PM +0200, Luca Ceresoli wrote: > Currently the struct drm_device pointer is only needed during the initial > drm_bridge_connector_init() and in drm_bridge_connector_handle_hpd() which > gets it from the struct drm_connector. >=20 > This will be insufficient when introducing bridge hotplugging, because: >=20 > * some of the actions in drm_bridge_connector_init() will have to be > performed later on, when a bridge is hot(un)plugged > * the connector will be removed and re-added based on hotplug events, > so the drm_connector might just not exist or its content be cleared >=20 > Store the drm_device pointer in struct drm_bridge_connector for any later > needs. Also convert drm_bridge_connector_handle_hpd() to use the newly > stored value. >=20 > Signed-off-by: Luca Ceresoli This is already accessible as drm_connector->dev and drm_bridge->dev. I think it would be great to list why this is different, and how it is different (ie, when it's set, unset). Maxime --rfvx3ud67pyds4m4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaiaovwAKCRAnX84Zoj2+ drmAAYDCTrp5B/3nwsHfwzJ3pjL6RsLximEIeguzyN2Zo/pXFeFBn/eqNiwdUNan 9v8iJgYBgIPGBwLE0HR3Dkk+PXB7EljJYW3UiA+uHKQJajC1OaBDZi/ukKG3oLzo Oys6KnB6zA== =K5mh -----END PGP SIGNATURE----- --rfvx3ud67pyds4m4--