From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C1BFCD8CB9 for ; Tue, 9 Jun 2026 15:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=k2mNfNUmklU9bFAjBbAD3Iaxi1EmNNL5ROjmhSuGaNU=; b=X20itME1o7uqF+jViF4B7AO2pf ZcIciBRlZQQ3QBCKl45WaMZ+MpPKuxNwdiFJhxPFD9QGO7XHEbmzO4SoIm2cRFB5IGEICFkQmy17c pOGnhipHiy4yoiNBrwiu73u59oETzBy8UWep7iaGrX49lOnQWDyUSfJTprizPsy3bPMLXYGqRdXVX R1tIfImgI0KP6BNPRMW9CUcqzqZUvGuOxtgsKntWWh3kefQC0yOb88WsKjC+1G5NOaT3QYz2fjbGL uPAU9Us7Q2vmy4iegRbG2ppSu/tO/QGv/W+KlJ691bgtbjDVMaDgen1kNUlRXks9STJXIxRBpjEhM GAd6wnqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWyaH-00000005wj4-0BhS; Tue, 09 Jun 2026 15:41:45 +0000 Received: from smtp.forwardemail.net ([121.127.44.66]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wWyaE-00000005wgg-0MDp for linux-arm-kernel@lists.infradead.org; Tue, 09 Jun 2026 15:41:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Cc: To: From; q=dns/txt; s=fe-e1b5cab7be; t=1781019701; bh=k2mNfNUmklU9bFAjBbAD3Iaxi1EmNNL5ROjmhSuGaNU=; b=NVK2vBLSYdw9UyyOlBresJSZQIWaCbsOR6U44LwskUM8yA3m6faQ9dOgimTOl+teTH3kOaOHK MF783dDuwMTSwnLwv3aACDtHfWL9wjBpLNwB4rgIvbONU7lY76lC2ZLYEqdFSNT+hJ61vKxg1x0 qviw2yTjef3tVWYztuEevcpnzYGuvheT0fB5WvRy8pMaHShmaM+r0Y4aA7j1BWMxvBVMXwPt9Ua 12uC3GxEa0QbNpO92xO57aX6IFzrEIg7JhKAQWZ+voNLzAEElKejKrrVKfgHwUoB6sspGdXxw4s 5v1yh0zryJMJCPeDEbQijJxihXHuHam2KVumorkYzxtQ== X-Forward-Email-ID: 6a2834322d71d6ad28f66e5b X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 121.127.44.66 X-Forward-Email-Version: 2.8.22 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net From: Jonas Karlman To: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Geis , Michael Riesch Cc: Diederik de Haas , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman Subject: [PATCH 2/2] arm64: dts: rockchip: Fix devices suspend freeze on RK3568/RK3566 Date: Tue, 9 Jun 2026 15:41:23 +0000 Message-ID: <20260609154124.445182-3-jonas@kwiboo.se> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260609154124.445182-1-jonas@kwiboo.se> References: <20260609154124.445182-1-jonas@kwiboo.se> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260609_084142_323837_E2FC5BE0 X-CRM114-Status: GOOD ( 11.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The EHCI/OHCI controller depends on clk_usbphy1_480m being enabled, or the system may freeze when registers are accessed, i.e. during suspend in ohci_suspend(). Add the missing clk_usbphy1_480m clocks reference to EHCI/OHCI controllers to ensure the clock is enabled when ECHI/OHCI registers are accessed to prevent a system freeze. Fixes suspend pm_test issue with EHCI/OHCI devices due to the missing clk_usbphy1_480m reference and makes following pm_test modes work: echo N > /sys/module/printk/parameters/console_suspend echo devices > /sys/power/pm_test echo platform > /sys/power/pm_test echo processors > /sys/power/pm_test echo core > /sys/power/pm_test echo mem > /sys/power/state Fixes: 91c4c3e06a25 ("arm64: dts: rockchip: add usb2 nodes to rk3568 device tree") Fixes: 78f7186095db ("arm64: dts: rockchip: rename and sort the rk356x usb2 phy handles") Signed-off-by: Jonas Karlman --- arch/arm64/boot/dts/rockchip/rk356x-base.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi index a5832895bd39..c930a6fd6ea0 100644 --- a/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk356x-base.dtsi @@ -321,44 +321,44 @@ its: msi-controller@fd440000 { }; usb_host0_ehci: usb@fd800000 { - compatible = "generic-ehci"; + compatible = "rockchip,rk3568-ehci", "generic-ehci"; reg = <0x0 0xfd800000 0x0 0x40000>; interrupts = ; clocks = <&cru HCLK_USB2HOST0>, <&cru HCLK_USB2HOST0_ARB>, - <&cru PCLK_USB>; + <&cru PCLK_USB>, <&usb2phy1>; phys = <&usb2phy1_otg>; phy-names = "usb"; status = "disabled"; }; usb_host0_ohci: usb@fd840000 { - compatible = "generic-ohci"; + compatible = "rockchip,rk3568-ohci", "generic-ohci"; reg = <0x0 0xfd840000 0x0 0x40000>; interrupts = ; clocks = <&cru HCLK_USB2HOST0>, <&cru HCLK_USB2HOST0_ARB>, - <&cru PCLK_USB>; + <&cru PCLK_USB>, <&usb2phy1>; phys = <&usb2phy1_otg>; phy-names = "usb"; status = "disabled"; }; usb_host1_ehci: usb@fd880000 { - compatible = "generic-ehci"; + compatible = "rockchip,rk3568-ehci", "generic-ehci"; reg = <0x0 0xfd880000 0x0 0x40000>; interrupts = ; clocks = <&cru HCLK_USB2HOST1>, <&cru HCLK_USB2HOST1_ARB>, - <&cru PCLK_USB>; + <&cru PCLK_USB>, <&usb2phy1>; phys = <&usb2phy1_host>; phy-names = "usb"; status = "disabled"; }; usb_host1_ohci: usb@fd8c0000 { - compatible = "generic-ohci"; + compatible = "rockchip,rk3568-ohci", "generic-ohci"; reg = <0x0 0xfd8c0000 0x0 0x40000>; interrupts = ; clocks = <&cru HCLK_USB2HOST1>, <&cru HCLK_USB2HOST1_ARB>, - <&cru PCLK_USB>; + <&cru PCLK_USB>, <&usb2phy1>; phys = <&usb2phy1_host>; phy-names = "usb"; status = "disabled"; -- 2.54.0