From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BEADCD98C6 for ; Thu, 11 Jun 2026 03:41:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=dvArjssJv1aA68PZSfjaB7vXXTDuvf8OWO4ZxWOv0qI=; b=nRz7TlyGy8hvZOBQkhKDKcZwPr SnEfcCav3+i0R2XSxzpgyD7uhWlXFtGwcwk9zVwXAzmGt7MqElobJjazuUrb9sEKYeVTvtQ4JdWTv Nu1iOKFsZuv6NsveNT5ko6C1LUL2UBGgOcEh19chyM+rpYs6araNYPREMM0bFstbFncbAUEf1/0X/ iYhO5Mn6QDSYMR8EtFRKv7fcB3bDYPVxi0tLjNzP3seIK2L1BBi8DiwtyqEqMQ8zA5sjJGIybYKp5 D6uYsEw1Q/WTDvyn2WYqNPOHPDmu/BySj0iP9oOraGhfVkyYZ3jQQVvuJCZ19RzlTrPEp7hdjx60z gwB+4nsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXWI7-00000008dJW-3Rve; Thu, 11 Jun 2026 03:41:15 +0000 Received: from smtp25.cstnet.cn ([159.226.251.25] helo=cstnet.cn) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wXWI3-00000008dJ6-2nh0; Thu, 11 Jun 2026 03:41:14 +0000 Received: from localhost.localdomain (unknown [117.182.75.76]) by APP-05 (Coremail) with SMTP id zQCowABHkcRFLipqY2YLEw--.20162S2; Thu, 11 Jun 2026 11:40:56 +0800 (CST) From: WenTao Liang To: alexandre.belloni@bootlin.com Cc: neil.armstrong@linaro.org, khilman@baylibre.com, jbrunet@baylibre.com, martin.blumenstingl@googlemail.com, p.zabel@pengutronix.de, ben.dooks@codethink.co.uk, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, WenTao Liang , stable@vger.kernel.org Subject: [PATCH] rtc: meson: fix refcount leak in meson_rtc_get_bus Date: Thu, 11 Jun 2026 11:40:40 +0800 Message-ID: <20260611034040.59682-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID: zQCowABHkcRFLipqY2YLEw--.20162S2 X-Coremail-Antispam: 1UD129KBjvJXoW7Ar43JFWxWw1rJw17Zw1kKrg_yoW8Gryfpr 43KFy7tryDtr4fJanrGw4ruFW3ZFnIqFWUGrsFyw1S9w1fJa1UJry2kF4rJayUWr1kG3y5 XFsrGF1F9F1DKF7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDU0xBIdaVrnRJUUU9F14x267AKxVW8JVW5JwAFc2x0x2IEx4CE42xK8VAvwI8IcIk0 rVWrJVCq3wAFIxvE14AKwVWUJVWUGwA2ocxC64kIII0Yj41l84x0c7CEw4AK67xGY2AK02 1l84ACjcxK6xIIjxv20xvE14v26ryj6F1UM28EF7xvwVC0I7IYx2IY6xkF7I0E14v26r4j 6F4UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Cr 1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj 6xIIjxv20xvE14v26r1j6r18McIj6I8E87Iv67AKxVWUJVW8JwAm72CE4IkC6x0Yz7v_Jr 0_Gr1lF7xvr2IYc2Ij64vIr41lF7I21c0EjII2zVCS5cI20VAGYxC7M4IIrI8v6xkF7I0E 8cxan2IY04v7MxkF7I0En4kS14v26r1q6r43MxAIw28IcxkI7VAKI48JMxC20s026xCaFV Cjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWl x4CE17CEb7AF67AKxVWUtVW8ZwCIc40Y0x0EwIxGrwCI42IY6xIIjxv20xvE14v26r1j6r 1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVW8JVWxJwCI42IY6xAIw20EY4v20xvaj40_Jr0_ JF4lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2z280aVCY1x0267AKxVW8JVW8JrUvcS sGvfC2KfnxnUUI43ZEXa7VUbGQ6JUUUUU== X-Originating-IP: [117.182.75.76] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCRAPA2op-rvB+gAAso X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260610_204112_068629_F4E7D116 X-CRM114-Status: GOOD ( 10.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In meson_rtc_get_bus(), reset_control_reset() is called to trigger a hardware reset when the serial bus is not ready. The function may retry up to three times, but neither the successful nor the failure path calls reset_control_rearm() to balance the reference count, leaking the triggered_count on shared reset controls. Fix this by adding reset_control_rearm() after reset_control_reset() on both the error return path and the success path within the retry loop, ensuring the reset control can be re-triggered on subsequent bus acquisition attempts. Cc: stable@vger.kernel.org Fixes: d8fe6009aa3e ("rtc: support for the Amlogic Meson RTC") Signed-off-by: WenTao Liang --- drivers/rtc/rtc-meson.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index 21eceb9e2e13..729384dceb12 100644 --- a/drivers/rtc/rtc-meson.c +++ b/drivers/rtc/rtc-meson.c @@ -146,8 +146,12 @@ static int meson_rtc_get_bus(struct meson_rtc *rtc) dev_warn(rtc->dev, "failed to get bus, resetting RTC\n"); ret = reset_control_reset(rtc->reset); - if (ret) + if (ret) { + reset_control_rearm(rtc->reset); return ret; + } + + reset_control_rearm(rtc->reset); } dev_err(rtc->dev, "bus is not ready\n"); -- 2.50.1 (Apple Git-155)