From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E87C6CD98F0 for ; Wed, 17 Jun 2026 21:24:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=beNpfuk/6VLfvMcqWyijbHRYY4nZbi8qSQddBym6GBw=; b=V4B0fyq0/8GfHwZFvIk0UeUMDW hctuSLqAsgC60G8w2lfcOCp4dH9jFK9V+WAtXIkqFjnuTCBpwS+/u6MXPmcxp+6itwtkJSIO7Xk5H r8jb1wiwSN4tBVDRX2gVENUVXzAZp69Mygq4e16McUy5gIp/Yn4/+ebHkJCl7cXTH7G8/uekHL9Qm L+aQPjqTDRXJKUAClGtvPRKq4M7lVrwudcqx4R3upHCmiyee8FEKlcLmdprRaKKtifz2eSnbetEcU 7427YdN2j2nZhAVsOVCLTv3kFtlGjow10sxbTBfAJGLTHb8WNFbwjSQr1H/apk4ZSJPmBzy+/1VGs XreIdySw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZxju-00000000LkK-3bKx; Wed, 17 Jun 2026 21:24:02 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZxjt-00000000Lk7-2QKb for linux-arm-kernel@lists.infradead.org; Wed, 17 Jun 2026 21:24:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8FE536001D; Wed, 17 Jun 2026 21:24:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2EF11F000E9; Wed, 17 Jun 2026 21:23:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781731440; bh=beNpfuk/6VLfvMcqWyijbHRYY4nZbi8qSQddBym6GBw=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Y3HdAWjJv7yEtzUHOcQNvSG0ujaiA74CmoR4PyzgxZa5PjqBHOHH0h0rCq/dkrLNc QNCWO1I52sgewS043ZwduF3iZz4HDhNv+Qgv+fY4MoKnSsXXoUt9fBRKVAIB6CWNGi 39O+Gxcqk23ge9fI9ca3LxL9QMPnUh1LxBKLe3BAMRmoJD/vu/Qx/WJXwPSZhWprl2 6N1ZUH8sRFNUj3/Q2qmzgUvrzaj+gacjV69Rob7XXntCij7VbZxAZ9ySCpkEySecjA i7YbjGEK8Pftnsb+oxP/K6EZRAStw5se4GbUavclmhL8MKUscg2sMxosd2rWNW6F3o TBn2wRF3QSV7A== Date: Wed, 17 Jun 2026 22:23:56 +0100 From: Conor Dooley To: Stefan =?iso-8859-1?Q?D=F6singer?= Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Brian Masney , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC v4 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset bindings Message-ID: <20260617-deed-snap-4649ffae0e27@spud> References: <20260616-zx29clk-v4-0-ca994bd22e9d@gmail.com> <20260616-zx29clk-v4-1-ca994bd22e9d@gmail.com> <20260617-tabasco-pulsate-454ed3f8f0b6@spud> <-l2OM6P0RNSYRQfOSObOyw@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aXpZeYmC7TLQbH+H" Content-Disposition: inline In-Reply-To: <-l2OM6P0RNSYRQfOSObOyw@gmail.com> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --aXpZeYmC7TLQbH+H Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 17, 2026 at 08:47:53PM +0300, Stefan D=F6singer wrote: > Am Mittwoch, 17. Juni 2026, 19:08:02 Ostafrikanische Zeit schrieb Conor= =20 > Dooley: > > On Tue, Jun 16, 2026 at 11:26:21PM +0300, Stefan D=F6singer wrote: >=20 > > > +F: Documentation/devicetree/zte,zx297520v3-* > >=20 > > Sashiko complaint here looks valid. >=20 > Yes, it is valid. >=20 > It also brought up another concern in patch 12 that has an impact on this= =20 > binding: >=20 > Am Dienstag, 16. Juni 2026, 23:42:19 Ostafrikanische Zeit schrieb sashiko- > bot@kernel.org: > > issue(s) to consider: - [Low] The `syscon-reboot` node is incorrectly > > defined at the root level using the explicitly deprecated `regmap` > > property. -- >=20 > And indeed "regmap" is deprecated and I missed it somehow. As far as I=20 > understand, to put syscon-reboot as a child of the clock, I need to add t= he=20 > simple-mfd .compatible: >=20 > Either >=20 > topclk: clock-controller@13b000 { > compatible =3D "zte,zx297520v3-topclk", "syscon", "simple-mfd"; > reg =3D <0x0013b000 0x400>; > ... > syscon-reboot { > compatible =3D "syscon-reboot"; > regmap =3D <&topclk>; > offset =3D <0x0>; > mask =3D <0x1>; > }; > }; >=20 > --- or --- >=20 > something@13b000 { > compatible =3D "zte,zx297520v3-topcrm", "syscon", "simple-mfd"; > reg =3D <0x0013b000 0x400>; > ranges; >=20 > topclk: clock-controller@0 { > compatible =3D "zte,zx297520v3-topclk"; > ... > } >=20 > syscon-reboot { > compatible =3D "syscon-reboot"; > offset =3D <0x0>; > mask =3D <0x1>; > }; > }; >=20 > I see both ways in existing DTS files (e.g. imx6sl.dtsi for the fomer,=20 > uniphier-pro4.dtsi for the latter). Is there a preferred way? I have a mi= ld=20 > preference for the first, as it would keep all 3 clocks in the same way. = If I=20 > go for the second, the clock driver would have to query its own node and = the=20 > parent node for the regmap. The first one is more natural... > AFAIU unrelated to syscon-reboot option 2 would give me the opportunity t= o=20 > have separate clock and reset nodes and bindings and skip the aux bus, bu= t=20 > this would not be a correct representation of how the hardware works. =2E..for this reason! Do you actually need an aux bus here though? Since you have to add simple-mfd for your the syscon-reboot and simple-mfd is a real bus, can you set the reset controller up with an mfd_cell + devm_mfd_add_devices() instead? --aXpZeYmC7TLQbH+H Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCajMQawAKCRB4tDGHoIJi 0i1ZAQChkntDCaVz6at1gTETpGDuYDaGrt/c9Ih6y89+zogSggD/QNSAz1aKjTsZ eA1aiNiWJJUe0WjPlwBo8QPgGL6g4Qc= =eiAi -----END PGP SIGNATURE----- --aXpZeYmC7TLQbH+H--