From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4EFDCD98E4 for ; Wed, 17 Jun 2026 09:59:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zh/z5tnXP6hfVph2lmiDlHoky5dTCCvIkfRb/8EB05E=; b=qVTMkd+FoLA4kPQv3kF3A0N61Y 5v/q+7cA1XtXJa1oBA0V74PpkJ7GNn5AxmESgCzlKIcvCePctqknaLXefcA2q+9fLdv2rj6RHU2I5 tcVKnWhVwYA3tFJ5bOBGATo3ZVyTq9/pzuBdceEQ+vdyEdiG9XqLhd7K1rCY8k7k2IYb26tehc/Dz 6nKlTNjx7xwo7FVk2yj2a7vURVLNE/eL9eSFnakrHurk4g+DSaLt0ghDsIYNwwrxtGfGD7j6WpokM UjDhYXwq5hnjCVuZRevTBhn+t7vOG1W5mJKKfNHg/g7aMYVgKY1HFVE5r98soO59uM2Hlz/a2sTlM Yv+xVgVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZn3V-0000000GzYY-2wp6; Wed, 17 Jun 2026 09:59:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wZn3S-0000000GzXK-2mJl for linux-arm-kernel@lists.infradead.org; Wed, 17 Jun 2026 09:59:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7AB124800; Wed, 17 Jun 2026 02:59:24 -0700 (PDT) Received: from donnerap.manchester.arm.com (donnerap.manchester.arm.com [10.33.8.81]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC1E13F915; Wed, 17 Jun 2026 02:59:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1781690369; bh=v4PQvJxXL6yAb8eVisl3HMvO3Ev5F2132vGHAZ1Y3G8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ocKnKrUNbDSGDgA+dgTEXWVBhPgJ7ntsBDPjrnt8OqAIa8r32N4spvPd7My6PyJvx TUxBfqGpcPYMnbZlDMMzfcrE7k6FOTS8URajgVXp6ldMHyNNAvzzeqHVTrDFGOVYvG rVE5k76a00UbE9b6wqoWjPYkuEkvXnNHaUL0XZxY= From: Philip Radford To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, linux-pm@vger.kernel.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, dan.carpenter@linaro.org, d-gole@ti.com, souvik.chakravarty@arm.com, Philip Radford Subject: [PATCH v7 01/13] powercap: Add enable disable control-type Date: Wed, 17 Jun 2026 10:58:58 +0100 Message-ID: <20260617095910.1963578-2-philip.radford@arm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260617095910.1963578-1-philip.radford@arm.com> References: <20260617095910.1963578-1-philip.radford@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260617_025930_788870_E82D3B3F X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Add functionality to disable or enable the Powercap control-type by writing directly into sys/class/powercap/arm-scmi/enabled. Signed-off-by: Philip Radford --- drivers/powercap/arm_scmi_powercap.c | 155 ++++++++++++++++++++++++++- 1 file changed, 154 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/arm_scmi_powercap.c b/drivers/powercap/arm_scmi_powercap.c index ab66e9a3b1e2..e33829d5c551 100644 --- a/drivers/powercap/arm_scmi_powercap.c +++ b/drivers/powercap/arm_scmi_powercap.c @@ -33,13 +33,151 @@ struct scmi_powercap_zone { struct scmi_powercap_root { unsigned int num_zones; + bool enabled; + struct list_head node; struct scmi_powercap_zone *spzones; struct list_head *registered_zones; struct list_head scmi_zones; }; +static LIST_HEAD(scmi_powercap_roots); +static DEFINE_MUTEX(scmi_powercap_roots_lock); + static struct powercap_control_type *scmi_top_pcntrl; +static bool scmi_powercap_is_control_type_child(const struct scmi_powercap_zone *spz) +{ + return spz->registered && !spz->invalid && + spz->info->parent_id == SCMI_POWERCAP_ROOT_ZONE_ID; +} + +static int +scmi_powercap_read_root_children_enable_state(struct scmi_powercap_root *pr, bool *mode) +{ + struct scmi_powercap_zone *spz; + bool enabled; + int i, ret; + + *mode = true; + + for (i = 0; i < pr->num_zones; i++) { + spz = &pr->spzones[i]; + + if (!scmi_powercap_is_control_type_child(spz)) + continue; + + ret = powercap_ops->cap_enable_get(spz->ph, spz->info->id, &enabled); + if (ret) + return ret; + + if (!enabled) { + *mode = false; + return 0; + } + } + + return 0; +} + +static int +scmi_powercap_set_root_children_enable_state(struct scmi_powercap_root *pr, bool enable) +{ + struct scmi_powercap_zone *spz; + bool *prev_state; + int i, ret; + + prev_state = kcalloc(pr->num_zones, sizeof(*prev_state), GFP_KERNEL); + if (!prev_state) + return -ENOMEM; + + for (i = 0; i < pr->num_zones; i++) { + spz = &pr->spzones[i]; + + if (!scmi_powercap_is_control_type_child(spz)) + continue; + + ret = powercap_ops->cap_enable_get(spz->ph, spz->info->id, + &prev_state[i]); + + if (ret) + goto revert; + + if (prev_state[i] == enable) + continue; + + ret = powercap_ops->cap_enable_set(spz->ph, spz->info->id, enable); + if (ret) + goto revert; + } + + pr->enabled = enable; + kfree(prev_state); + return 0; + +revert: + while (--i >= 0) { + spz = &pr->spzones[i]; + + if (!scmi_powercap_is_control_type_child(spz)) + continue; + if (!spz->info->powercap_cap_config) + continue; + if (prev_state[i] == enable) + continue; + + powercap_ops->cap_enable_set(spz->ph, spz->info->id, prev_state[i]); + } + + kfree(prev_state); + return ret; +} + +static int +scmi_powercap_control_type_set_enable(struct powercap_control_type *pct, bool mode) +{ + struct scmi_powercap_root *pr; + int ret = 0; + + mutex_lock(&scmi_powercap_roots_lock); + list_for_each_entry(pr, &scmi_powercap_roots, node) { + ret = scmi_powercap_set_root_children_enable_state(pr, mode); + if (ret) + break; + } + mutex_unlock(&scmi_powercap_roots_lock); + + return ret; +} + +static int +scmi_powercap_control_type_get_enable(struct powercap_control_type *pct, bool *mode) +{ + struct scmi_powercap_root *pr; + int ret = 0; + + *mode = true; + + mutex_lock(&scmi_powercap_roots_lock); + list_for_each_entry(pr, &scmi_powercap_roots, node) { + ret = scmi_powercap_read_root_children_enable_state(pr, &pr->enabled); + + if (ret) + break; + if (!pr->enabled) { + *mode = false; + break; + } + } + mutex_unlock(&scmi_powercap_roots_lock); + + return ret; +} + +static const struct powercap_control_type_ops scmi_powercap_control_type_ops = { + .set_enable = scmi_powercap_control_type_set_enable, + .get_enable = scmi_powercap_control_type_get_enable, +}; + static int scmi_powercap_zone_release(struct powercap_zone *pz) { return 0; @@ -495,6 +633,16 @@ static int scmi_powercap_probe(struct scmi_device *sdev) if (ret) return ret; + INIT_LIST_HEAD(&pr->node); + + ret = scmi_powercap_read_root_children_enable_state(pr, &pr->enabled); + if (ret) + return ret; + + mutex_lock(&scmi_powercap_roots_lock); + list_add_tail(&pr->node, &scmi_powercap_roots); + mutex_unlock(&scmi_powercap_roots_lock); + dev_set_drvdata(dev, pr); return ret; @@ -505,6 +653,10 @@ static void scmi_powercap_remove(struct scmi_device *sdev) struct device *dev = &sdev->dev; struct scmi_powercap_root *pr = dev_get_drvdata(dev); + mutex_lock(&scmi_powercap_roots_lock); + list_del(&pr->node); + mutex_unlock(&scmi_powercap_roots_lock); + scmi_powercap_unregister_all_zones(pr); } @@ -525,7 +677,8 @@ static int __init scmi_powercap_init(void) { int ret; - scmi_top_pcntrl = powercap_register_control_type(NULL, "arm-scmi", NULL); + scmi_top_pcntrl = powercap_register_control_type(NULL, "arm-scmi", + &scmi_powercap_control_type_ops); if (IS_ERR(scmi_top_pcntrl)) return PTR_ERR(scmi_top_pcntrl); -- 2.47.3