From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A09ECDB46F for ; Mon, 22 Jun 2026 16:52:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KXhjFgbhEvwE+7GGBfh7My0VIVq6OjTLQwMtEz0hufY=; b=DJGFfo1PjPRvBxJ7LLQuWnJEvr cgndvouGgFkNrywJF9CRg6gc5HZCUpYhoDUFAcOWlU6FKCfinvujVA1W5TRp/A6iMdy5RYK28yJxv R9H3mSqnURMOjfu36PHbl0HvfXqG0czRNhBvrzHahE1EodBHPpd/O2Yz5APM6JULny3F3z+8AMegA LajTsRBYjhJibD47sx+vgxaT87B86QVaHCN6QLR2ndwyDhWKfKBsFMtTn1m62ut0RzG0jphbzaysj Eu76K3LMRWhAowANA2rHtltW8wVK6XwJbZ9RN258BOHe6TlsMEGI8/mCq3gVQqVBCq3wONZ2QlTP8 sdp8OmEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbhsT-00000005DC1-1a6W; Mon, 22 Jun 2026 16:52:05 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbhsS-00000005DBu-1wCB for linux-arm-kernel@lists.infradead.org; Mon, 22 Jun 2026 16:52:04 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 399EC43B13; Mon, 22 Jun 2026 16:52:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF0041F000E9; Mon, 22 Jun 2026 16:51:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782147124; bh=KXhjFgbhEvwE+7GGBfh7My0VIVq6OjTLQwMtEz0hufY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=C4kpffoqKELHy6h2iIonBbM+lwHOlkqgrFXueJXDfdgl75fDx8nTrSA+oGiGyoeAm 8CCy0uyoOREJUge4zC6mq+dv0w+QL43toIPSNlcNAZyZKDjugsy6al/c7V2Nxly4Pl B3u0wZw90AH5q2Vforbc/8novl4n4De9d7hKEY2j9fwmOHjRuuHlA8HYlkPOQSxTMr w8OjFxrmzo3xN9JG3zdPXZhL02HItS9kysxEXgHLRRSGAVfOqOYr/WF7zxLGK20H2R AQhZ61uSQFpPSM+xdZ5/Wi01z1P5qKOyIveeDb+LOtEbWIs/Vdg1dtFfhX3DZ+GRC2 IABQXBNVHhFSA== Date: Mon, 22 Jun 2026 12:51:54 -0400 From: Steven Rostedt To: Randy Dunlap Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Sebastian Andrzej Siewior , John Ogness , Thomas Gleixner , Julia Lawall , Yury Norov , linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 0/2] tracing: Move trace_printk.h out of kernel.h Message-ID: <20260622125154.6f5b9b33@fedora> In-Reply-To: <08b3c961-18bb-43d9-8d7f-8a87bcad0afa@infradead.org> References: <20260621093430.264983361@kernel.org> <20260622083440.GX49951@noisy.programming.kicks-ass.net> <08b3c961-18bb-43d9-8d7f-8a87bcad0afa@infradead.org> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 22 Jun 2026 09:40:45 -0700 Randy Dunlap wrote: > > Did you forget your C 101 class? If you use a function, you gotta > > include the relevant header. > > Also item #1 in Documentation/process/submit-checklist.rst. What is that? Remove all trace_printk()s before you submit? Because that is what you should do. But now you also need to remember to remove the include too. Or, I guess if someone uses it a lot, they may just keep it in their files without the trace_printk()s. -- Steve