From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0427CDB47D for ; Tue, 23 Jun 2026 07:47:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=I1Fyw9fJmtAP3F6H/X4okbn9VnSF0X5lGAx5UXg/ZEY=; b=C1Qm2DIMfviNB51s+cHAQeLQqi BZixddefQCZjygiYIx1NsEooQ+fJJ3rLT5kSS7dYhZtqG4Nr501pSEKkXYxuV8hVBc95UZHnNSuyl 0XamuTkaJwfUMts3Xti6tYsdSKG5Fu3UV74ScM1AoJsSRetllutVZdT7qRFLr8YM2XqJo4YAcCkMr mEZr1qMKGsxgvvJLWk284BDWS597KmsBO961ci3Pzsd1JlET/jZ+ZGOyz8Zas+TKaF4u1vYAMZcHj lE2rY9JG8ShWrpH3h1fmPhMWaQjC3FUqE8+RpDx8E8zSl5MAu17bAhxTb8p4iFU8EH6H+W9e8LP2q 1NLm2zkQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbvqd-00000005qtO-1wjS; Tue, 23 Jun 2026 07:47:07 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wbvqX-00000005qpQ-3Ou3 for linux-arm-kernel@lists.infradead.org; Tue, 23 Jun 2026 07:47:03 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-c88b59bfba7so2295710a12.1 for ; Tue, 23 Jun 2026 00:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782200821; x=1782805621; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I1Fyw9fJmtAP3F6H/X4okbn9VnSF0X5lGAx5UXg/ZEY=; b=aqbJEvFK7Vj8xreRvbbmGLkiVcrRuP751mG4MsK8IxU66vnX3VTEHP1WIC9v3rHfiq ykQTyPbxRT+yvdk3ihgYb8slD1qD1dkrKSftx3vloE8Zmkp65wfB7DQh1iGevlRsW0VL 1SCWNfB9fAn1NC6YOTZ0OKS09n458ESc3x43mscTzk+TCKM51rSV9/e6E4iJIbg+SnSD 2JqEDpLK7HS4MZgcFpv+itEqpzeW/tSnOD1XULah6H2kBvnWUVS60dbvwhxFIFk8QyS6 BTxjCRcUgzq1VjfcJJYp+JIFEYAhiR50BS5yqA7uS9xOjqI9y0FcGn6cBg+tbIKMsS2b zAGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782200821; x=1782805621; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=I1Fyw9fJmtAP3F6H/X4okbn9VnSF0X5lGAx5UXg/ZEY=; b=GmHYj0OuNDhv071VhPE3+O/nCU8hfcXPEopXMe073rSFPftzHw7QJpb/EK3CMTPX3e UhdtZ54gpqVZW9f9eJGwaG040nQ7v9adXv0uScb4NQIPrYBSX2OdtSLer4XfdLxr6fkN sLhMJATDCaS7FvrNTZfOY2Rdyp1BI3uAS9+zax9blNB+hzc56kwj680RdrvlLR69JbD6 wx3/YJqxJRTicIIChJI7Cdr0LAqwTQ9MOuHgYGAx11kfRAlkwPeKT9d/LpAMmnAFJITI bEZB5H48ILmYXbssrZkqYMpx4CqToi597+N4WMr9ZHmZYh54ftDprZoMwAydujHhys02 nWSw== X-Forwarded-Encrypted: i=1; AFNElJ+S5hYU4Oq4pqZ4tHfi1Vb0Y8qVwfuiLqH+Dkywc3IF13cs3TKZyWlVFlwVK7u9ldFMJ9HUGdgvZs1GytEl+1XH@lists.infradead.org X-Gm-Message-State: AOJu0YxedVD3ywAWRWQ2j0W8uXyN9buMQCqJrbHG1LQciRgfqPVbkM/s FVPM3jCOPwuN92ctRHx2dxQR+sxg3TF1P2awtZmY1NAO2bCnIBhoHHcJ X-Gm-Gg: AfdE7cnkEjsMW/8EuEwQhE31rJljVroRi+40/owAcKwvwMsEwTrQrgGVwTpJYiTpFH1 /LVUCZfwFgdr+4lmXczX2GATb9qa7PXX4VljD+kuCaeeu4fJzZMBzEn8Brcb3ZruflCIQfOEytP K83FiM+YOz2bfzWFQqU4PhqMD5rgc94en//nAZQGi0+P5H5kxMUc6v1p/oP7aD599+AdtNolkct FrjNtsMIJttPjsShTaoQzB7O6v62QyARJp/oEE0rFrut96PlwipUUa29zXKOYHVKjdaLL9Hbs2e PqWdOvpQrOrsVfrrTe5+erowXzFvTr0Io5zuAMY2qvjjzBIY5JKHtK0SKMq7Ok2Yqaw63XxL70i NphwjNb4KCT3DFZX9g1YDjOANGUUgYNW8u0+C5ViWnavs/BiI9ZVy0F40F3j2nJXacIqXxnOuAY WPuzot1SzS5OQ= X-Received: by 2002:a05:6a00:22ca:b0:842:74e3:48b5 with SMTP id d2e1a72fcca58-84597067827mr1756226b3a.13.1782200820845; Tue, 23 Jun 2026 00:47:00 -0700 (PDT) Received: from localhost ([2001:19f0:8000:3e6e:5400:6ff:fe38:3d01]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84564e76a0bsm11039417b3a.36.2026.06.23.00.47.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 00:47:00 -0700 (PDT) From: Inochi Amaoto To: Inochi Amaoto , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue , Yixun Lan , "Russell King (Oracle)" Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Yixun Lan , Longbin Li Subject: [PATCH net v2 1/2] net: stmmac: dwmac-spacemit: Fix wrong phy interface definition Date: Tue, 23 Jun 2026 15:46:34 +0800 Message-ID: <20260623074637.503864-2-inochiama@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260623074637.503864-1-inochiama@gmail.com> References: <20260623074637.503864-1-inochiama@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260623_004701_865343_882F5FD6 X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The current MII interface register definition from the vendor is wrong, use the right number for the macro. Also, correct the interface mask in spacemit_set_phy_intf_sel() so it can update the register with the right number Fixes: 30f0ba420ed3 ("net: stmmac: Add glue layer for Spacemit K3 SoC") Signed-off-by: Inochi Amaoto --- drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c index 223754cc5c79..3bfb6d49be6c 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c @@ -18,8 +18,10 @@ #include "stmmac_platform.h" /* ctrl register bits */ -#define CTRL_PHY_INTF_RGMII BIT(3) -#define CTRL_PHY_INTF_MII BIT(4) +#define CTRL_PHY_INTF_MODE GENMASK(4, 3) +#define CTRL_PHY_INTF_RMII FIELD_PREP(CTRL_PHY_INTF_MODE, 0) +#define CTRL_PHY_INTF_RGMII FIELD_PREP(CTRL_PHY_INTF_MODE, 1) +#define CTRL_PHY_INTF_MII FIELD_PREP(CTRL_PHY_INTF_MODE, 3) #define CTRL_WAKE_IRQ_EN BIT(9) #define CTRL_PHY_IRQ_EN BIT(12) @@ -118,7 +120,7 @@ static void spacemit_get_interfaces(struct stmmac_priv *priv, void *bsp_priv, static int spacemit_set_phy_intf_sel(void *bsp_priv, u8 phy_intf_sel) { - unsigned int mask = CTRL_PHY_INTF_MII | CTRL_PHY_INTF_RGMII; + unsigned int mask = CTRL_PHY_INTF_MODE; struct spacmit_dwmac *dwmac = bsp_priv; unsigned int val = 0; @@ -128,6 +130,7 @@ static int spacemit_set_phy_intf_sel(void *bsp_priv, u8 phy_intf_sel) break; case PHY_INTF_SEL_RMII: + val = CTRL_PHY_INTF_RMII; break; case PHY_INTF_SEL_RGMII: -- 2.54.0