From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CDE00CDE000 for ; Wed, 24 Jun 2026 19:15:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MATdxFQBtgKcjsF1nGjyY/BUTe8cQUAE71nrnYXCJwM=; b=zyZ6twLtDgOEp7SQXTtT8IQ+pD ohbj1gNRvBivnLcTKSenhqOEVTmMeh4McSCXO1p2FJNjBB5wsYn7/oFIL9npjH2SCIYAWvfyEz2bq V77voVOrGOfE8RLMwfjbD5R+0o1lDV0+aw3EGeCx/gwaLGk8suI5F9rNgBC3ZWDcJtxKfw/I1eVyP zRau9MWUvPfCmbiVYcp1MBrSZaTLZTYpTeoqDUUDRb9zeCVWtDaQgsUYY3KOXhBVde53bCtwkAVcT uuZfRE62p/086YOI0K2BqXWFyQpDXSqJHZt4cA6kuLpkRv0fOTYwWQqnarnwQRZiNIC3rTewJ7ywt KLT0nfcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcT3s-00000008Fiw-2UMY; Wed, 24 Jun 2026 19:15:00 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcT3q-00000008FiI-2ILH; Wed, 24 Jun 2026 19:14:59 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 45848236; Wed, 24 Jun 2026 21:14:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782328457; bh=4l3LwfXynM0MsWP2kcvzPf7S3XQAOuf0AlSVOoYKWIE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GaqAF6Y8/h3JELG3xUHoxAj0t/lD1G8Yuz7xkdZoqjtld0QtIDHM5nhx+A5vDQmV7 ovby1WLWvV7w1axQLbuA+3u3efsU0JcAHedtGdbOdmgidHRiNaqhuK/pBzB30v6axE YikzPxT71bFWSPP4vGlqpk0U3yjqe+Jgu9MgZUnk= Date: Wed, 24 Jun 2026 22:14:55 +0300 From: Laurent Pinchart To: Frank.Li@oss.nxp.com Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Mauro Carvalho Chehab , Dafna Hirschfeld , Heiko Stuebner , Bryan O'Donoghue , Vladimir Zapolskiy , Loic Poulain , driver-core@lists.linux.dev, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, imx@lists.linux.dev, Guoniu Zhou , Frank Li , Guoniu Zhou Subject: Re: [PATCH v2 2/4] media: mc: use fwnode_graph_for_each_endpoint_scoped() to simpilfy code Message-ID: <20260624191455.GD851255@killaraus.ideasonboard.com> References: <20260624-fw_scoped-v2-0-0a8db472af4a@nxp.com> <20260624-fw_scoped-v2-2-0a8db472af4a@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260624-fw_scoped-v2-2-0a8db472af4a@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260624_121458_735976_8A1D1FD9 X-CRM114-Status: GOOD ( 13.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 24, 2026 at 01:00:10PM -0400, Frank.Li@oss.nxp.com wrote: > From: Frank Li > > Use cleanup helper fwnode_graph_for_each_endpoint_scoped() to simpilfy > code. > > Reviewed-by: Guoniu Zhou > Reviewed-by: Andy Shevchenko > Signed-off-by: Frank Li Reviewed-by: Laurent Pinchart > --- > drivers/media/v4l2-core/v4l2-mc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c > index 937d358697e19..5d7fcd67dc42e 100644 > --- a/drivers/media/v4l2-core/v4l2-mc.c > +++ b/drivers/media/v4l2-core/v4l2-mc.c > @@ -324,12 +324,10 @@ EXPORT_SYMBOL_GPL(v4l_vb2q_enable_media_source); > int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd, > struct media_pad *sink, u32 flags) > { > - struct fwnode_handle *endpoint; > - > if (!(sink->flags & MEDIA_PAD_FL_SINK)) > return -EINVAL; > > - fwnode_graph_for_each_endpoint(src_sd->fwnode, endpoint) { > + fwnode_graph_for_each_endpoint_scoped(src_sd->fwnode, endpoint) { > struct fwnode_handle *remote_ep; > int src_idx, sink_idx, ret; > struct media_pad *src; > @@ -397,7 +395,6 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd, > src_sd->entity.name, src_idx, > sink->entity->name, sink_idx, ret); > > - fwnode_handle_put(endpoint); > return ret; > } > } -- Regards, Laurent Pinchart