From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1B30CDE013 for ; Thu, 25 Jun 2026 23:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7rTeWGRC3qlYe3M/STi4OqC/ckIFBCcw0pmuKzcM+Ms=; b=fC9dkRnqBg/uFNYd711uqsxOzL 9mMSkUFc0Wr9f3hyUvM+lp8FrMND1Nco5YODWk/6qioQXrvtqym4ZcosNGDd6UulSA7+x22AmbSsF q2F/WtC8hxm4TJLR9oU3rOjrCSGdMr90z90lU2UApZwWSzjgeJD/VDM7MHwcTosa8SPwYWJ1inHVx I21DSjzII4lNV5tnnCdGVAnDqB4hRWTlT7K9LnrnF0Phc9OUAt0QVW0DRvJhU9iL3b7xJuf+U2kYA 9mhuKzQMbhBsV2e0ex3O0TWw57VDwGAnXwTO+5wxbgAl4K63N0GZt1mWr08EnaYsILkNbF9eYGw9i fFSTEkJg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcthw-00000009zta-1fvI; Thu, 25 Jun 2026 23:42:08 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wcthv-00000009ztU-2CIX for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2026 23:42:07 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A12BF40BF5; Thu, 25 Jun 2026 23:42:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9DEF11F000E9; Thu, 25 Jun 2026 23:42:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782430926; bh=7rTeWGRC3qlYe3M/STi4OqC/ckIFBCcw0pmuKzcM+Ms=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ERWk9tSfkvUB3gpMoi+r8/npeOf+VTcK6LEcTQ+ydlZM4R04BnjE7NoxRlL2Y7oOp HwEILF3l/MEtXv4l1oapXtPAddR7mVIcAbFM+/NzAauaraVXtWjthqV/7Xr9jV0rmP iV/aTYKta1D6uPYRp+2hh9+GTlghECm8I505IDeByN96e5NV0eCKP7muVv5sc3JnQG O3K8AFvvCi6QK5nN6WRqQQQyuO2ODeP0WbSkJkHgCIFXVq1+HVSkMdVsvtq4txrVyP sezhtjuTBGj4tnd2fWtTX6Neebzlxe0449kNqUc5+ZQaEKrKtQDmJHaKYNRwLyfJcc gFiMuxnkCmkKg== Date: Thu, 25 Jun 2026 16:41:58 -0700 From: Nathan Chancellor To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Sebastian Andrzej Siewior , John Ogness , Thomas Gleixner , Peter Zijlstra , Julia Lawall , Yury Norov , linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH v4 2/2] tracing: Remove trace_printk.h from kernel.h Message-ID: <20260625234158.GA261868@ax162> References: <20260625104007.041432666@kernel.org> <20260625104402.210473477@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260625104402.210473477@kernel.org> X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Steve, On Thu, Jun 25, 2026 at 06:40:09AM -0400, Steven Rostedt wrote: > From: Steven Rostedt > > There have been complaints about trace_printk.h causing more build time > for being in kernel.h if it changes. There is also an effort to clean up > kernel.h to have it not include unneeded header files. Move trace_printk.h > out of kernel.h and place it in the headers and C files that use it. > > Link: https://lore.kernel.org/all/CAHk-=wikCBeVFjVXiY4o-oepdbjAoir5+TcAgtL12c4u1TpZLQ@mail.gmail.com/ > > Suggested-by: Yury Norov > Acked-by: Masami Hiramatsu (Google) > Signed-off-by: Steven Rostedt This patch breaks lib/test_context-analysis.c for me in several configurations: In file included from lib/test_context-analysis.c:9: In file included from include/linux/local_lock.h:5: include/linux/local_lock_internal.h:46:2: error: use of undeclared identifier '_THIS_IP_' 46 | lock_map_acquire(&l->dep_map); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/lockdep.h:541:69: note: expanded from macro 'lock_map_acquire' 541 | #define lock_map_acquire(l) lock_acquire_exclusive(l, 0, 0, NULL, _THIS_IP_) | ^~~~~~~~~ In file included from lib/test_context-analysis.c:9: In file included from include/linux/local_lock.h:5: include/linux/local_lock_internal.h:53:2: error: use of undeclared identifier '_THIS_IP_' 53 | lock_map_acquire_try(&l->dep_map); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/lockdep.h:542:73: note: expanded from macro 'lock_map_acquire_try' 542 | #define lock_map_acquire_try(l) lock_acquire_exclusive(l, 0, 1, NULL, _THIS_IP_) | ^~~~~~~~~ In file included from lib/test_context-analysis.c:9: In file included from include/linux/local_lock.h:5: include/linux/local_lock_internal.h:62:2: error: use of undeclared identifier '_THIS_IP_' 62 | lock_map_release(&l->dep_map); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/lockdep.h:545:47: note: expanded from macro 'lock_map_release' 545 | #define lock_map_release(l) lock_release(l, _THIS_IP_) | ^~~~~~~~~ 3 errors generated. The following diff resolves it for me, should I send it as a separate patch or do you want to just fold it in with a note? diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h index 621566345406..2301a701ffbb 100644 --- a/include/linux/lockdep.h +++ b/include/linux/lockdep.h @@ -10,6 +10,7 @@ #ifndef __LINUX_LOCKDEP_H #define __LINUX_LOCKDEP_H +#include #include #include #include -- Cheers, Nathan