From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 407D6CD4F26 for ; Fri, 26 Jun 2026 07:20:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:CC:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nsDpEa3ZukNKDY+tJmpbprch+iDsYOyLe8vx+gpj3Zk=; b=SmB4W8MVuQxpDmcrAO+84GhceH sZH8U0NF8RdVZ+pAX0hw3i8nQMluelXR4Swlb/ZRs7GQqbLs8AjTygVe69G54zCJFJHG9MHDeE/WR NJ89LhpLtk2kAxYCUKM66X0o2Qr8+zNmuek9K44a9y9RwhEuf3DY5toH4RYv0EzTTjt3J59U73jz4 Nrbry11WtCZARTQp08/AhNM/UHAnBvnKIYuz7GDYxeMmSi5hmxfmgd3bs5BKH2wjuy1jx90fVOUBh Ku5lrvH9bhfRJB+FgPrHBSNbSsZWfuT4oIUqYD70dgdVmcu2kcsxLgf/8sglePxF88grmaPd5yryh cY+gKfuw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wd0rJ-0000000AfMR-3sTm; Fri, 26 Jun 2026 07:20:17 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wd0rH-0000000AfM3-0Hut for linux-arm-kernel@lists.infradead.org; Fri, 26 Jun 2026 07:20:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1782458415; x=1813994415; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ISWXHKaawn9h3mmKev98WgFcthqdhjvovZhyVz7j7f8=; b=DMgX3KBb5DF5BuXjqVCVb6mRfQfkFF7ZyyiUAJQ7cUAmvD/nxNxzQwt5 zp4M8xWcNKla8xk6BOm21BSYYHcQKGvh4dLmQALIxUOz5KTWIv8IqwP0Y mzYr/PFlWWCLarYT1zNMvOAbgczmSfeEVQPG+k5+/ZXaDQTvnQqRwkULE aipvrC5vw9Z3zGqQNBi8WZ3WXsqiNwc/7lxJGvt6Q3FMYXDqcY6UZzC+0 BFtClTRf0g4Ery5NEeePz1xrIlvXnR8CdQyfl8Q3z5IS6E675rOYeaKae gvzrS8wutcpP1HOurrnlzgOV7hp0yyQQDS39dr+3HSzeIm9VTPE8oYwVN A==; X-CSE-ConnectionGUID: /ckA0SlxThe1rb4/x1hBOQ== X-CSE-MsgGUID: JEpd77qjQQicd2yYZkhrag== X-IronPort-AV: E=Sophos;i="6.24,226,1774335600"; d="asc'?scan'208";a="58875964" X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa4.microchip.iphmx.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 26 Jun 2026 00:20:14 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58; Fri, 26 Jun 2026 00:20:12 -0700 Received: from wendy (10.10.85.11) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.58 via Frontend Transport; Fri, 26 Jun 2026 00:20:09 -0700 Date: Fri, 26 Jun 2026 08:19:19 +0100 From: Conor Dooley To: Icenowy Zheng CC: Conor Dooley , Joey Lu , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 1/7] dt-bindings: display: verisilicon,dc: generalize for single-output variants Message-ID: <20260626-astrology-mural-853d3860e048@wendy> References: <20260625094449.708386-1-a0987203069@gmail.com> <20260625094449.708386-2-a0987203069@gmail.com> <20260625-bobbing-annotate-d1c4d6874ee2@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7SoCkx0H/fbweAJy" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260626_002015_195972_E139825B X-CRM114-Status: GOOD ( 21.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --7SoCkx0H/fbweAJy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jun 26, 2026 at 01:27:21PM +0800, Icenowy Zheng wrote: > =E5=9C=A8 2026-06-25=E5=9B=9B=E7=9A=84 17:33 +0100=EF=BC=8CConor Dooley= =E5=86=99=E9=81=93=EF=BC=9A > > On Thu, Jun 25, 2026 at 05:44:43PM +0800, Joey Lu wrote: > > > +allOf: > > > +=C2=A0 - if: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 properties: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 compatible: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 contains: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 c= onst: thead,th1520-dc8200 > > > +=C2=A0=C2=A0=C2=A0 then: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 properties: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clocks: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 minItems: 5 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 maxItems: 5 > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 clock-names: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 minItems: 5 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 maxItems: 5 > >=20 > > All the maxItems here repeat the maximum constraint and do nothing. > >=20 > > Since you didn't change the minimum constraint at the top level, your > > minItems also do nothing. > >=20 > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 resets: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 minItems: 3 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 maxItems: 3 > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reset-names: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 minItems: 3 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 maxItems: 3 > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 required: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - resets > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 - reset-names > >=20 > > Both conditional sections have this, but the original binding doesn't > > require these for the thead device. This is a functional change > > therefore and shouldn't be in a patch calling itself "generalise for > > single ended variants". >=20 > Well yes they're required. >=20 > Should I send a patch adding the `thead,th1520-dc8200` part of the > schema? If you mean the code above, no. Adding a conditional section when there's only that compatible doesn't make sense. What you could do is just add it at the top level though, which would also benefit this patch since it'd not have to be conditionally added for the new nuvoton device. Just note in your commit message about what the ABI impact of the change to required properties is (effectively nothing because it's optional in the driver and the only user has the properties). > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 resets: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 minItems: 1 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 maxItems: 1 > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 reset-names: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 items: > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 -= const: core > >=20 > > This is just maxItems: 1. >=20 > Well the implicit rules of DT binding schemas are quite weird... I don't think it is that strange, as the binding has reset-names: items: - const: core - const: axi - const: ahb so just constraining to one item is the simplest way to do this without duplication. --7SoCkx0H/fbweAJy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCaj4n9wAKCRB4tDGHoIJi 0jrNAQDGXff+FunKOyT28vcC9lrAn2ZYxmbPl/I52t/aaUdp9wEAq5x1xHEXvb49 A3qqhyWWSlJZMo2jH5vbzEt1icggMwk= =ND87 -----END PGP SIGNATURE----- --7SoCkx0H/fbweAJy--