From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 57178C43458 for ; Fri, 26 Jun 2026 14:30:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J0oH+PQ9BpfCFKuRcRrHjrQvw2d5pVGbbxbaEFYzceE=; b=kcUMuT37y9+PBbhA2wkkGrhAVw Vb2pvkE2IyhBzmqqejqrOnC1aPl4FxWvrl3e4pDeBZQcXAkARqslUb2NROGXrKXXZNHDmZAGXsiiL K9BpCtcQjUNWemLK/j/6UzBetP0wTLJTvedXMbzcoOIcdO3s75hTMWw0UoyACFa9f4oSve59oYJ7o 0aTlvw293mPkUALxydgj+MhYsFQyzmBMUKzAx8agwx7r984+uZfEJJf8JElT9hh/QVR7kT8MBkksV xlElCsp9S/xDPqz8mv7pGLA/7c911WZCldxP/FfSOezgSgRhyn9dLD4DvGgp7FafqaUJ4X2v0sD6N WMLEo5Fg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wd7ZO-0000000BSQe-2bun; Fri, 26 Jun 2026 14:30:14 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wd7ZL-0000000BSQ8-3zrg; Fri, 26 Jun 2026 14:30:13 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B2106174; Fri, 26 Jun 2026 16:29:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1782484165; bh=62WGItH/nKsA4jiLztr8BealNzEavczRY+wH5drktQo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JxLk6gzym/QGytAkBH6IOdj4e4dK7npLijt1RCGCdtCWFmDs5lTRPIow0tPH+AScd plWks+NGQn7YO1NeORSXTtRh62/fwLX7qtfOaJA2E+a9YAuI0haNN/uOAModZ4Hca7 Q4izlUBS4mmnbjMsCoN2AaZx9pLUorY9Rnu8AHpM= Date: Fri, 26 Jun 2026 17:30:05 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jacopo Mondi , Sakari Ailus , Jimmy Su , Matthias Fend , Mikhail Rudenko , Daniel Scally , Jacopo Mondi , Michael Riesch , Benjamin Mugnier , Sylvain Petinot , Paul Elder , Martin Kepplinger , Quentin Schulz , Tommaso Merciai , Svyatoslav Ryhel , Richard Acayan , Thierry Reding , Jonathan Hunter , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Bjorn Andersson , Konrad Dybcio , Geert Uytterhoeven , Magnus Damm , Heiko Stuebner , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux@ew.tq-group.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 2/8] media: dt-bindings: video-interface-devices: add video-interface-devices.h references Message-ID: <20260626143005.GD2363897@killaraus.ideasonboard.com> References: <20260626-kbingham-orientation-v2-0-47178be927b4@ideasonboard.com> <20260626-kbingham-orientation-v2-2-47178be927b4@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260626-kbingham-orientation-v2-2-47178be927b4@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260626_073012_149659_40697835 X-CRM114-Status: GOOD ( 21.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Kieran, Thank you for the patch. On Fri, Jun 26, 2026 at 01:07:54PM +0100, Kieran Bingham wrote: > Expand the documentation of the video-interface-devices orientation to > reference the include/dt-bindings/media/video-interface-devices.h header > which provides human readable defines for the orientation enum, to help > avoid hardcoding values in dts. > > Signed-off-by: Kieran Bingham > --- > .../bindings/media/video-interface-devices.yaml | 17 +++++++++++------ > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/video-interface-devices.yaml b/Documentation/devicetree/bindings/media/video-interface-devices.yaml > index a81d2a155fe6..c9c3f4f16719 100644 > --- a/Documentation/devicetree/bindings/media/video-interface-devices.yaml > +++ b/Documentation/devicetree/bindings/media/video-interface-devices.yaml > @@ -392,17 +392,22 @@ properties: > The orientation of a device (typically an image sensor or a flash LED) > describing its mounting position relative to the usage orientation of the > system where the device is installed on. > + See include/dt-bindings/media/video-interface-devices.h. If you want this to be a separate paragraph, you need a blnk line on top. Otherwise, Move "See" to the previous line. Reviewed-by: Laurent Pinchart > + > $ref: /schemas/types.yaml#/definitions/uint32 > enum: > - # Front. The device is mounted on the front facing side of the system. For > - # mobile devices such as smartphones, tablets and laptops the front side > - # is the user facing side. > + # MEDIA_ORIENTATION_FRONT > + # The device is mounted on the front facing side of the system. For > + # mobile devices such as smartphones, tablets and laptops the front > + # side is the user facing side. > - 0 > - # Back. The device is mounted on the back side of the system, which is > + # MEDIA_ORIENTATION_BACK > + # The device is mounted on the back side of the system, which is > # defined as the opposite side of the front facing one. > - 1 > - # External. The device is not attached directly to the system but is > - # attached in a way that allows it to move freely. > + # MEDIA_ORIENTATION_EXTERNAL > + # The device is not attached directly to the system but is attached in > + # a way that allows it to move freely. > - 2 > > additionalProperties: true -- Regards, Laurent Pinchart