Re: [PATCH RFC v5 00/12] ZTE zx297520v3 clock bindings and driver

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1348 bytes --]

On Sun, Jun 28, 2026 at 10:58:55PM +0300, Stefan Dösinger wrote:
> Hi,
> 
> I am sending version 5 of my zx297520v3 clock patch. The major change is 
> using regmaps rather than raw mmio to access the clocks and moving reset 
> handling into its own mfd/aux bus driver.
> 
> I think the list of clocks in my driver is fairly complete; It is 
> certainly a lot better than what the downstream ZTE drivers have. I 
> deduced a lot of it by trial and error. I am sure there are some clocks 
> missing that will need to be added to the binding later. Afaiu adding 
> clocks is not an issue, but removing or reordering them is an ABI break.

Correct, you can add whatever you want as long as the existing defines
do not change.

> Signed-off-by: Stefan Dösinger <stefandoesinger@gmail.com>
> ---
> Changes in v5:
> *) Use MFD instead of aux bus for top and matrix clocks
> *) Move top and matrix bindings to soc/zte
> *) Give USB PHY its own resets
> *) Other localized changes are noted in the individual patches
> - Link to v4: https://lore.kernel.org/r/20260616-zx29clk-v4-0-ca994bd22e9d@gmail.com

Bindings seem fine to me, I'll be happy to give you some r-b tags when
you go non-RFC. To be frank, I think you should drop them as you've got
no significant questions here I think and you'll be taken a bt more
seriously.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]