From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BF0CC43327 for ; Mon, 29 Jun 2026 09:45:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To: Content-Type:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FAskuW7YNLZbSrb6KKYMcM9G4tb5lmCN8XMAc2jTzFY=; b=WDAZJWv7UIQiL+FQXt2zdlH4mG EsIiGFLnbm46Oe3CGC9ls8T7kw8v3OwYjNd/M+LcHmRACqypUM7IUUhUAcpjYwXs8FffoKEI7+g+k 6xD6KLo4Afi0HQT5sSsygcjqyiDRVZm/RERhn5PM2WY/fEzNrgIXgdQvPSMvq4FKc5nrCrKeOOkUs ZwA3kn2GqEn0R0ugRXfoF5ToduqsplafUcppKEyCBYHB8ezxdAdn7k3QJBBsz+mJM4jVwiMQup1+h zn8YzdVHbn2f/g9s42zaLpHbadMx/vutd7josUQNdW5C64aKYyo6dCld1MqFZ1frTPTaIa+wd9MVd KtipR1Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1we8Y5-0000000EDdh-0HRW; Mon, 29 Jun 2026 09:45:05 +0000 Received: from mail-northeuropeazon11012028.outbound.protection.outlook.com ([52.101.66.28] helo=DUZPR83CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1we8Y2-0000000EDbp-2n9z for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2026 09:45:03 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vYrEcN+mGxrggAw+xKpyh8NsDEHXG0GUF5RGMzR7fcUZY0tQjPnM9S3arm8Q+qPZYH69722p7MCve5ZuJ//cig0hFbhQTuCR4tfW6iK1NmCwWHD0dTG4Jtt17g6C8NmU0ZklCjmtqLNd7Ru+LGo4F1nQMZay1IKVfcqauVavM91Eu/mRcSh0nf3UHaIw9DWX7EntSgHMENyPPp11FsBtBh0cWUv2E3RtMPKagLBawi4kgM+VYcjy/CWnHVopE0SCdlmUJP0tupk9rOR4+Y87V2ArEqv/F2u8FdqzvcDtVGmrcLo/LEqkVSdhwAi3mswje/QA2wL919J8ddi/cfstqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FAskuW7YNLZbSrb6KKYMcM9G4tb5lmCN8XMAc2jTzFY=; b=wedK1jbiidG5Jonzdrrpw6xZUmqRRbVYQcFenkz8D8CcAt4syhqRXkht1mFLfMIwId6ZzwpD96GgCHWR1ht7kJJc/4Sw9mdnkQaWg2Y7Ene2Ik6oU6Vhn3yr+Ui9heURo3kdPSR0TSvV/9uxIj3iJGEs4T8iqKUo2RibM3FQy9X8B9ZYyzGoXRa7F7JxUGJgJMBFAQyuXK5h+urhOYLFPXWqpUI3TxHOAcsR8peAbp2QeJAnftSuliVqEy8uJ7lexWN3NXQJWe4YVY3myd3Y+TRLNAZF0dDoxOWBICZfq9eHv4NbmNNE62mWBDENSBtsVJSm+2sK1vTnHPKO+puu/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FAskuW7YNLZbSrb6KKYMcM9G4tb5lmCN8XMAc2jTzFY=; b=Zg08++ewZJhJsxRjca5JiAN24HZjnA2sHB1LZc9NoJcmG5/x2CG3aYQrwl6e4+7RHwFZ+GTeY1JviW3DqmxBtBAByp/7rGf/PdimQoE0dsc4e9qxm4IjAgjITXVTDLdyFTo0Lgj93FkHEiKjIlc+7mihtEcFyRBfggCnnNz9cB8J6XvstBb08sZS3it3edYaYs4WEGz9nkFoEo5O2fANqIWR46pdjFZCuGwXjRSzdB1w0pg+KVc02EVxtmUx37578EIwhBXZIqEky1Dj/J21/C2iZcJ9lMA42uCyoHSgIxnkj+hbLPnmXA0U2fgHP2BPGnXVpJPMWpMw/CW38nzNPA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PA6PR04MB11909.eurprd04.prod.outlook.com (2603:10a6:102:51c::22) by AM8PR04MB7378.eurprd04.prod.outlook.com (2603:10a6:20b:1d8::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.159.19; Mon, 29 Jun 2026 09:44:58 +0000 Received: from PA6PR04MB11909.eurprd04.prod.outlook.com ([fe80::a4b:fa4e:7fe7:e6a2]) by PA6PR04MB11909.eurprd04.prod.outlook.com ([fe80::a4b:fa4e:7fe7:e6a2%5]) with mapi id 15.21.0159.018; Mon, 29 Jun 2026 09:44:58 +0000 Date: Mon, 29 Jun 2026 17:39:39 +0800 From: Bough Chen To: ziniu.wang_1@oss.nxp.com Cc: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/7] mmc: sdhci-esdhc-imx: restore DLL override for DDR modes on resume Message-ID: <20260629093939.m223hzc2luh3gysd@nxp.com> References: <20260629091954.3227151-1-ziniu.wang_1@oss.nxp.com> <20260629091954.3227151-3-ziniu.wang_1@oss.nxp.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260629091954.3227151-3-ziniu.wang_1@oss.nxp.com> X-ClientProxiedBy: SI2PR06CA0001.apcprd06.prod.outlook.com (2603:1096:4:186::21) To PA6PR04MB11909.eurprd04.prod.outlook.com (2603:10a6:102:51c::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PA6PR04MB11909:EE_|AM8PR04MB7378:EE_ X-MS-Office365-Filtering-Correlation-Id: 2efec9de-aa30-4ee7-9647-08ded5c314fa X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|19092799006|23010399003|376014|56012099006|6133799003|3023799007|4143699003|22082099003|18002099003|11063799006; X-Microsoft-Antispam-Message-Info: mRkgtMzby874fYCT8Zlxe7fNDoaXPeqw6h3+tXlYMNAmm61MKbMjajONwz2/xQsOslOy6Vi7CtyKwbGW7TfcjRmPCE2/DPEX785NfqtkNv5MHCPXwuuB0KzzZlk/b8BIX5pltCCYnKRRjtWcWhQDbmJ51/4HpZ6IwKLkMtCUjODoSf8lcbFVGSBDyzPAZRQOxNWGObtHRK/RGJcWTYebsL+ijzoswBtwZf0NlBos/gRIhgrzf1i35viRsTNDftrsi4BEXLxAurOc0mRX+WwewJ82xZ9c6N+M0UCsiy6MP1N3+PtjjTHajPy1rTaGLuG6Y84DVUcsE8O8kTOcO0B2Ut9Sa8J+Bn9o/0CWBFDlwC6PMAa4z9jvVd+0wAe5vQe3b8klLA0X7S540h4CzxRM3YmC8jA4ohk8M6TcwQ6trBk+I+wNfoQFt0LcIyOXdQts0Dwire7LCB6h33lenK8AMGuw/OhEZnoXr9OdrkGl3SKC9LXZmKH2xEnoSmWSEg47N4fRJacDzw7cg2vIdaI3nO1/6cyhSmzC6aCfn9TiRksaetNZo2g06VrMZz8YIdpyuThwayfpIx5QbEo1s+Cd4F8/hUoslDyJEhbQitoLN+JOeCB2hh2cxQCgn4ctBS44vN/nGUaDAVd1UcUERh+9sqVdCUuWfOEMCdoYhi3wRpU= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PA6PR04MB11909.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(19092799006)(23010399003)(376014)(56012099006)(6133799003)(3023799007)(4143699003)(22082099003)(18002099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ot6ESc3tqegdV3U3ti9hK91ZjJiS+AgwCb2PbNbJJf+k18SwXigXfvd7Bs/k?= =?us-ascii?Q?hEEhD2ZwJDQyS4SplpoogslrAUZ457iB/CfPFqAXnLJJNodwzU55r/ZGdFGL?= =?us-ascii?Q?hJiDNNvoImo1ojxImovyBs2dZ1FDM07m1MezYenJ/I+osMnH+xRiw6ckVzsq?= =?us-ascii?Q?znHSzby8+O6Ns2augf2AX3N1zwibeVUlk+V9UnI8AVGeb/hv2VaGp0IbtAwW?= =?us-ascii?Q?CViAmYmSMf6BE/GjBgI7fNHIqfyFEdJ+LYPCKHf2vnB10RSQHjgkMBSQeCQq?= =?us-ascii?Q?iIFFEA3WGtWqeTKssn0SLu8eCorEatF9ygcCHC/TIk8JVhGjWPBZlSq5Q2iM?= =?us-ascii?Q?ONmGh7UzU7wXlVHOvS6cYoPtrIhk2MBtNtcUD8Vf2Uz6R9hiExrdvW/y+J/H?= =?us-ascii?Q?Kwt6Vz80DjWsQfRRxsBgm3WHJ3Y2o3CbfIG0z2WdhdZuV+uG3ObNwwWmxIzF?= =?us-ascii?Q?Psd0eb2yR8H5ToH5M1Zn5qUpRaGrglKsOrKFmizjevwOcqtppyNRyhaPQ6/d?= =?us-ascii?Q?UIKa68cH9uDuTzhgBzI+4je68hONg7f/QD+2yzMKvst1cCzfJRPm2BCayTyT?= =?us-ascii?Q?17XmLasd2BTxUTP2d6aCXA+htXX0vtt1Xk9iXj8Pq3Q5EWuWtMwFa/JPUsWv?= =?us-ascii?Q?zufJlktm/zmWkfKDyTSc+MiA8AS2jabWphw5UJsC4sigULFalhumeuw31A3Q?= =?us-ascii?Q?rKEozKmljCFfauAhCVzYlJ9ld/Ot/1XOaR/BtHLIpieTnfmdty55kuzt/k7J?= =?us-ascii?Q?PPD2FaOFzROQBfS7yQS9Xjp3RFnhh9Afzx+a211aKoSvAOKaev18YXRsLST8?= =?us-ascii?Q?05CQuf1M4NXYz6bcKcg4ghaODG0DYAfrHC00l/Eg9lzT045lpBgBMr2iJKPh?= =?us-ascii?Q?Mgb43nqPbjINPtS/+8R5Iew0ldEjwRA5+dEL7lOTiSOoperIpAa9cX8nKJOJ?= =?us-ascii?Q?JayKLpu/KWcgtR0IIo3+skW6Ja2gUV+seG1DP8RWCNtzDt69VtmM9RFshu1W?= =?us-ascii?Q?hle54D9XaEkBBAFbJebdsEPawiB5/GP51uRDWx93cap/DeegzfQmco3T6oao?= =?us-ascii?Q?7E6ES5SumXCiyahdYpYDrlqFA0AsGCkzjtCCc/RcSLspvYEjI59Yi5t6RvAc?= =?us-ascii?Q?pDNZanb1jqK+cwVMWCcZ2dx/e7Nn5RuBLZaT5RT7X/6UgmZg/n4/OYcUkv3S?= =?us-ascii?Q?PWez1uzX7nR0iB7+DjNE78NBNgkyITLtQBgxeqHMoT6/UcdZ3RWLVwU+TQm6?= =?us-ascii?Q?NBB7qF5BWXEAnloqe6JzelPzWJvb803jXJKPZArTqq7K+x0xTh59/MHxDwM/?= =?us-ascii?Q?6q/kpH4YEdQglWv8BGI9QikwFjvul2TfpBMZ8J5t2QyfjoYwSitN+sKq5eYJ?= =?us-ascii?Q?MHlbvVVWfrk58BgQZqZyiGkD7qYt51SXtCmc/DUn89XZZVeF/laqR7/dBGek?= =?us-ascii?Q?R0HJGx4W6XiKVgJYWqQLDJNlyUeMND+u+nnGencvrT1ZCbDvcr9Zz17477C+?= =?us-ascii?Q?00vTCjwRBq8WRG6bPZkXnm/GYExjLJRwXtBQ+lgvzZbHzyZmjzatPMAriiQk?= =?us-ascii?Q?VhYOv2FwWEMLYR8SoUQXsemULp+t6V3CR92Qlb5pVCCS/GtZloM5pcJErHjx?= =?us-ascii?Q?UVFhp0jJxLPpeGiuT/SILYi7SBao8jytFekuwHoMty4xg1pxnWEneF7djPP4?= =?us-ascii?Q?YWC+6Ag0x0SoN5rB08wF9iL/D7bgANGHTd52Qhrz2AllBYWdWoTke4ETd8ry?= =?us-ascii?Q?9DdqMlUm20Bq2tll4eM0XiJnQkQ7A481/zoKNQtvaHwPUJebwggC?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2efec9de-aa30-4ee7-9647-08ded5c314fa X-MS-Exchange-CrossTenant-AuthSource: PA6PR04MB11909.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2026 09:44:58.2507 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Yf6wMZ2Y8F6OqjUUHh1dpQWTxgqRiejwq4viwdhMhICX7SzCsG8lcHAaw5ujC/m1Acj0TW7ltokRpCDpuHCLreYDA+CwO6jRFNo0qJoEASpAL0y+02pYbdhrywH//Ron X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7378 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260629_024502_715504_FE77E52F X-CRM114-Status: GOOD ( 24.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 29, 2026 at 05:19:49PM +0800, ziniu.wang_1@oss.nxp.com wrote: > From: Luke Wang > > sdhci_esdhc_imx_hwinit() unconditionally clears ESDHC_DLL_CTRL by > writing zero. For SDIO devices that keep power during system suspend > and operate in DDR mode, the card remains in DDR timing while the host > DLL override configuration is lost. > > Extract the DLL override setup from esdhc_set_uhs_signaling() into > a helper esdhc_set_dll_override(), and call it on the resume path > when the card kept power and is using a DDR timing mode. > > Fixes: 676a83855614 ("mmc: host: sdhci-esdhc-imx: refactor the system PM logic") > Reviewed-by: Frank Li > Signed-off-by: Luke Wang Reviewed-by: Haibo Chen Regards Haibo Chen > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 38 ++++++++++++++++++++++-------- > 1 file changed, 28 insertions(+), 10 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index 6526d65538de..a944351dbcdf 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -1349,6 +1349,23 @@ static int esdhc_change_pinstate(struct sdhci_host *host, > return pinctrl_select_state(imx_data->pinctrl, pinctrl); > } > > +static void esdhc_set_dll_override(struct sdhci_host *host) > +{ > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > + struct pltfm_imx_data *imx_data = sdhci_pltfm_priv(pltfm_host); > + struct esdhc_platform_data *boarddata = &imx_data->boarddata; > + u32 v; > + > + if (!boarddata->delay_line) > + return; > + > + v = boarddata->delay_line << ESDHC_DLL_OVERRIDE_VAL_SHIFT | > + (1 << ESDHC_DLL_OVERRIDE_EN_SHIFT); > + if (is_imx53_esdhc(imx_data)) > + v <<= 1; > + writel(v, host->ioaddr + ESDHC_DLL_CTRL); > +} > + > /* > * For HS400 eMMC, there is a data_strobe line. This signal is generated > * by the device and used for data output and CRC status response output > @@ -1425,15 +1442,7 @@ static void esdhc_set_uhs_signaling(struct sdhci_host *host, unsigned timing) > m |= ESDHC_MIX_CTRL_DDREN; > writel(m, host->ioaddr + ESDHC_MIX_CTRL); > imx_data->is_ddr = 1; > - if (boarddata->delay_line) { > - u32 v; > - v = boarddata->delay_line << > - ESDHC_DLL_OVERRIDE_VAL_SHIFT | > - (1 << ESDHC_DLL_OVERRIDE_EN_SHIFT); > - if (is_imx53_esdhc(imx_data)) > - v <<= 1; > - writel(v, host->ioaddr + ESDHC_DLL_CTRL); > - } > + esdhc_set_dll_override(host); > break; > case MMC_TIMING_MMC_HS400: > m |= ESDHC_MIX_CTRL_DDREN | ESDHC_MIX_CTRL_HS400_EN; > @@ -2123,9 +2132,18 @@ static int sdhci_esdhc_resume(struct device *dev) > * restore the saved tuning delay value for the device which keep > * power during system PM. > */ > - if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data)) > + if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data)) { > sdhc_esdhc_tuning_restore(host); > > + /* > + * Restore DLL override for DDR modes. hwinit unconditionally > + * clears ESDHC_DLL_CTRL, but the card is still in DDR mode. > + */ > + if (host->timing == MMC_TIMING_UHS_DDR50 || > + host->timing == MMC_TIMING_MMC_DDR52) > + esdhc_set_dll_override(host); > + } > + > pm_runtime_put_autosuspend(dev); > > return ret; > -- > 2.34.1 >