From: Shameer Kolothum <skolothumtho@nvidia.com>
To: <iommu@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <nicolinc@nvidia.com>, <jgg@ziepe.ca>, <joro@8bytes.org>,
<will@kernel.org>, <robin.murphy@arm.com>, <nathanc@nvidia.com>,
<mochs@nvidia.com>, <skolothumtho@nvidia.com>
Subject: [PATCH v3 0/2] iommu/arm-smmu-v3: Fix Tegra241 CMDQV CMD_SYNC use-after-free
Date: Mon, 29 Jun 2026 10:41:04 +0100 [thread overview]
Message-ID: <20260629094106.251694-1-skolothumtho@nvidia.com> (raw)
Hi,
Changes from v2:
https://lore.kernel.org/linux-iommu/20260611084205.686559-1-skolothumtho@nvidia.com/
-Addressed feedback and picked up R-by tags(Thanks!).
-Use explicit type casts in devm action callbacks(patch #1)
-Add Cc: stable to patch #1 as it is a pre requisite for patch #2.
Please take a look and let me know.
Thanks,
Shameer
From v2:
The arm-smmu-v3 probe teardown mixes devm and manual cleanup, so resources
unwind in the wrong order. The IOPF queue is freed before the event-queue
IRQ whose handler uses it. On Tegra241 this is worse: devres frees
smmu->cmdq.q.base before arm_smmu_impl_remove() runs, and the CMDQV
teardown then issues a CMD_SYNC on the freed queue, a use-after-free.
Patch 1 moves the remaining manual teardown (IOPF queue, vmid_map, device
disable) onto devm so the unwind order is correct. Patch 2 adds a
device_disable() impl op and uses it to quiesce the Tegra241 VINTFs
while the CMDQ is still up, fixing the UAF.
Shameer Kolothum (2):
iommu/arm-smmu-v3: Manage teardown with devm
iommu/tegra241-cmdqv: Fix CMD_SYNC use-after-free on teardown
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h | 1 +
drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 58 ++++++++++++++-----
.../iommu/arm/arm-smmu-v3/tegra241-cmdqv.c | 15 ++++-
3 files changed, 56 insertions(+), 18 deletions(-)
--
2.43.0
next reply other threads:[~2026-06-29 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 9:41 Shameer Kolothum [this message]
2026-06-29 9:41 ` [PATCH v3 1/2] iommu/arm-smmu-v3: Manage teardown with devm Shameer Kolothum
2026-06-29 9:41 ` [PATCH v3 2/2] iommu/tegra241-cmdqv: Fix CMD_SYNC use-after-free on teardown Shameer Kolothum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260629094106.251694-1-skolothumtho@nvidia.com \
--to=skolothumtho@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mochs@nvidia.com \
--cc=nathanc@nvidia.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox