From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 827D7C43458 for ; Thu, 2 Jul 2026 10:39:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=kMc7IH1jEIo7aTQO6+OKWeTUOGgdg0YUEMVyYCucVMQ=; b=TWIZrdE5E6qnG4DIMKHVTw6xdR 9bks9S9bvckUgne6e9ZF20c0vBJYGLa9vwPHjzIJPTCsC89PTs8LyfFCJKyQY3ji0y1/MqUzZJWJ7 CRXPowJG9iJ1ST7q0BRqiaKiK9d5czAzyS++zi2eXPRzIwtJKEoq/KH/80hot0hC9o5tk2ZjFZCGS caIT2BABTbY4UY6YxKnO0L2dlSioV48UADW4G2+Hul3nvUPsR2eM8OfxrSmoM3wydXPIxTsdYrTL9 tk9BGqcis5ld6640yzEDVQRHwjiGKfu8rIwDTPMgjFtwiVDvGTChVjMJCG+H6fSM08D1MDq8Mxae/ VYfrVSfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfEp3-00000004Bbo-1M7G; Thu, 02 Jul 2026 10:39:09 +0000 Received: from mail-wr1-x44a.google.com ([2a00:1450:4864:20::44a]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfEp1-00000004BaH-1LKu for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2026 10:39:08 +0000 Received: by mail-wr1-x44a.google.com with SMTP id ffacd0b85a97d-4744b72f90bso1164333f8f.0 for ; Thu, 02 Jul 2026 03:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1782988744; x=1783593544; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=kMc7IH1jEIo7aTQO6+OKWeTUOGgdg0YUEMVyYCucVMQ=; b=kvTFMCeE5u9xiSJDQLsyjrLGxldYKPqxNbkNs2/JCTMhMWilwf9XhZoPJ5g+rJhfWx 1v4Yte0vHjbRb75zsymvPbpDN8VUI0pN0D6MCJXjWgGsLNdIZSYOs/sfuamVKjKa42eE 6gkTYCZ4PWrb2ZBQf3F5q9ZXvHCM2EEoJDw8oK32/+HWq5jgBX4kPRBsAES1HvU952uQ B2OjqF4+h37PeKkDx8QcM8FX8n8LgqXt0vjGRvGNBswQxjZB9SAAMCIVDN3hVEo29ik/ 3iSSMukw22Udn+eVGYKCPdHD+boWmrf5IQrP0Hr4WNPrAI9R1L89PsDZ+S3b9xgXwuda pBbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782988744; x=1783593544; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kMc7IH1jEIo7aTQO6+OKWeTUOGgdg0YUEMVyYCucVMQ=; b=Ur0cDKJOHywuaYnYoQ5vx6+AaNceMSX8Fniu9I1wVmxF7+DvG0AGo94KPNrEqFIG22 7wLvWWRri7FE4mLaF+dg3+GKGUxmM3iFlV5B8sQCXxVf1i0oFEeC9TtToXn8/1UpKqQu fR45rKbzOoS/siXvKsBlGREN/D9USeTvZ2c005xGTJ8YLLAp7K7er4gv7QuR6zktRTzH CEhSOd+wQ0oEWUVAvCXu9KGe9mb3LJ2SZfTYDpHKTTRX8vQA7RqG2JwAKWOf21l4HrFO CNKnzfGbLXwj3p9pVHbOpe1bdA9Hb7ODQEQvy8VHSilTM7n30PJ661h0X8aPwdzoIE0x N9iQ== X-Forwarded-Encrypted: i=1; AFNElJ+NoX8h5+vTQZdF41Sp036g3VxuYcKAvsD+rDz+RHiQ298BZx1fxlMw9cQ+d6mkQpqSFJrPRPDfimAeI+yGyt/+@lists.infradead.org X-Gm-Message-State: AOJu0YzZAduiN6gXDmLoZNfiPoKnYR2R5FMzIfEwzyWAg0gRvjlMhbEq bCDg33sheY4EBy6xigzbZCcuSEQkNVSizTe7PJRWX/MChIMplM/CKKR1ZHk7RKRzQBFGVWLJ9OD mNl16SXnIgqcrzyS3mIonjA3KvV12pA== X-Received: from wmbf13.prod.google.com ([2002:a05:600c:594d:b0:493:b636:4ee9]) (user=sebastianene job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:5010:b0:493:c453:600f with SMTP id 5b1f17b1804b1-493c453616emr44043235e9.6.1782988744277; Thu, 02 Jul 2026 03:39:04 -0700 (PDT) Date: Thu, 2 Jul 2026 10:38:39 +0000 In-Reply-To: <20260702103848.1647249-1-sebastianene@google.com> Mime-Version: 1.0 References: <20260702103848.1647249-1-sebastianene@google.com> X-Mailer: git-send-email 2.55.0.rc0.799.gd6f94ed593-goog Message-ID: <20260702103848.1647249-3-sebastianene@google.com> Subject: [PATCH v9 2/6] firmware: arm_ffa: Fix Endpoint Memory Access Descriptor offset calculation From: Sebastian Ene To: catalin.marinas@arm.com, oupton@kernel.org, sudeep.holla@kernel.org, will@kernel.org Cc: jens.wiklander@linaro.org, joey.gouly@arm.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, android-kvm@google.com, maz@kernel.org, mrigendra.chaubey@gmail.com, op-tee@lists.trustedfirmware.org, perlarsen@google.com, sebastianene@google.com, seiden@linux.ibm.com, smostafa@google.com, sumit.garg@kernel.org, suzuki.poulose@arm.com, vdonnefort@google.com, yuzenghui@huawei.com Content-Type: text/plain; charset="UTF-8" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260702_033907_372896_1DD66D72 X-CRM114-Status: GOOD ( 13.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use the descriptor's `ep_mem_offset` to calculate the start of the endpoint memory access array and to comply with the FF-A spec instead of defaulting to `sizeof(struct ffa_mem_region)`. This requires moving `ffa_mem_region_additional_setup()` earlier in the setup flow. Also, add sanity checks to ensure the calculated descriptor offsets do not exceed `max_fragsize`. Fixes: 113580530ee7 ("firmware: arm_ffa: Update memory descriptor to support v1.1 format") Reviewed-by: Sudeep Holla Signed-off-by: Mostafa Saleh Signed-off-by: Sebastian Ene --- drivers/firmware/arm_ffa/driver.c | 20 +++++++++++++++----- include/linux/arm_ffa.h | 2 +- 2 files changed, 16 insertions(+), 6 deletions(-) diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c index 01301213896a..7c1b747797b4 100644 --- a/drivers/firmware/arm_ffa/driver.c +++ b/drivers/firmware/arm_ffa/driver.c @@ -713,19 +713,30 @@ ffa_setup_and_transmit(u32 func_id, void *buffer, u32 max_fragsize, struct ffa_composite_mem_region *composite; struct ffa_mem_region_addr_range *constituents; struct ffa_mem_region_attributes *ep_mem_access; - u32 idx, frag_len, length, buf_sz = 0, num_entries = sg_nents(args->sg); + u32 idx, frag_len, length, buf_sz = 0, num_entries = sg_nents(args->sg), ep_offset; + u32 emad_end, emad_size = ffa_emad_size_get(drv_info->version); mem_region->tag = args->tag; mem_region->flags = args->flags; mem_region->sender_id = drv_info->vm_id; mem_region->attributes = ffa_memory_attributes_get(func_id); + + ffa_mem_region_additional_setup(drv_info->version, mem_region); composite_offset = ffa_mem_desc_offset(buffer, args->nattrs, drv_info->version); + if (composite_offset + sizeof(*composite) > max_fragsize) + return -ENXIO; for (idx = 0; idx < args->nattrs; idx++) { - ep_mem_access = buffer + - ffa_mem_desc_offset(buffer, idx, drv_info->version); - memset(ep_mem_access, 0, ffa_emad_size_get(drv_info->version)); + ep_offset = ffa_mem_desc_offset(buffer, idx, drv_info->version); + if (check_add_overflow(ep_offset, emad_size, &emad_end)) + return -ENXIO; + + if (emad_end > max_fragsize) + return -ENXIO; + + ep_mem_access = buffer + ep_offset; + memset(ep_mem_access, 0, emad_size); ep_mem_access->receiver = args->attrs[idx].receiver; ep_mem_access->attrs = args->attrs[idx].attrs; ep_mem_access->composite_off = composite_offset; @@ -735,7 +746,6 @@ ffa_setup_and_transmit(u32 func_id, void *buffer, u32 max_fragsize, } mem_region->handle = 0; mem_region->ep_count = args->nattrs; - ffa_mem_region_additional_setup(drv_info->version, mem_region); composite = buffer + composite_offset; composite->total_pg_cnt = ffa_get_num_pages_sg(args->sg); diff --git a/include/linux/arm_ffa.h b/include/linux/arm_ffa.h index 17eca3dfc59e..033c630b271b 100644 --- a/include/linux/arm_ffa.h +++ b/include/linux/arm_ffa.h @@ -445,7 +445,7 @@ ffa_mem_desc_offset(struct ffa_mem_region *buf, int count, u32 ffa_version) if (!FFA_MEM_REGION_HAS_EP_MEM_OFFSET(ffa_version)) offset += offsetof(struct ffa_mem_region, ep_mem_offset); else - offset += sizeof(struct ffa_mem_region); + offset += buf->ep_mem_offset; return offset; } -- 2.55.0.rc0.799.gd6f94ed593-goog