From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDC8DC43458 for ; Thu, 2 Jul 2026 16:23:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TugoBhOzNqaocTsLwpZHSKviK7oWbP7FoSqjsiighKY=; b=z4Jqlt+AUjSGS8X3CevG14mhHP WWORNs0JwSKT0hiD0iMDzVvTLVxtzK5npQYslBUfHJ89goDjXMxNXFuAojkUH70adjJWHB3u1ngPt YzodSuTviVffdA/6q6KQDg2rUF/7JaaBxMQdFNUC5Ogs4skcfDkgNhnI8rU4noV0p5OoV3XW+nSLA 4/RkAqvXvz9i8aB0UmIh+bHQ1qMQkIkze/mL7JWW0Xc69gTEHuVgljG3RG3yLotvMspiONtmK20I8 5XRzAP/sFxPX2axldnB0t6GEsMkSWDRM/0ZSEl9NqoOCSCMlPX2EpxpAt7cwJOy4ZD1f9pT6MabOc BEYNSiig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfKBw-00000004zU1-1BaE; Thu, 02 Jul 2026 16:23:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wfKBt-00000004zSO-3LI8 for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2026 16:23:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F57235C7; Thu, 2 Jul 2026 09:23:00 -0700 (PDT) Received: from e142021.fritz.box (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A9EC03F673; Thu, 2 Jul 2026 09:23:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1783009384; bh=E3qBwhFsBsdUPol7MPlnsl1yxVk4BqYRKMOrLM+NQHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=afFbRGNEU2Z3Ns7rMmvQVXUcoBRCmgq5yxmvG7FMc/ZxWi7diLvhtyZSPnMc/4+oI v9LHaUAuGABHUNZB7fZPFw79Q4uuqJqRGZt18aCqw5BMc7svq+6nNeldBLs2rKQtGo knStHp8pFEPsMiOyYLfsTwYXAteyqiRjTryahzRU= From: Andre Przywara To: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Ben Horgan , Reinette Chatre , Fenghua Yu Cc: Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 06/15] arm_mpam: propagate MSC read errors for __ris_msmon_read() Date: Thu, 2 Jul 2026 18:22:20 +0200 Message-ID: <20260702162229.4008659-7-andre.przywara@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260702162229.4008659-1-andre.przywara@arm.com> References: <20260702162229.4008659-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260702_092305_924113_DDFF0567 X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Allow the function for RIS accesses to return an error, and propagate read errors from the lower level up. Signed-off-by: Andre Przywara --- drivers/resctrl/mpam_devices.c | 35 +++++++++++++++++++++++++++------- 1 file changed, 28 insertions(+), 7 deletions(-) diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c index b259fe20a614..d18c7be86aaa 100644 --- a/drivers/resctrl/mpam_devices.c +++ b/drivers/resctrl/mpam_devices.c @@ -1285,9 +1285,14 @@ static u64 mpam_msmon_overflow_val(enum mpam_device_features type, return overflow_val; } +/* + * This function might be called via smp_call_function_any(), so propagate + * errors inside the arg struct. + */ static void __ris_msmon_read(void *arg) { u64 now; + int ret; u32 now32; bool nrdy = false; bool config_mismatch; @@ -1326,7 +1331,9 @@ static void __ris_msmon_read(void *arg) * Read the existing configuration to avoid re-writing the same values. * This saves waiting for 'nrdy' on subsequent reads. */ - read_msmon_ctl_flt_vals(m, &cur_ctl, &cur_flt); + ret = read_msmon_ctl_flt_vals(m, &cur_ctl, &cur_flt); + if (ret) + goto out_unlock; if (mpam_feat_msmon_mbwu_31counter == m->type) overflow = cur_ctl & MSMON_CFG_x_CTL_OFLOW_STATUS; @@ -1351,7 +1358,9 @@ static void __ris_msmon_read(void *arg) switch (m->type) { case mpam_feat_msmon_csu: - mpam_read_monsel_reg(msc, CSU, &now32); + ret = mpam_read_monsel_reg(msc, CSU, &now32); + if (ret) + goto out_unlock; nrdy = now32 & MSMON___NRDY; now = FIELD_GET(MSMON___VALUE, now32); @@ -1371,7 +1380,9 @@ static void __ris_msmon_read(void *arg) else now = FIELD_GET(MSMON___L_VALUE, now); } else { - mpam_read_monsel_reg(msc, MBWU, &now32); + ret = mpam_read_monsel_reg(msc, MBWU, &now32); + if (ret) + goto out_unlock; nrdy = now32 & MSMON___NRDY; now = FIELD_GET(MSMON___VALUE, now32); } @@ -1402,10 +1413,15 @@ static void __ris_msmon_read(void *arg) if (nrdy) m->err = -EBUSY; - if (m->err) - return; + if (!m->err) + *m->val += now; + + return; - *m->val += now; +out_unlock: + mpam_mon_sel_unlock(msc); + + m->err = ret; } static int _msmon_read(struct mpam_component *comp, struct mon_read *arg) @@ -1729,6 +1745,7 @@ static int mpam_restore_mbwu_state(void *_ris) { int i; u64 val; + int ret = 0; struct mon_read mwbu_arg; struct mpam_msc_ris *ris = _ris; struct mpam_class *class = ris->vmsc->comp->class; @@ -1741,10 +1758,14 @@ static int mpam_restore_mbwu_state(void *_ris) mwbu_arg.val = &val; __ris_msmon_read(&mwbu_arg); + if (mwbu_arg.err) { + ret = mwbu_arg.err; + break; + } } } - return 0; + return ret; } /* Call with MSC cfg_lock held */ -- 2.43.0