From: Congkai Tan <congkai@amazon.com>
To: Oliver Upton <oupton@kernel.org>, <kvmarm@lists.linux.dev>,
<linux-arm-kernel@lists.infradead.org>
Cc: Congkai Tan <congkai@amazon.com>, Marc Zyngier <maz@kernel.org>,
"Joey Gouly" <joey.gouly@arm.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Zenghui Yu <yuzenghui@huawei.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
"Jonathan Corbet" <corbet@lwn.net>,
Haris Okanovic <harisokn@amazon.com>,
Geoff Blake <blakgeof@amazon.com>,
Stanislav Spassov <stanspas@amazon.de>, <kvm@vger.kernel.org>,
<linux-doc@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 0/3] KVM: arm64: Expose PMMIR_EL1.SLOTS to guests
Date: Thu, 2 Jul 2026 19:04:18 +0000 [thread overview]
Message-ID: <20260702190421.420992-1-congkai@amazon.com> (raw)
Today when the perf tool runs in a guest on cores with PMUv3p4, it fails
to parse the default metrics with "Failure to read '#slots'", since perf
can only read 0 from sysfs caps/slots, which is backed by PMMIR_EL1.SLOTS
that KVM traps as RAZ/WI.
Taking into account backward compatibility and heterogeneous systems, the
exposure of PMMIR_EL1.SLOTS is gated behind a new vCPU feature flag:
- Patch 1 adds the new flag KVM_ARM_VCPU_PMU_V3_STRICT. When set, KVM does
not create a default PMU during vCPU init, and the VMM must select one
explicitly via KVM_ARM_VCPU_PMU_V3_SET_PMU before the first KVM_RUN.
- Patch 2 exposes PMMIR_EL1.SLOTS of the selected PMU under the flag, and
adds userspace get/set for PMMIR_EL1 so that SLOTS can be reset to 0
for backward compatibility.
- Patch 3 stops masking STALL_SLOT* in PMCEID1 under the flag.
When the flag is not set, behaviors are unchanged.
v1: https://lore.kernel.org/r/20260601193954.2103455-1-congkai@amazon.com
v1 -> v2 changes:
- Gate the whole feature behind a new KVM_ARM_VCPU_PMU_V3_STRICT vCPU
feature flag, instead of unconditionally exposing PMMIR_EL1.SLOTS.
- When the flag is set, skip creating a default PMU during vCPU init.
- Split the PMCEID1 unmask into its own patch, also gated by the flag.
- Snapshot SLOTS into a new field pmmir_slots in kvm_arch during the
handling of KVM_ARM_VCPU_PMU_V3_SET_PMU when the flag is set;
access_pmmir()/get_pmmir() return it and set_pmmir() only accepts the
SLOTS field (rejecting other bits with -EINVAL).
- Add get_user and set_user for PMMIR_EL1 to support setting the SLOTS
back to 0, and add PMMIR_EL1 to the get-reg-list selftest.
Congkai Tan (3):
KVM: arm64: Add KVM_ARM_VCPU_PMU_V3_STRICT vCPU feature
KVM: arm64: Expose PMMIR_EL1.SLOTS under strict PMUv3 UAPI
KVM: arm64: Advertise STALL_SLOT* in PMCEID1 under strict PMUv3 UAPI
Documentation/virt/kvm/api.rst | 5 ++
arch/arm64/include/asm/kvm_host.h | 5 +-
arch/arm64/include/uapi/asm/kvm.h | 1 +
arch/arm64/kvm/arm.c | 18 +++++--
arch/arm64/kvm/pmu-emul.c | 50 ++++++++++++++-----
arch/arm64/kvm/sys_regs.c | 63 +++++++++++++++++++++++-
include/kvm/arm_pmu.h | 4 ++
tools/arch/arm64/include/uapi/asm/kvm.h | 1 +
tools/testing/selftests/kvm/arm64/get-reg-list.c | 1 +
9 files changed, 128 insertions(+), 20 deletions(-)
base-commit: 1702da76e017ae0fbe1a92b07bc332972c293e89
--
2.50.1
next reply other threads:[~2026-07-02 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 19:04 Congkai Tan [this message]
2026-07-02 19:04 ` [PATCH v2 1/3] KVM: arm64: Add KVM_ARM_VCPU_PMU_V3_STRICT vCPU feature Congkai Tan
2026-07-02 19:04 ` [PATCH v2 2/3] KVM: arm64: Expose PMMIR_EL1.SLOTS under strict PMUv3 UAPI Congkai Tan
2026-07-02 19:04 ` [PATCH v2 3/3] KVM: arm64: Advertise STALL_SLOT* in PMCEID1 " Congkai Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260702190421.420992-1-congkai@amazon.com \
--to=congkai@amazon.com \
--cc=blakgeof@amazon.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=harisokn@amazon.com \
--cc=joey.gouly@arm.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maz@kernel.org \
--cc=oupton@kernel.org \
--cc=pbonzini@redhat.com \
--cc=stanspas@amazon.de \
--cc=suzuki.poulose@arm.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox