Re: [PATCH v6 01/12] dt-bindings: soc: zte: Add zx297520v3 top clock and reset bindings

[Krzysztof Kozlowski <krzk@kernel.org>]

On Thu, Jul 02, 2026 at 11:27:56PM +0300, Stefan Dösinger wrote:
> +maintainers:
> +  - Stefan Dösinger <stefandoesinger@gmail.com>
> +
> +description: |
> +  The zx297520v3's top clock and reset controller generates clocks for core
> +  devices on the board like the main bus, USB and timers. In addition to clocks
> +  it has reset controls for peripherals, a global board reset, watchdog reset
> +  controls and a USB status register.
> +
> +  The controller has two clock inputs: a 26 MHz and a 32 KHz external
> +  oscillator. They need to be provided as input clocks. The controller provides
> +  clocks to the downstream Matrix clock controller.
> +
> +  All available clocks are defined as preprocessor macros in the
> +  'dt-bindings/clock/zte,zx297520v3-clk.h' header. The resets are defined in the
> +  'dt-bindings/reset/zte,zx297520v3-reset.h' header.

Use full paths (include/...), so these could be validated by tooling.


> +
> +properties:
> +  compatible:
> +    items:
> +      - const: zte,zx297520v3-topcrm
> +      - const: syscon
> +
> +  reg:
> +    maxItems: 1
> +
> +  clocks:
> +    items:
> +      - description: 26 MHz external oscillator
> +      - description: 32 KHz external oscillator
> +
> +  clock-names:
> +    items:
> +      - const: osc26m
> +      - const: osc32k
> +
> +  "#clock-cells":
> +    const: 1
> +
> +  "#reset-cells":
> +    const: 1
> +
> +  syscon-reboot:
> +    type: object
> +    $ref: /schemas/power/reset/syscon-reboot.yaml#

Missing: unevaluatedProperties: false

> +    description:
> +      Reboot method for the SoC.
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - clock-names
> +  - '#clock-cells'

Use consistent quotes, either ' or "

Best regards,
Krzysztof