From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1BDAC43602 for ; Tue, 7 Jul 2026 07:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ASP9SsAmeugXa+PWYoSj6Ew07J1BIBlMkdhlKL9m9IA=; b=SAz/Q2ElOt6PSwpHFW5YS78XQj nt8I4GeUrcjEBAOL8/r69xhL7XInCTzYf9iSLEWZ0KuRLN2056Bsxov/xtcSCWDcpPf/J2V3JJ4z4 RQPLEoHDkM9MDdT8WRhqyMQWdnjYYZ/WQzHqDFX+vRYWgNRMPIDOrRteR2q+/zVS9eDGAcbW5+Y+s pSe7bkkHc6EW/19z71VhR2X9v0CUOL34zPOjpvU3tX1vFaJ4RvdBnDcBSVVsT7H7ZbRPH37ue6j/R 0LTttXPsBUpmjeu4QNh8pm7GzPQ89v1PHZ/E8paHh9qCPPx+syz6yJRGc1d+7WqRWLOx00Eu4rGGL iROfgRZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh07Z-0000000EJFi-1FIF; Tue, 07 Jul 2026 07:21:33 +0000 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh07W-0000000EJFH-3CPT for linux-arm-kernel@lists.infradead.org; Tue, 07 Jul 2026 07:21:32 +0000 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6674Ifer2386574; Tue, 7 Jul 2026 07:21:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=ASP9SsAmeugXa+PWYoSj6Ew07J1BIB lMkdhlKL9m9IA=; b=EQ27WFS54mZ4vAz/szsbXHFYZ6HojI5h/0rRroU5Yogjca Sk5cynPhjtUGvXMaySNokxXGzUlbl2bl/6gKKzPq6867yORSb7FM/fBbWnG4gRsl vSb8g2a97ZO22Rp0Uzk9O/Fh/utfyXfWzKOy5LVUgQsGVhVJa6gRmKCMNIehNAJ5 YEcFHdYLLx3B70rS6SQjsBd4H1zackIYONFzDoQ2T0MYrfhnq41bTI8rkDjN94dw e2kCm+Qkp7nMInI3SauokSEYP6ywx+tO7hdOpWFazbPToDi5fn8wUmMpXCqcY6PF sOWpRg0jefvg6Dc6Ld0Jb0yi5hjd+Dilp8wGgCxw== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4f6sp3ns13-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jul 2026 07:21:18 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66774aGw010981; Tue, 7 Jul 2026 07:21:17 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4f7dgk1h32-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 07 Jul 2026 07:21:17 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 6677LAOQ14418406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jul 2026 07:21:10 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7F09620040; Tue, 7 Jul 2026 07:21:10 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2B1AC20043; Tue, 7 Jul 2026 07:21:10 +0000 (GMT) Received: from osiris (unknown [9.224.76.185]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 7 Jul 2026 07:21:10 +0000 (GMT) Date: Tue, 7 Jul 2026 09:20:57 +0200 From: Steffen Eiden To: Marc Zyngier Cc: kvm@vger.kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Alexander Gordeev , Andreas Grapentin , Arnd Bergmann , Catalin Marinas , Christian Borntraeger , Claudio Imbrenda , David Hildenbrand , Friedrich Welter , Gautam Gala , Hariharan Mari , Heiko Carstens , Hendrik Brueckner , Ilya Leoshkevich , Janosch Frank , Joey Gouly , Nico Boehr , Nina Schoetterl-Glausch , Oliver Upton , Paolo Bonzini , Suzuki K Poulose , Sven Schnelle , Ulrich Weigand , Vasily Gorbik , Will Deacon , Zenghui Yu Subject: Re: [PATCH v4 08/27] KVM: arm64: Prepare sharing arm64 code with s390 Message-ID: <20260707072057.583632-A-seiden@linux.ibm.com> References: <20260706085229.979525-1-seiden@linux.ibm.com> <20260706085229.979525-9-seiden@linux.ibm.com> <877bn77qpm.wl-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <877bn77qpm.wl-maz@kernel.org> X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=KsJ9H2WN c=1 sm=1 tr=0 ts=6a4ca8ee cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=LSyHmQqohv__iSPK5BIA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDA2OSBTYWx0ZWRfX3/lN6puSS6GP bKJgePq+klxWS7lo/wst4kxr8HGzyQflDKzbjYUZ12zjYTqA3o0Mg+DwVSldOv1W2mDT/iFC5YT LSsPQQpQubDplqIQVz84pdjl8aH135s= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDA2OSBTYWx0ZWRfX+z5lgv7MIVZa oJaN2ERCbmknfC9glSCCSIijIvtnLGtH2p9pyf6Hso8ONewXT6WkY3DKHr1zl3xm6RVb2m+Mkup eoIGXWuc/9KhKH/yFx9JozGG520Hm1PVjV9Cjv+cofr/Ma4jWTq1oQW2qkspWw5JFWUzv5mnoaL k7QER7/8OSLq8IxKcY5OELP6r7vGsJUE5Af2z4mBAJFnHaZi7F9o+y0saIiwWVcjtofyaCAIQQ6 1LbLP1ldl6Zy2X6CG8VIRx/4OerC3q294/yMjcjxSoPYJ2JtxzaPikcts80AiJJZzmBdIHIx9qG q2YnXZIi4d8StbFKm3dJTwJ9K/bov4Lhe1JlAXOuiqkPz7bZeVrwitTbwYDTP5B9qNLvtLHG1M4 sISZCNyakLZyoOUFLRNIdl9zvbyDi7hGOchRSWya+VanhO7js1kdnptiv9gH7Wje03TgCui/Bvc jdYkiXV6wZUpPC155Gw== X-Proofpoint-ORIG-GUID: sh00DnTO4XIi6KmCOBbENJUU54MwFv1X X-Proofpoint-GUID: sh00DnTO4XIi6KmCOBbENJUU54MwFv1X X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_01,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 adultscore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 priorityscore=1501 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070069 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260707_002131_177514_38255FEE X-CRM114-Status: GOOD ( 22.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 06, 2026 at 10:28:37PM +0100, Marc Zyngier wrote: > On Mon, 06 Jul 2026 09:52:08 +0100, > Steffen Eiden wrote: ... > > /* > > * Return > 0 to return to guest, < 0 on error, 0 (and set exit_reason) on > > * proper exit to userspace. > > diff --git a/arch/arm64/kvm/mmio.c b/arch/arm64/kvm/mmio.c > > index e2285ed8c91d..876d56dd5b64 100644 > > --- a/arch/arm64/kvm/mmio.c > > +++ b/arch/arm64/kvm/mmio.c > > @@ -10,6 +10,7 @@ > > > > #include "trace.h" > > > > +#ifdef ARM64_S390_COMMON > > void kvm_mmio_write_buf(void *buf, unsigned int len, unsigned long data) > > { > > void *datap = NULL; > > @@ -135,8 +136,11 @@ int kvm_handle_mmio_return(struct kvm_vcpu *vcpu) > > if (!kvm_vcpu_dabt_issf(vcpu)) > > data = data & 0xffffffff; > > > > +#endif /* ARM64_S390_COMMON */ > > trace_kvm_mmio(KVM_TRACE_MMIO_READ, len, run->mmio.phys_addr, > > &data); > > + //TODO tracing > > +#ifdef ARM64_S390_COMMON > > Irk. The deal is that you lift full functions, not cherry-pick which > lines you want. Just define empty stubs for the trace nonsense, and be > done with it. But not this, please! > Sorry, this dirty hack is a leftover I forgot to clean up prior to sending. Hence the TODO. I definitely second you full functions or not at all should be the approach. Everything else is not maintainable. I will add the tracing stuff for the next round. Steffen