From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 50395C43458 for ; Thu, 9 Jul 2026 08:19:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=cTOPP+o88VWkb8bpp8Y96c4/97TqS6hM51V5JviFgiY=; b=4ncQyPFvqcDVlM7HCGZoEPSjAj K/DdO3klHnpbQ8I+XCAFlkk2EpKPKadu/bU6eOtWEYdT+nM7hntJ5FZD0P/LP7xoAbXQniTVXNcc1 OGVT8wFbsJPaiBaNsHfRtucczeurHL7e5GRIla4bX6sdXdj2H5KeI6e1UPo+hxefQ0bMDjUoFDHq0 8Zjp36oW1A9p02kT6lM9c5khKHAya1UYN2nLFlUe1L0RWI8lgAfXfuolNvRZDR5lonoM+jVGAGp5r B4MvHWgBj0DMr8eZZR66smpdJ/kIgPjJWDvbqqNoiZp9vgwiwuCJ5tsAq6uQci4bthNi1dm83X/gA ZRnO+Obg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whjyt-00000001Oup-47qz; Thu, 09 Jul 2026 08:19:39 +0000 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whjyq-00000001Otb-0sK7 for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2026 08:19:38 +0000 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-8486672f03cso25792b3a.0 for ; Thu, 09 Jul 2026 01:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1783585175; x=1784189975; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=cTOPP+o88VWkb8bpp8Y96c4/97TqS6hM51V5JviFgiY=; b=YJ43AJG7sziSGRQEXnU8n0FapmVKdSEwq6vKU63BwjZlDFmBRV6bDE8LOY0uOPQy2V FgAgwWmQKRX5QvlgTtQxd/xFBnZUiLlp3/osrQJWV591BhdKgFLyj713vTmdFUrzepJp rhjNx3URZM1hp/CLNzKDY6A0j4Jy5E3cs6h8M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783585175; x=1784189975; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=cTOPP+o88VWkb8bpp8Y96c4/97TqS6hM51V5JviFgiY=; b=VEKuWiBkA1CqXpWnRXzhsigYRn7bmigmbXqLmxxTPt8KqnSdLkBvTb9k51hbT201tE h3UXer5sc3InNNva2csXMtYnWZzvgtkyLaa/rYQqe0csuUQ3MdzOT4tVXw+DsQIxjrfd dQbkykY3tgo3F8tOyK3ks80Rsg6+xyfkSTDAsu6DbPjGdVDiwUdcM8d7ENX6QgtHM69N HR2EeUh1anjoKZKGGLdxDY4TWNz8yV7talDXdOchslwf24BcraNLw8BV1tvOF4MF819b OrACDK5KKmUlfACLPN1LEsXsFgBTH3U/xU2dpclMY4DWnuUyCOd0fh8cnABrwU7uV7TK adxw== X-Forwarded-Encrypted: i=1; AHgh+RrcOjzCGtmPN6TKrB6ERvsoFJjePweEvh14kM+w0kZwG2YLaQ7i6Bmse5ZYPmV2rxSMRbpdlaY7KLfmyZfOoSKN@lists.infradead.org X-Gm-Message-State: AOJu0YwSyQn8/xeBok6p9iyLQmHC8iF00Ug6iJW/kQJBLx3vSojBCnUD 5WfYlFVdzwLYr8Xz3RRC3FPMjeY3ffamz4sb4p+do4vjqKSbaO4TumAHrIyNpZo/rg== X-Gm-Gg: AfdE7cn0J6OPHQnFEzcd1BPpKj0mopxaLYjGegAp9XItm89lRGcZWTV7owHvsa4q174 OC3Dy1wd7mMMM1Wyh9GSP60LQIblxIKb51CWSg+5WN9fZE3Acmi6/SzQ6BPKhq6ZzaqAWq8f2OO FOfohMkpia6sCxNleeWzstH6kK1nz5Mbx8iPzADWy5YiVmoTEIlqf0mpF6nfsRWd11cZ3jyLrmt MFzhJK8MUKTL9vhyRyGqQaJum0UCFpR5ltB84g6HIXZ1X58QzrbrboocEApYpsTrU2qFzxr0hq9 d92JWjdenHWihfYJPLownoQPCEjdvrrlrIC5v8hAD6VLhsEbgWWi9GBVaqZTfAwmu8ExpghQlN+ KL3pQmYEEb+K8A7tFacFhJsEpXYsPaRFkelCls89u1OKPZ39Yo3TR2SjxW51SuaYeqftjq+TYwu 87uixouhsfWDdy+X5qfQ4KmhtBG3dhPtFzweWCIhBWiBKxuuZJxdwvSKcoSmiCf7cM8Rvfeg== X-Received: by 2002:a05:6a00:2450:b0:848:2b8f:c9d7 with SMTP id d2e1a72fcca58-84843027f6emr5831170b3a.18.1783585175251; Thu, 09 Jul 2026 01:19:35 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:bd09:6ddb:180a:69c5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-847f6dbdc8dsm8211863b3a.55.2026.07.09.01.19.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 01:19:34 -0700 (PDT) From: Chen-Yu Tsai To: Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] arm64: dts: mediatek: mt8188-geralt: Add MT6319 PMIC Date: Thu, 9 Jul 2026 16:19:27 +0800 Message-ID: <20260709081928.612294-1-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_011936_281343_0679C87C X-CRM114-Status: GOOD ( 16.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The Geralt design uses a MT6319 PMIC to power the big cores and LPDDR4X DRAM. Add a device node for it and hook up all the supplies. However do not add cpu-supply properties for the big cores. Adding them without the firmware fix mentioned below will likely cause CPU DVFS to stop working. This change requires a firmware fix for the SPMI bus to read back correctly. The required firmware version is 15842.175.0. This is included in ChromeOS releases R150-16700.22.0 (available in Beta channel as of writing or stable channel in mid-July) or R151-16721.0.0 and later. Signed-off-by: Chen-Yu Tsai --- Changes since v1: - Dropped cpu-supply on CPU6 and CPU7 - Added comment about broken firmware and upgrade versions --- .../boot/dts/mediatek/mt8188-geralt.dtsi | 74 +++++++++++++++++++ 1 file changed, 74 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi index f382f90c48f5..dee946309121 100644 --- a/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8188-geralt.dtsi @@ -4,6 +4,8 @@ */ /dts-v1/; #include +#include + #include "mt8188.dtsi" #include "mt6359.dtsi" @@ -1156,6 +1158,14 @@ pins-bus { }; }; + spmi_pins: spmi-pins { + pins-bus { + pinmux = , + ; + bias-disable; + }; + }; + uart0_pins: uart0-pins { pins-bus { pinmux = , @@ -1267,6 +1277,70 @@ &spi2 { status = "okay"; }; +&spmi { + pinctrl-names = "default"; + pinctrl-0 = <&spmi_pins>; + #address-cells = <2>; + #size-cells = <0>; + status = "okay"; + + pmic@6 { + compatible = "mediatek,mt6319-regulator", "mediatek,mt6315-regulator"; + reg = <0x6 SPMI_USID>; + pvdd1-supply = <&pp4200_s5>; + pvdd2-supply = <&pp4200_s5>; + pvdd3-supply = <&pp4200_s5>; + pvdd4-supply = <&pp4200_s5>; + + regulators { + /* + * vbuck1 is the cpu-supply for CPU6 and CPU7. + * + * However, this device originally shipped with a broken + * firmware that causes register reads over SPMI fail. + * This is fixed in firmware version 15842.175.0, which + * is included in ChromeOS releases R150-16700.22.0 or + * R151-16721.0.0 and later. + * + * Assigning the cpu-supply properties for CPU6 and CPU7 + * without the fix will likely cause CPU DVFS to stop + * working. Hence the assignment is left out to avoid a + * regression of the function. If the user is confident + * that their system has the fix, they can added the + * property themselves. + */ + mt6319_buck1: vbuck1 { + regulator-name = "ppvar_dvdd_proc_bc"; + regulator-min-microvolt = <520000>; + regulator-max-microvolt = <1155000>; + regulator-enable-ramp-delay = <256>; + regulator-allowed-modes = <0 1 2>; + regulator-always-on; + }; + + /* vbuck2 is ganged with vbuck1 */ + + mt6319_buck3: vbuck3 { + regulator-name = "pp1125_emi_vdd2"; + regulator-min-microvolt = <1060000>; + regulator-max-microvolt = <1170000>; + regulator-enable-ramp-delay = <256>; + regulator-allowed-modes = <0 1 2>; + regulator-always-on; + }; + + mt6319_buck4: vbuck4 { + regulator-name = "pp0600_emi_vddq"; + regulator-min-microvolt = <570000>; + regulator-max-microvolt = <650000>; + regulator-enable-ramp-delay = <256>; + regulator-allowed-modes = <0 1 2>; + regulator-always-on; + }; + }; + }; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_pins>; -- 2.55.0.795.g602f6c329a-goog