From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED516C43458 for ; Thu, 9 Jul 2026 09:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3NOayELjm3/+NeKg/MUGc6Z0GBz34hjktNSI4aLdsWw=; b=noGeDRy/LuNCeB4x3Ou8rNrp0e 8nnnbrV6scCh5BL5fvNeEObxqYz8bL66d+s5T/6s8sZuuIAD/1DGlaDSIJBbLIlTJRxLiZeSL22Zq iNsE4Ri24nNY206BI8NHPvVGqzbn8fyDJbA65N/nRe2VmZX+9wzhupLNxNcrdg5nXwLd1VpxQx1gw hHlFpdFgOGL7qGjpGJG3QLh+hpFi3AF6MQHmso5454sCT/9D1A3/CJWDslL2bVPEvgIZh4poMknbt QB1vjN+KmIrcrJIvaMXjTP1/NBiu+dm/KoJD/Yc+4gIz1DxY2iQBI2+jLLgBoVjT76v8Ul+9nB/qy FA/ErGGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whlWR-00000001pVj-1Oqu; Thu, 09 Jul 2026 09:58:23 +0000 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whlWN-00000001pPx-1M7f for linux-arm-kernel@lists.infradead.org; Thu, 09 Jul 2026 09:58:21 +0000 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-2cacd69a9c0so20496685ad.1 for ; Thu, 09 Jul 2026 02:58:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1783591099; x=1784195899; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3NOayELjm3/+NeKg/MUGc6Z0GBz34hjktNSI4aLdsWw=; b=Ztdts66laL/X9JLSFiSdra5USuwid7TkcB4WMH4brXZk/yr/MgpAQ8lzhKn9TPvR/E XAPIMXaR0BfnoZZ+fELB09QMwQ/MPx8ySBdk1EBv9aOtnk5gIJZ/MkZsqWz+zHJlkcBk 95yhLQ8x7OZnGI8GYZMGIypA3IUU6wuCf3yUA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783591099; x=1784195899; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=3NOayELjm3/+NeKg/MUGc6Z0GBz34hjktNSI4aLdsWw=; b=l9t1wgn4fem1J1Ns6PiYYAuBT64uuBD0WAp6NImGVonjvJcwZ100CCSYVPGeGvSNhs 5+tq3NKTEYzDOqKkhNLJBQ2exyaj/9rX2wU0E9QGuLLPnpi3KcNf7zVxUtmijTRWtOVK JQ1CfeVpWS8Vjn742/eDYFTqDNX4eVLY0f+Y+wreCtem9G4acd9qx86lQE79oB6WjAVn RwR8TDuOeZ3mRHdmZAfhZ8vMVCSyCHe8BXD+MoKCAKe9h5U4IbrbC3kF9n6z6ZRRQ+mM 0ISpuMJYShEoZhbpGwjdQjQYpFrJSshmNn6+wH4wgKbTd3xzk+jg/GJS5jV8x25Y4fS6 nSBg== X-Forwarded-Encrypted: i=1; AHgh+RqtmLj0rZX5wB1tv6RZIGpScISLUHUZxOIjQuY+Qyx6o5JMIkdZX+0VzxQUyIUIMt9QZcMNQPozf8kUlb8YfR7Y@lists.infradead.org X-Gm-Message-State: AOJu0YzQGiS2AV+1gSbKzYiG4QMzHbKYnyPUuB3qjSKcTQbVylf++4Ic BMKOqVgbOdL8TDPFKHu+QC/hteZt3rTeJJn+V35TmbKWR/1Z0j+qZSF9VAbHtLqUjQ== X-Gm-Gg: AfdE7cmQVbzfw3Sdx7fElQTa8pthS9Jj6BDTSXOXUTmFMHaXUfCVTdA5ONd0OZWHd5i vhyBcewF3tSDn+FTUs4e/IBKWyzAXl1CGzTrcA4KSg2ocy4uwMRPkOnxsHl8sXXKfEkH6z+KNg5 1/oYJP3fYiB9PpMS5nVVy8rLKiwQ/K7EHR1I4ySv43rMcezIYczETqL+DVwoqSx+R/CB9xFdPE7 Qz6jGZhEB4RnEFCg998sdtbDlwHXwSUqdyw6rcDSxPD4uZvR2aF09vUezziHI8cRdq4QAoH0iJd 9aRCNsrVxKaLGVhRwc+tgcJ/DP0Jy1UJd0xdJP1OW0PiC89jaFgbofoeMbMQdiP5kkvitAb6184 HczwztRVNlhs0EPNji8iVtuJTmMubhNqEz/2TLcU3TnaTfPsInPsxFYdNND96N7872HXpzEb3nO X32KgVYcz5twnkkSZ/1om1WCMT2JWO0ahR4HBrbwWjW1K+K8qsuAAemd/Y9TUNuAbV0bkKMHd+C Lrh3mO5 X-Received: by 2002:a17:903:1247:b0:2ca:eea:eb5c with SMTP id d9443c01a7336-2ccea373170mr66966485ad.18.1783591098706; Thu, 09 Jul 2026 02:58:18 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:bd09:6ddb:180a:69c5]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ccc9d5bd2fsm41082155ad.78.2026.07.09.02.58.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 02:58:18 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v4 08/14] usb: hub: Use usb_hub_set_port_power() to control port power everywhere Date: Thu, 9 Jul 2026 17:57:13 +0800 Message-ID: <20260709095726.704448-9-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.795.g602f6c329a-goog In-Reply-To: <20260709095726.704448-1-wenst@chromium.org> References: <20260709095726.704448-1-wenst@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_025819_355725_72EAC988 X-CRM114-Status: GOOD ( 13.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org There are still some instances in the USB hub driver where port power is directly controlled by toggling the USB_PORT_FEAT_POWER feature flag. Switch these instances over to usb_hub_set_port_power() so that only one unified function to do this exists. This makes adding external power control with the power sequencing API easier and consistently applied. Reviewed-by: Bartosz Golaszewski Signed-off-by: Chen-Yu Tsai --- Changes since v2: - New patch --- drivers/usb/core/hub.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index c7fa73673582..369280a217cc 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -975,11 +975,8 @@ static void hub_power_on(struct usb_hub *hub, bool do_delay) dev_dbg(hub->intfdev, "trying to enable port power on " "non-switchable hub\n"); for (port1 = 1; port1 <= hub->hdev->maxchild; port1++) - if (test_bit(port1, hub->power_bits)) - set_port_feature(hub->hdev, port1, USB_PORT_FEAT_POWER); - else - usb_clear_port_feature(hub->hdev, port1, - USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hub->hdev, hub, port1, + test_bit(port1, hub->power_bits)); if (do_delay) msleep(hub_power_on_good_delay(hub)); } @@ -5436,7 +5433,7 @@ static void hub_port_connect(struct usb_hub *hub, int port1, u16 portstatus, if (hub_is_port_power_switchable(hub) && !usb_port_is_power_on(port_dev, portstatus) && !port_dev->port_owner) - set_port_feature(hdev, port1, USB_PORT_FEAT_POWER); + usb_hub_set_port_power(hdev, hub, port1, true); if (portstatus & USB_PORT_STAT_ENABLE) goto done; -- 2.55.0.795.g602f6c329a-goog