From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D944C43458 for ; Fri, 10 Jul 2026 05:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=glNXCWo3feUPJNoiqEbeBkuoiMlb+JtOjIAbpp+cCDQ=; b=Tydd2KbTlAXwiirOlwnkPMFK2H yR82IKglA2UnksP2k+R9lG6EKdgTuJb0v9qsja4QLaaz1pa31pbfa06ap7wqbRFrN2/pjqXlg9uNL iucBcqTvSEj1MAwlmhrt0AnJaiRiBaKW4keUEzv3+Nm2J8reFCgEyGjlsR6diGX8T1+fUMF4xHH23 ztuNatgVUCjijhMb37eukdP8gkCd+XN3w8rKqmDtDHJE3oxN671Lrq9vt4Q5NMO2rKEGvCCd9YzQI 7iPBmQ3hNLkFGZj3dW8PGyln8In+WLarxBWuwSF69ff/l/yCrrWncSBdca0JIjL/o+bSvjN5sHSX5 Y9kqVOkA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wi3Ql-000000047qr-2K6d; Fri, 10 Jul 2026 05:05:43 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wi3Qi-000000047pW-14xC for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2026 05:05:42 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-84862b0d5aeso466436b3a.2 for ; Thu, 09 Jul 2026 22:05:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783659939; x=1784264739; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=glNXCWo3feUPJNoiqEbeBkuoiMlb+JtOjIAbpp+cCDQ=; b=kQEM42ipcLjELKH5QoMpZi53EXYRVzSaJoW63ubMUo1RAuSHGsrdTlgp1IlTTwpyj5 TdDCVtwveKj3ScG9on4TM6FdBCe8mhklNymNgCfHAQ4yvt/aXmcRzYrN0njiiZGXQATa e+qo7e9ppsBrZ4K+GQPpcky0r5oVcS8VvOLG/fCM1S7LWsymJR/MinULbfDx2OOsI8Sv aODzcjXCuCRbh4A20QOOSwnpWoN+sSZ5R5o41rePptNiDwVtuGL2teCwzivpyu6hxExK nRRImXPrCURdilv0YDaHAFocBN2bw3RMDLn28ZwBk/lOqsb2hhP1mSVdOY+lyUkZvJKO Kw0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783659939; x=1784264739; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=glNXCWo3feUPJNoiqEbeBkuoiMlb+JtOjIAbpp+cCDQ=; b=AosMVIbnhGKb4z1U3tSvap+VDlwOQfWvWKC+Pcg/NSSSgtLHjq8I0MrU+gEVGQmNzG yhAOoIm7GOxaie0LzElEMp2w1Mlv3DIYV/nrKI/wmQNpRoWtxddfwJH4v5tZsUPy5H14 jtRzvVtil2cKt62kVhT8j3vGCe0xaGQn3Q13AfhyLHL6CdLYunoXOirpHrbrwpLatTx5 rUk9FNoMIBSzBfZ7Dj2QjDANom63l/hFhzO6QOkF5PJWOnWuzsH/Az/FuMjPCBWNVYpJ Bxyv1tKcGgC9spPQrYsyI6ac7tCxst6lO0DeUk5hPbSCV7SNBkubQygIJx6taL0l4cdk MEXg== X-Forwarded-Encrypted: i=1; AHgh+Rq940GSSVzZ2MRBPe9/ty5KH8UahRtwvHTVue2GG3dPSPBvr8rbpguWsIC8y59tie3FTrrI0XtcRZoQdL3Ae7oO@lists.infradead.org X-Gm-Message-State: AOJu0YxY5tpylyvh6LAHnlD+VDPv8WWpmWLewvGhJ+PoBwP9OMA0y3lF LQygWVX9kGxRTKUsS+FtHX9UzBZ2GiZxVqwBMpBY+2jtEoFU80PqzfpF X-Gm-Gg: AfdE7cky/gvQQNiaaFLOTSwYS8W52uwQC9UZ4YtV6Q+3EcKSLYqQbrGbbCbI7AfBR/6 AlwLiP8+kBApSUe4+sneFQmE9+nESRMbfcbSAn9apJFauaLRba7om/E/2yf5HJrpUCIe3VbEmh2 bk136hZLzLe69FsV15fXIiG1vKp/GOrAgF5f0XlCT5RDmfKFxTuSEihEzpUPif4ri6Ri36h8bcw TK/Pw7bZKeuPTp8CtlTMe1wTgtGDQuXwT0HYz5YNX+wLGSovOlbsUrcHSFJFYEKp4sAt+D1iJMR 9Z+sWs5KOnELy2FNoyVpYnNnIdOjl0sXEJuOPMemM9nBjXUfuK145gDAyEV1s3R+65YO5x+CElO tV+HOR2C79LkEDxXtj1gWPHlL3yJEoxU2N3/YvWXXConT3PsaaAoWtzol4H7k4YZ7iMnBGC98wg f8aq685j7njrv0EkRi9lEGoT6LHdyYCTwGhNeIRRPIC6rDwovXTEVbNLIjLA== X-Received: by 2002:a05:6a00:2d9d:b0:848:67ca:bfd with SMTP id d2e1a72fcca58-84867ca1b16mr4077056b3a.16.1783659939223; Thu, 09 Jul 2026 22:05:39 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84847275fa0sm3400499b3a.22.2026.07.09.22.05.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 22:05:38 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Takashi Iwai , Nick Li , Herve Codina Cc: Support Opensource , Liam Girdwood , Jaroslav Kysela , Srinivas Kandagatla , Charles Keepax , Richard Fitzgerald , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Oder Chiou , Linus Walleij , Kuninori Morimoto , u.kleine-koenig@baylibre.com, Zhang Yi , Marco Crivellari , Kees Cook , HyeongJun An , Arnd Bergmann , Qianfeng Rong , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH v3 04/27] ASoC: codecs: es8326: Use guard() for mutex locks Date: Fri, 10 Jul 2026 12:04:48 +0700 Message-ID: <20260710050511.14439-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710050511.14439-1-phucduc.bui@gmail.com> References: <20260709045902.498848-1-phucduc.bui@gmail.com> <20260710050511.14439-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_220540_297376_DB94252D X-CRM114-Status: GOOD ( 14.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/es8326.c | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/sound/soc/codecs/es8326.c b/sound/soc/codecs/es8326.c index a79b2da35099..c5460589a88b 100644 --- a/sound/soc/codecs/es8326.c +++ b/sound/soc/codecs/es8326.c @@ -6,6 +6,7 @@ // Authors: David Yang // +#include #include #include #include @@ -790,7 +791,7 @@ static void es8326_jack_button_handler(struct work_struct *work) if (!(es8326->jack->status & SND_JACK_HEADSET)) /* Jack unplugged */ return; - mutex_lock(&es8326->lock); + guard(mutex)(&es8326->lock); iface = snd_soc_component_read(comp, ES8326_HPDET_STA); switch (iface) { case 0x93: @@ -845,7 +846,6 @@ static void es8326_jack_button_handler(struct work_struct *work) } es8326_disable_micbias(es8326->component); } - mutex_unlock(&es8326->lock); } static void es8326_jack_detect_handler(struct work_struct *work) @@ -855,7 +855,7 @@ static void es8326_jack_detect_handler(struct work_struct *work) struct snd_soc_component *comp = es8326->component; unsigned int iface; - mutex_lock(&es8326->lock); + guard(mutex)(&es8326->lock); iface = snd_soc_component_read(comp, ES8326_HPDET_STA); dev_dbg(comp->dev, "gpio flag %#04x", iface); @@ -873,7 +873,7 @@ static void es8326_jack_detect_handler(struct work_struct *work) regmap_update_bits(es8326->regmap, ES8326_HPDET_TYPE, ES8326_HP_DET_JACK_POL, (es8326->jd_inverted ? ~es8326->jack_pol : es8326->jack_pol)); - goto exit; + return; } if ((iface & ES8326_HPINSERT_FLAG) == 0) { @@ -930,7 +930,7 @@ static void es8326_jack_detect_handler(struct work_struct *work) queue_delayed_work(system_dfl_wq, &es8326->jack_detect_work, msecs_to_jiffies(400)); es8326->hp = 1; - goto exit; + return; } if (es8326->jack->status & SND_JACK_HEADSET) { /* detect button */ @@ -939,7 +939,7 @@ static void es8326_jack_detect_handler(struct work_struct *work) (ES8326_INT_SRC_PIN9 | ES8326_INT_SRC_BUTTON)); es8326_enable_micbias(es8326->component); queue_delayed_work(system_dfl_wq, &es8326->button_press_work, 10); - goto exit; + return; } if ((iface & ES8326_HPBUTTON_FLAG) == 0x01) { dev_dbg(comp->dev, "Headphone detected\n"); @@ -958,8 +958,6 @@ static void es8326_jack_detect_handler(struct work_struct *work) usleep_range(10000, 15000); } } -exit: - mutex_unlock(&es8326->lock); } static irqreturn_t es8326_irq(int irq, void *dev_id) @@ -1200,13 +1198,12 @@ static void es8326_enable_jack_detect(struct snd_soc_component *component, { struct es8326_priv *es8326 = snd_soc_component_get_drvdata(component); - mutex_lock(&es8326->lock); - if (es8326->jd_inverted) - snd_soc_component_update_bits(component, ES8326_HPDET_TYPE, - ES8326_HP_DET_JACK_POL, ~es8326->jack_pol); - es8326->jack = jack; - - mutex_unlock(&es8326->lock); + scoped_guard(mutex, &es8326->lock) { + if (es8326->jd_inverted) + snd_soc_component_update_bits(component, ES8326_HPDET_TYPE, + ES8326_HP_DET_JACK_POL, ~es8326->jack_pol); + es8326->jack = jack; + } es8326_irq(es8326->irq, es8326); } @@ -1219,13 +1216,12 @@ static void es8326_disable_jack_detect(struct snd_soc_component *component) return; /* Already disabled (or never enabled) */ cancel_delayed_work_sync(&es8326->jack_detect_work); - mutex_lock(&es8326->lock); + guard(mutex)(&es8326->lock); if (es8326->jack->status & SND_JACK_MICROPHONE) { es8326_disable_micbias(component); snd_soc_jack_report(es8326->jack, 0, SND_JACK_HEADSET); } es8326->jack = NULL; - mutex_unlock(&es8326->lock); } static int es8326_set_jack(struct snd_soc_component *component, -- 2.43.0