From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BE06C43458 for ; Fri, 10 Jul 2026 05:05:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NfvB0lMuldB+u0jwzr6lQv/Vg3HM48QxhaQsc6Uk5yE=; b=UPn6EfjpuagGdP8EjzXv/2VrWu pz2KgpR3Nj5DedQDdIbCfU+7r2rV2ZWMfPsaWvCI6ryEwG17e48pMA/sKTS5TyKLdi1L3Al57nSF0 xwXbjTueiroskCra8CtzL0boT+s23sITjCLL338kO4teFOP+vgx27C+zQDna/uFsKLm4yg97N4f12 eaQeUHE83RWj7FprqK2Vsg6e5EfqabloZQqN7WUshykTlZiOPgR7rTPxMEZw7EBFKlT/gp+tEb23o bYh+55MKmBjURDHPMcr3pocoy3t0sPTmxvfhzNmKtQ8uNAhjOuB09QeIMiyzwvMrixqRwzJdnUnKx a9bSr6ng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wi3Qt-000000047vA-3Sek; Fri, 10 Jul 2026 05:05:51 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wi3Qq-000000047tB-2d0a for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2026 05:05:50 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-8487b7b3fc8so90582b3a.3 for ; Thu, 09 Jul 2026 22:05:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783659948; x=1784264748; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=NfvB0lMuldB+u0jwzr6lQv/Vg3HM48QxhaQsc6Uk5yE=; b=OO/o7F8s3+7daioE77MFV+yUhN0bqaCW8xhODHXWvQWKAPiYYOwTswh1G31tVK3P3Y 1Dw8vKCnbDqah79FQqDmK2wyjcMFYu7YYBS3ArE15azEOo6dItPRb1tCTJ6EzANXB1cH jYJPBuaZDwNrUVDQMtV4rsFillt7Ff4DTLkJybd1arFtl13iY9347hBhvsUbz/irAQsX 4lChyshheG+63iv+o+yEh5uC5zn62GErL26mD+JHMDBT5zTgWovqWKp3a6t53u5zoyCt l/jEX05kfahYDy6a00mtIpubs28PJs77vUpaztOaptlexQhhOH3xK9tKEXzVLnf0/2ZK gezw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783659948; x=1784264748; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=NfvB0lMuldB+u0jwzr6lQv/Vg3HM48QxhaQsc6Uk5yE=; b=GF82suIqlpA8NMOUlED4/EOBA671EW9vR4spMzHbDe5ttjNdQ7IMBenqkLcpNaNz/M vJ+SAypcWXBUfs1g6f+ggclSOOSqJtWpsntuHl6ZO51ayXub5KYT+qkSInRLIQzVuzuE SDP1SctkJkRXvrU/MgA+b/sb8gZl7Op5iNQ9S4JIkv8IIwvBX+XY5FBcnnS7+chFqPVE QZ2AjP8rHQyPL7mfIat6nmhHiZozQGZLsejeVG2LDDDx7ftM7GH378BaULEsCTcjU7sd kQuluOKsF7ZraYuLdko4/GHTh8eUr+YrCL9aDe/203XyIPweKN1yq7D8l+j0eMmi99Xc Cn7Q== X-Forwarded-Encrypted: i=1; AHgh+RoHUd9pBGZDi7hm8tdbQJPu9TTzR1R1i5hPBa+gs2tUBrzK4lEtACjby/X/CUd/W3Q4sD8t62gaFMGY3JOyX0TY@lists.infradead.org X-Gm-Message-State: AOJu0YxiLzlXng5UHdQDj9M/rVLpAwS8seUE+ZzQSzaiF4+Fc8VBsKb7 ZWZf1seQstbd5Uf8Qk7wkzsHhQWntjP8SOiHChQWUel4SCsPITpgHVAz X-Gm-Gg: AfdE7cmYSDd49FYNIks90EmQ/SpDolIy5Dtd890bpURRoCcDZFpO6CwpDELSszi2Uj3 NFMYka6zu5/QCXDa4EhQmUhVtcmPVbU5A1Y0qW+Yd0YylN2cdGdN2r9KcJJ0WXzvieuUmeDKY5J Y2DKElqw2Y1i8MqZO2EtA2brK50NnpxFgeQaiq9DTqPc606eXR+9tGE5gqYBwJeOHIRPl7E37YA 8mlyRzTDMW+Grr/3zlnKHVkRntgWjgD9hgzceWqY/IFR/ejtlc6wb0CqXsmRyedxIRqXuiEXlPp 0G+Eqd/n657Ugyb2/QLoI5tW0FumH8t2WfZWPfgHfmwlWyuiLCLu23c9p8vzyq56F3Xrg23TnBn A4ytBVr/rFqis+bbHXAnVH+sNIdbyhEe3myZqLiNbwnG+cKQ4s+88v4tPYrNS/YMvl/S/tlVNtb WtfzNmhkXRy6ydNfLLP1fkVm9TbXCuSj/HHjY5GM9Z/w5xkak= X-Received: by 2002:a05:6a00:2384:b0:848:7071:9856 with SMTP id d2e1a72fcca58-84870719ad7mr2037063b3a.61.1783659947725; Thu, 09 Jul 2026 22:05:47 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84847275fa0sm3400499b3a.22.2026.07.09.22.05.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 22:05:47 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Takashi Iwai , Nick Li , Herve Codina Cc: Support Opensource , Liam Girdwood , Jaroslav Kysela , Srinivas Kandagatla , Charles Keepax , Richard Fitzgerald , Matthias Brugger , AngeloGioacchino Del Regno , Shenghao Ding , Kevin Lu , Baojun Xu , Sen Wang , Oder Chiou , Linus Walleij , Kuninori Morimoto , u.kleine-koenig@baylibre.com, Zhang Yi , Marco Crivellari , Kees Cook , HyeongJun An , Arnd Bergmann , Qianfeng Rong , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bui duc phuc Subject: [PATCH v3 05/27] ASoC: codecs: es9356: Use guard() for mutex locks Date: Fri, 10 Jul 2026 12:04:49 +0700 Message-ID: <20260710050511.14439-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260710050511.14439-1-phucduc.bui@gmail.com> References: <20260709045902.498848-1-phucduc.bui@gmail.com> <20260710050511.14439-1-phucduc.bui@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_220548_676488_DCE39C59 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: bui duc phuc Clean up the code using guard() for mutex locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- sound/soc/codecs/es9356.c | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/sound/soc/codecs/es9356.c b/sound/soc/codecs/es9356.c index 1122455aab77..8c61c4bd49ed 100644 --- a/sound/soc/codecs/es9356.c +++ b/sound/soc/codecs/es9356.c @@ -6,6 +6,7 @@ // // +#include #include #include #include @@ -500,16 +501,19 @@ static int es9356_power_state(struct snd_soc_dai *dai, unsigned char ps, unsigne } /* power state changes are not independent across functions */ - mutex_lock(&es9356->pde_lock); - ret = es9356_pde_transition_delay(es9356, func, pde_entity, ps?ps0:ps3); - if (ret) { - regmap_write(es9356->regmap, - SDW_SDCA_CTL(func, pde_entity, ES9356_SDCA_CTL_REQ_POWER_STATE, 0), ps?ps3:ps0); - es9356_pde_transition_delay(es9356, func, pde_entity, ps?ps3:ps0); - } else - dev_dbg(component->dev, "%s PDE is already %d\n", __func__, ps?ps0:ps3); - - mutex_unlock(&es9356->pde_lock); + scoped_guard(mutex, &es9356->pde_lock) { + ret = es9356_pde_transition_delay(es9356, func, pde_entity, ps ? ps0 : ps3); + if (ret) { + regmap_write(es9356->regmap, + SDW_SDCA_CTL(func, pde_entity, + ES9356_SDCA_CTL_REQ_POWER_STATE, 0), + ps ? ps3 : ps0); + es9356_pde_transition_delay(es9356, func, pde_entity, ps ? ps3 : ps0); + } else { + dev_dbg(component->dev, "%s PDE is already %d\n", __func__, + ps ? ps0 : ps3); + } + } if (rate) regmap_write(es9356->regmap, @@ -1091,9 +1095,8 @@ static int es9356_sdca_dev_system_suspend(struct device *dev) { struct es9356_sdw_priv *es9356 = dev_get_drvdata(dev); - mutex_lock(&es9356->disable_irq_lock); - es9356->disable_irq = true; - mutex_unlock(&es9356->disable_irq_lock); + scoped_guard(mutex, &es9356->disable_irq_lock) + es9356->disable_irq = true; return es9356_sdca_dev_suspend(dev); } -- 2.43.0