From: Pan Chuang <panchuang@vivo.com>
To: "Olivia Mackall" <olivia@selenic.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Hadar Gat" <hadar.gat@arm.com>, "Frank Li" <Frank.Li@nxp.com>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Jia Jie Ho" <jiajie.ho@starfivetech.com>,
"Deepak Saxena" <dsaxena@plexity.net>,
"Peter Huewe" <peterhuewe@gmx.de>,
"Jarkko Sakkinen" <jarkko@kernel.org>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Eli Billauer" <eli.billauer@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Aleksander Jan Bajkowski" <olek2@wp.pl>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Pan Chuang" <panchuang@vivo.com>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Alper Ak" <alperyasinak1@gmail.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
linux-crypto@vger.kernel.org (open list:HARDWARE RANDOM NUMBER
GENERATOR CORE), linux-kernel@vger.kernel.org (open list),
imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM
ARCHITECTURE),
linux-arm-kernel@lists.infradead.org (moderated
list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE),
linux-integrity@vger.kernel.org (open list:TPM DEVICE DRIVER)
Subject: [PATCH 0/3] char: Remove redundant error messages on IRQ request failure
Date: Fri, 10 Jul 2026 18:53:05 +0800 [thread overview]
Message-ID: <20260710105318.376496-1-panchuang@vivo.com> (raw)
Commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()") added automatic error logging to
devm_request_threaded_irq() and devm_request_any_context_irq()
via the new devm_request_result() helper, which prints device
name, IRQ number, handler functions, and error code on failure.
Since devm_request_irq() is a static inline wrapper around
devm_request_threaded_irq(), it also benefits from this
automatic logging.
Remove the now-redundant dev_err() and dev_err_probe() calls
in char drivers that follow these devm_request_*_irq()
functions, as the core now provides more detailed diagnostic
information on failure.
Pan Chuang (3):
hwrng: drivers - Remove redundant dev_err()/dev_err_probe()
tpm: Remove redundant dev_err()
char: xillybus: Remove redundant dev_err()
drivers/char/hw_random/airoha-trng.c | 4 +---
drivers/char/hw_random/cctrng.c | 2 +-
drivers/char/hw_random/imx-rngc.c | 2 +-
drivers/char/hw_random/jh7110-trng.c | 3 +--
drivers/char/hw_random/omap-rng.c | 5 +----
drivers/char/hw_random/xgene-rng.c | 2 +-
drivers/char/tpm/st33zp24/st33zp24.c | 5 +----
drivers/char/tpm/tpm_i2c_nuvoton.c | 2 --
drivers/char/tpm/tpm_tis_i2c_cr50.c | 4 +---
drivers/char/xillybus/xillybus_of.c | 5 +----
drivers/char/xillybus/xillybus_pcie.c | 5 +----
11 files changed, 10 insertions(+), 29 deletions(-)
--
2.34.1
next reply other threads:[~2026-07-10 10:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 10:53 Pan Chuang [this message]
2026-07-10 10:53 ` [PATCH 1/3] hwrng: drivers - Remove redundant dev_err()/dev_err_probe() Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710105318.376496-1-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=Frank.Li@nxp.com \
--cc=alperyasinak1@gmail.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=dsaxena@plexity.net \
--cc=eli.billauer@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hadar.gat@arm.com \
--cc=herbert@gondor.apana.org.au \
--cc=imx@lists.linux.dev \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=jiajie.ho@starfivetech.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=olek2@wp.pl \
--cc=olivia@selenic.com \
--cc=peterhuewe@gmx.de \
--cc=s.hauer@pengutronix.de \
--cc=sgarzare@redhat.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox