From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-serial@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>,
Frank Li <Frank.Li@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
"open list:TTY LAYER AND SERIAL DRIVERS"
<linux-kernel@vger.kernel.org>,
"open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<imx@lists.linux.dev>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv3 0/6] serial: mxs-auart: devm conversion, clock rework, and IRQ ordering fixes
Date: Fri, 10 Jul 2026 14:33:35 +0200 [thread overview]
Message-ID: <2026071011-geiger-smugly-4069@gregkh> (raw)
In-Reply-To: <20260611033856.6476-1-rosenp@gmail.com>
On Wed, Jun 10, 2026 at 08:38:50PM -0700, Rosen Penev wrote:
> This series cleans up the mxs-auart driver by converting to devm-managed
> resources, fixing clock prepare/enable ordering, and addressing IRQ
> registration races.
>
> Patch 1 fixes compilation on 64-bit build with W=1
>
> Patch 2 reworks the clock handling to use devm_clk_get_enabled and
> reorders clk_prepare_enable after clk_set_rate to avoid
> CLK_SET_RATE_GATE failures.
>
> Patch 3 converts iomem mapping and GPIO IRQ requests to devm,
> removing the manual cleanup paths.
>
> Patch 4 moves the main UART IRQ registration after uart_add_one_port
> so the port state is initialized before the handler can run, and
> manages the module clock for console vs non-console ports correctly.
Do you have this hardware to test this with? If not, I would just leave
this alone as devm_* conversions are tricky and prone to bugs.
thanks,
greg k-h
prev parent reply other threads:[~2026-07-10 12:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 3:38 [PATCHv3 0/6] serial: mxs-auart: devm conversion, clock rework, and IRQ ordering fixes Rosen Penev
2026-06-11 3:38 ` [PATCHv3 1/6] serial: mxs-auart: fix cast type for of_device_get_match_data Rosen Penev
2026-07-10 15:14 ` Frank Li
2026-06-11 3:38 ` [PATCHv3 2/6] serial: mxs-auart: rework clock handling in mxs_get_clks and probe Rosen Penev
2026-06-11 3:38 ` [PATCHv3 3/6] serial: mxs-auart: use devm resources for iomem and GPIO IRQs Rosen Penev
2026-07-10 15:09 ` Frank Li
2026-06-11 3:38 ` [PATCHv3 4/6] serial: mxs-auart: fix IRQ registration ordering and manage console clock Rosen Penev
2026-06-11 3:38 ` [PATCHv3 5/6] serial: mxs-auart: clamp RX DMA count to buffer size Rosen Penev
2026-07-10 15:13 ` Frank Li
2026-06-11 3:38 ` [PATCHv3 6/6] serial: mxs-auart: terminate DMA before releasing channels in exit Rosen Penev
2026-07-10 15:11 ` Frank Li
2026-07-10 12:33 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071011-geiger-smugly-4069@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Frank.Li@nxp.com \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox