From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F51BC44501 for ; Mon, 13 Jul 2026 02:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uxFoTxT5QQqje+oE/KCQbvRkw65a9YSAM9FGmAc5evo=; b=bK6g4xK0/d1PuN00Nqlo40nJjQ 88KzV2j83nDg4Bvg+qgN3uSJpjJ6qNInksTb9rSsvaS0coZDZDWkGz+3uB3l84c5nF76VyJHOI6SV u0KlWVsA0s16OSklLAZcLvMnnBHeOIxsE4T7rGpLGn0oHCzxV4UuB5QJFg17SUQhwk8sqNBwMMuGJ pAIFQpnMexjhn6kwzunvDw2wR8mTaWP8sEvIAQGfG+2e+RmuhjevnjoLColnCJvgz5Wxd4RW+mOZd KLjjxDl2XRXt9qvae5HbkXVCVS9ueHi59q0+BITFFSjPz/9MNDa/w/5kBqYfrYpwD33Z4+x/I2X5k sPqkxOKg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wj6T9-00000007yZv-0MXa; Mon, 13 Jul 2026 02:32:31 +0000 Received: from mail-westeuropeazon11010010.outbound.protection.outlook.com ([52.101.69.10] helo=AM0PR83CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wj6T7-00000007yYA-13ZD for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2026 02:32:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K0Fk18qTPVOQ7weWfRfZcIbYVrp39+OU9GB6hVFK4KcpJhfMzjImGMDlnwtl4KjPIHOGx46YHu4Xp680Qeq/SkBNbhJkHhuq6Jjrj1lhyC28vvUN83AncFrUf9J5rM+K0sb8BtjKryRNiRVW/maqHbdYrozTzKnQX2zSds04n72ULqLSeJ9lxdY/+EsdjwIZtEkGokcuoQojQll1+1NCLtD8LlLbK75xZxYJOGxJSTufai6zwnCi8Cxej633G2sdER+dfljHYbMdWg064YLdlmZYn//ZaeNIwzs74NHpo8TECM1BvMonpcJ0gBa8Pe5tLoNlyOWR6U+O/e3lwLtzSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uxFoTxT5QQqje+oE/KCQbvRkw65a9YSAM9FGmAc5evo=; b=yhkog8E686MXOIUZbvCSr65se/J7NG6Q0YRU0VwHBLeJ0OvMZnSshBoF8qlrwgUp67ISWRRyl+QEk6wFxrXDYCGoszwwTnHQVhzVP2DapKkdfx5aoKM0UI0imjxC6kqcfkU3ng7+tUV4VIjXE5QQi5hFcUQ/3026/EdPLhNvgO0VFPeWCBf1cAJJmlyno3YhUPHQpIKuFpzyfNgpMrPpOA0NBSUwLVld+loZw94qE9q0zLQJwV+/OqC/ruw3fAQPwrGRr0vS1g11U8O44hl0xvI9beDxdV/bBtLQdQePxjK+ESMi7Fv/PRgXv925d/+aUXViYoRBRKfP2HGQ8KNqSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uxFoTxT5QQqje+oE/KCQbvRkw65a9YSAM9FGmAc5evo=; b=JtLfQzbvf6qXcyDA/hr/3Qoke24QvNgmcKAP0gU9H1Eazh9mWGpqqfJgpXJDmcWNGPRtz5/ywUy1Z+GUNIEIOKS6mejQWDYj8SaL3HYatoHPTFsE5Mn9ENNfjGI5bHIS8+xPvF0+p0k+xVVT0hQukwhVLbU/KAv5fpjIjN+oSLWwFOh54CW7tf4Ko7jXlR/pP5V1dTvCuGGnD6Vc+1lNHfR1aYbVYyNgTfdEHZZUt7MbD8WzDrWbKFowhonC/Aqu7ahl1RAeZLMSqSSNnp3IRmfhqomjVWXY0Bub3Mpb85Ns2lj5MqnBRz3ueW5sIcQahNvziblQJXp4Zvrn90yQCg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) by AM9PR04MB8810.eurprd04.prod.outlook.com (2603:10a6:20b:409::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.202.18; Mon, 13 Jul 2026 02:32:25 +0000 Received: from VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be]) by VI2PR04MB11276.eurprd04.prod.outlook.com ([fe80::60d7:a8e5:eb88:9be%5]) with mapi id 15.21.0202.014; Mon, 13 Jul 2026 02:32:25 +0000 From: "Sherry Sun (OSS)" To: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, amitkumar.karwar@nxp.com, neeraj.sanjaykale@nxp.com, marcel@holtmann.org, luiz.dentz@gmail.com, hongxing.zhu@nxp.com, l.stach@pengutronix.de, lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, bhelgaas@google.com, brgl@kernel.org Cc: imx@lists.linux.dev, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-pm@vger.kernel.org, sherry.sun@nxp.com Subject: [PATCH V6 2/4] PCI: imx6: Add skip_pwrctrl_off flag support Date: Mon, 13 Jul 2026 10:34:33 +0800 Message-ID: <20260713023435.235765-3-sherry.sun@oss.nxp.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260713023435.235765-1-sherry.sun@oss.nxp.com> References: <20260713023435.235765-1-sherry.sun@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2PR04CA0004.apcprd04.prod.outlook.com (2603:1096:4:197::22) To VI2PR04MB11276.eurprd04.prod.outlook.com (2603:10a6:800:296::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI2PR04MB11276:EE_|AM9PR04MB8810:EE_ X-MS-Office365-Filtering-Correlation-Id: 91e03a6d-dacb-4615-57ec-08dee086f973 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|19092799006|23010399003|7416014|376014|18002099003|22082099003|56012099006|11063799006|921020; X-Microsoft-Antispam-Message-Info: GbK+idxBU2AqTNHc0ijRVwvtGaKoe+/oj4PhMpXB8v+rYgG9xiumSjR0Rb9ADB0lGKWEItqsm0jRYtUPSpGJqz8M4RXYYKYck3HJo6Ols54oIq1QeUmOpicsre11pc/cCEj8TAiC/U1i1CyWNQ5Nqd1pLAyv/thW5i94Eyeu4LQFn1uzQATGd7JlSVhSJRFMkWmfSjjIEy7WQB4uEu5cPlkjqbqtzU5WOenYVwivM72baYo6/iIpIKbqksm55lgcKG9CB+nAJ0/Rzsux3dh//93m5IuvNHPGw9wers6E/5/uznZfperguUCtazuADjWwGOf0qAZI7amy9aPc/qeZzvOYtRVF0BFm7vsRUXs4BSXzaid90z0Hs5Z9+Y/GwycDp4JCP8kUWb2JYPw2Pn4FWuGY80jf8+7ZCIJx8zQwYRGqBEb6H3sTyccs7qvE6lregX13hOxi/5II8Y32OftOC7rVzi1vjGkGW8tt+KYw8OJ2bGgiJ9xszoRaKDgMozMFKNUSlAYZtCid51VXW1xFV0qfKznXW1SMd/90wp56L2AuGm0vkv5ksHJu5hk6BNwfmqovmxAy265sEbNvqhA1PK6X6eDtydhsi3JR0FPgMAj0Vsueq8K0wnG/SG5Xgos+y5j3XEuMwFhrYnSTMg8JBBorXA7AKcMy5QZoVjOoRJ+7LEyeDVp9f9isQ4uI1+urjeINUiE2xAWosqe1jBlxrA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI2PR04MB11276.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(19092799006)(23010399003)(7416014)(376014)(18002099003)(22082099003)(56012099006)(11063799006)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6tjDf3duxTReyQMfSUpHbplUjTRKQJrIDpKcbs2mJs9R9EViX1SvofVuqov0?= =?us-ascii?Q?zB2qiVjFrZKuGa0rkzvNhWXvWzN96GeIA1MvnlKa400deRetZFEPwTAmiSad?= =?us-ascii?Q?xiJ6WTpUYVznynFWHhL6TZRfRjFIeQRNj7KXIB1VMJq3xFRoe175+ErQs0GE?= =?us-ascii?Q?AVL9Lr+dVdqzEDGcow2s6nGUQzu7EIWsCWELlHSY+clmB7sw0cWSPC3ejSgb?= =?us-ascii?Q?7tlYNEQYWiNOnuCi3lqMFGKUwnDrZ5fS7BC7mL6dOgeLnyB829Dh0sDg1UoF?= =?us-ascii?Q?BBRy9nEW25CM8Gf7QH5jsFxOuXtYP5Jn3jFH7Afjp6V1QVTMamw3kJurFQmC?= =?us-ascii?Q?oY8cXxZSa/y53Sr95vl+nan+epGYmQbeGt7yHGYFa4CzGuGSb5vARHOi6gOY?= =?us-ascii?Q?dYd/59IK6sboOI9jiqhUDkx3PPMDXxPVsHsyZgajz3levZ5AJs6gxTXiy/Wt?= =?us-ascii?Q?6K/xcuSUZ2UX0+m/XvIZyRuiP3KlH0caDviZaBDhCVuykF1k+xjRC9UCCN0u?= =?us-ascii?Q?0GwoV1eE0B9r05t9b02Z3DkWfNHgdM5DogzEuJY6qbO2z7Av5z7b25OVsNWf?= =?us-ascii?Q?rUdkAWH2FesR/q1h8ssL3v3t4lH6DSGAy47PNPzbELee4Qtvhq7YAVuj0VqE?= =?us-ascii?Q?+8EffwY8u7J1efQfLByfBN9fXJjU+x5o5b9klP3q7IBBcZDsgSXia5M1lem0?= =?us-ascii?Q?46HcuSYuKRwHZlzMm4kYnQsWggdrmHHvuLAsjOCI3+1z0Y/Xvm8pzw/SXWpK?= =?us-ascii?Q?8g383E1vkqvzfYJQvJ2axKjCDE+CusBUXmA+Ex5jHpm3cJg+ornQU6bMRy8e?= =?us-ascii?Q?wN3o4I21J6pu7NYlo4gKuLPPheRinIApGJ3oMxvJvEJKUtDNmPieF2kSzrxh?= =?us-ascii?Q?C8p2TbOH+gdhNHqSQDT+JBDlgFqSwIFreuCH/0s0HP8QQWQSl3IC8lQHMH7Z?= =?us-ascii?Q?gMfAJ6URiYVVdJlNoal/RZN5CaHYN5VFz7PKRKIWziFkXrmBrgInZBgYGXPQ?= =?us-ascii?Q?RjWQANTFcMBMkq+9vJv6YZQF21mHrdEoukmy4w8UEBmN5VjXCHsbC17GoRSQ?= =?us-ascii?Q?acHVOH0o4QeQLuwzMwVYeIOYak1tLuw0hsaaUSrATmAsSO97IS010fxC99pq?= =?us-ascii?Q?BwEsDXgFi04nb/tk71ezFhopYUHusy0LwbsDZyO73daWVVJi7Rjk+6aaHe5d?= =?us-ascii?Q?oJjf2M9nTEWsYGD5FDirAFpbHegAe1AsHfu4lMRAKk7s7jQXrCBHBCReLwQk?= =?us-ascii?Q?nKW6CRMfIEOVpUt0hWq7OWVR4nd247C/ANLRlx3Le0jkXe+XKr0RJn16H29Y?= =?us-ascii?Q?bo+tbv5l36YigZjbtmrkeXfOCWJB2mRx5K/CGhXki24VhSQrLdu0wyrCN/bM?= =?us-ascii?Q?0ibzslQtZ1iInBmHXbmd9QXY8810rdAnkyiFa2iEEdOFsRR/nivXbV2Ru9kt?= =?us-ascii?Q?qnARgI/Dzd6fChbfHis94Wu4cl2JjPubK1HrMWbJ60no7g4zMpDC4v8FJyR6?= =?us-ascii?Q?t6xGaiUtsEBft2bETJj0c3exq/pGzJIh5yhnLbOSWQgHnS/XvWqCWmD45egG?= =?us-ascii?Q?IAEozV8+zf3rdwSWOaOjF2E/mNGqIq2R4sFb8G9Tz6S4ALo1A3Uqnas1Waju?= =?us-ascii?Q?xMxOpLsUoc5B+zdu7jPAbYg/P8KEj+d/sYmZYLPOD+DV8kSDz6KjMo1EWndU?= =?us-ascii?Q?I2ab5aBCplTWuOPchGU9XxvLlNAaHVQjbRRH7qMMRGPs19f/H4bvWmwpnPbZ?= =?us-ascii?Q?pLuKEKarmgsqRQcvVx3K/K84CE7VYsFow5vjZLC42P+P5uuwijWH?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91e03a6d-dacb-4615-57ec-08dee086f973 X-MS-Exchange-CrossTenant-AuthSource: VI2PR04MB11276.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 02:32:25.0377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: k2ffq1h3WNsngWlR4jQRii+ZsAXXC7eHUeVnVzG12fxaEXi1JupG9Y7ghFO1IJGeAK408m3pwTybOiN6j5Zut4lU+tZ1MnA6N52joZBSGUsGLNbPL7pEjqaGiLEDd2xH X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR04MB8810 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260712_193229_300278_C1C02A8F X-CRM114-Status: GOOD ( 11.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Sherry Sun Use dw_pcie_rp::skip_pwrctrl_off to avoid powering off devices during suspend to preserve wakeup capability of the devices and also not to power on the devices in the init path. This allows controller power-off to be skipped when some devices (e.g. M.2 Key E cards without auxiliary power) need to support PCIe L2 link state and wake-up mechanisms. Signed-off-by: Sherry Sun Reviewed-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 92f8e4a299e8..afcf3b6bf3cd 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1382,10 +1382,12 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) } } - ret = pci_pwrctrl_power_on_devices(dev); - if (ret) { - dev_err(dev, "failed to power on pwrctrl devices\n"); - goto err_reg_disable; + if (!pp->skip_pwrctrl_off) { + ret = pci_pwrctrl_power_on_devices(dev); + if (ret) { + dev_err(dev, "failed to power on pwrctrl devices\n"); + goto err_reg_disable; + } } ret = imx_pcie_clk_enable(imx_pcie); @@ -1454,7 +1456,8 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) err_clk_disable: imx_pcie_clk_disable(imx_pcie); err_pwrctrl_power_off: - pci_pwrctrl_power_off_devices(dev); + if (!pp->skip_pwrctrl_off) + pci_pwrctrl_power_off_devices(dev); err_reg_disable: if (imx_pcie->vpcie) regulator_disable(imx_pcie->vpcie); @@ -1473,7 +1476,8 @@ static void imx_pcie_host_exit(struct dw_pcie_rp *pp) } imx_pcie_clk_disable(imx_pcie); - pci_pwrctrl_power_off_devices(pci->dev); + if (!pci->pp.skip_pwrctrl_off) + pci_pwrctrl_power_off_devices(pci->dev); if (imx_pcie->vpcie) regulator_disable(imx_pcie->vpcie); } -- 2.50.1