From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F29AC44501 for ; Mon, 13 Jul 2026 04:36:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MdLDYkWyWiJ2CTqf35B3bvhbjM7PIcSppgnmNL/kALM=; b=ulQp6RNWZWU5XjyaaP564Z2EJ3 FAiWz4ktzUMZ2vo1NAJsag4wSCOm4sPQyBE0Qr+RrYw5G6mdMd+5/2S4yTzMgm1jApP19i+fmd6Hu E3N1P6xI9MHuWvYhc6Mer40xWho5TkaqiHxO0cDbOnqVVIMO3fx77UQg6EHiFOlskWhGc8s2qB/fx wlfIRKIpo5M6gZlj48ar6AB0iBo2kT+FJM40O9a7Hbe11X9QfyntKkS67FWcqOig2RC0JyDvPTPyj Y1Q4adgoCHrtcHwSgLm916TsP5sTbDTl6Zhp0nCaqBt2TlcmWP8RK5DKK8vTTtCNtumgFGMDijFhO 2TIXAdbg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wj8PE-000000085vh-0QBR; Mon, 13 Jul 2026 04:36:36 +0000 Received: from mail-westeuropeazon11010045.outbound.protection.outlook.com ([52.101.69.45] helo=AM0PR83CU005.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wj8P9-000000085uB-3K3j for linux-arm-kernel@lists.infradead.org; Mon, 13 Jul 2026 04:36:32 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vx5DFrMx6Spzw9TKLw6Ac7HA3RlMMYH6msXo7xHQ7ezytxtwIO6NSVk6WpolZS+9syuZkVDrP32Cmkqrtc5rpRLQhabJQEtQ8eaEaNgOGXCO55aL/av9gUAQQc7ZGz920N71BKWJko14ZyN0QBuzQlBX9eRCj4M6iw7F07JFIsSOOXALRQAwEbZl6rsarcxGd+Lle5nCSmFn5urxTVP20SqIDd/uPLDpycvJz3n0fvRVmh6oBfZXXjdFV4AAlnPsgYURrQY8vLvWeRS3ZZk3ebixgw9Q9ZHkopm2zWfLoha8/hvzCrlqjvemLcil4GkQynJe5m2ygBP1hDJ7BdzDvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MdLDYkWyWiJ2CTqf35B3bvhbjM7PIcSppgnmNL/kALM=; b=kKZ3nfSGAyxSLxok432o+wC+42h+c0BPEPd7LtZBuJHWB7n2TG7w/7+VhE0F597G6Rb22eJEFHxktab7+8kEPgIAeeUPDtrnArLqgxu8MQxGm8gfwi7AWx5qWLTCmqMYlQXdd+y+dUtAY2I0VjSdZDUPRoFyX3ECQSLn73Rxn8h267yA0SNqBCvjuSt2fbrB/U4Mq4hQZJwucaqufWIGm+R4hFgRS0H7UVqb3CAfF9Mywrne1xsf+BVgUN/XwJDXaCijX2IPYa8YQo5Nk8bvoBQP0TbJ2iz6y4MUUShCmgd6Dx8v0kvQzMz9pOvbU+RPeE/IUitZVyQShpCpJ+/4NA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MdLDYkWyWiJ2CTqf35B3bvhbjM7PIcSppgnmNL/kALM=; b=bo14MFq6GFjTHtCJimtTsWppRp7oe7ZF+Lr2bCQm9UUNBEX9N9WQ6A/v5RG37vK8T2Ht6YqD5T3REHF6HlWygRBj3pctE8riqbKK3BuYSJaL05yCfL9HnnU+hTiVeDdkm+lgrZ14AAowdVLubiP+6hYIkRd3Ld+DarcVKxszLzYzfIVPh40ASp97fg1fJrungnROesb1E2W9ghPWYX+vzQHGnsUKKk/VnJ+wvQi5wDKT/LdzYnu8ZimHNoSRjW+jx3Z4LgVmDXU8Ii3h6EzbCVMHMiSYTExBbFE24jUekF9PIoFhvdKScBLHHjxH2dn8LwWXMGNGYL372ajR3cIhdw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) by VI2PR04MB10666.eurprd04.prod.outlook.com (2603:10a6:800:27f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.181.22; Mon, 13 Jul 2026 04:36:29 +0000 Received: from DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05]) by DU2PR04MB9180.eurprd04.prod.outlook.com ([fe80::f94c:ce27:1558:fb05%6]) with mapi id 15.21.0181.014; Mon, 13 Jul 2026 04:36:29 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v6 1/8] mmc: sdhci-esdhc-imx: remove unnecessary mmc_card_wake_sdio_irq check for tuning save/restore Date: Mon, 13 Jul 2026 12:38:57 +0800 Message-Id: <20260713043904.4144172-2-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> References: <20260713043904.4144172-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: SI2PR01CA0036.apcprd01.prod.exchangelabs.com (2603:1096:4:192::22) To DU2PR04MB9180.eurprd04.prod.outlook.com (2603:10a6:10:2f7::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PR04MB9180:EE_|VI2PR04MB10666:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c1c67a9-3cd4-4189-bb55-08dee0984e85 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|19092799006|11063799006|56012099006|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: KUDiL6K1OicG5TZMru4oyK2WWrnEDSptJmZ42VLWK8+u0fZgTn47p2r9JnBd4gLrmDtNf2mkSi9LWtdxBIAS+hZP/JfNvCwUGH5kDeFfry3w5vb8m8PAdUoxTB9FznpR//s9z8lf/+2Rm82ZdQYKCIWPfTFnG/QSOKkT23pnvzRb2aPjyUkwg4zJDZvvw0amE/0BXUd6WMIbdSj58SUqmxLVGOJYUUQsNQo5xFIKsBUI6QBNSFAWflk2lff18pyQM1p8+jptLVCg/2hhXBxH8asQJh2h138lmIuLkUsRRrOcoMDP42w12E+REp1mx/rbwRwmsGRTm4k2BA9dBSP+kziODcnflcxi6r2YWX4oSfLONVXEh7hGoGBzi6gl1p19I6sjQHucFASzAxcy0YUSuYcla/8iw/i/blaXD4yMXqs0ZlD9cSwkX9hNYg55QxjzBOYd98KkxZMiiUT8U0wN/JRRdGPAi31zbkkXKpWK5KwRxyLEmsMXit3zeRYyyow0JkuhbtscvQahjwnTy2SOypKBUPWXNyhMRugUAk7lAoG3TFHWid9jLkuNDNuoDxMorJofANGz4PVFon2LO8CnJt0TDZeWRDTsisiR9jMRzOgUitf1By53o/G+WNbXiusV+2hEEKOxmNXjr8eKIcheH+k+3Ut4InZM7B/bJKsxFRA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB9180.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(19092799006)(11063799006)(56012099006)(22082099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AHoqGB5XVGykUCgM/WZrxumHswmvMaC91tIXKkiBIlHC1jxFLYRMBTJ/5wJi?= =?us-ascii?Q?9BbBfBDnZYThkxHmEyQb1tbLyqot2UXJOXV5jtbhRUWwb/66SH3oASI22rRO?= =?us-ascii?Q?l/TAOwTBzNkpGSp1jR6qhURtnjXJ2ShjdtxLqnr6xNhdDhjETiXxhJohI5hp?= =?us-ascii?Q?4C76yACjpRcpW9b8LRV9N9NGyXDQnvuqqZpK6tOQBJ1c/jMRrEBRq2rXvAGR?= =?us-ascii?Q?5BiTOQ0DqoMmJrDmzGcJxVG5ucu4ltaruXhly1YFKf4W1YHuOqkDCur6irvI?= =?us-ascii?Q?4j4KdSzX41+5T6/0X9tUBF0OaNvuqMRClIyqtBAdE1KlrqtYdBLAcMkUccuS?= =?us-ascii?Q?gXtG+7RPDnrwEsgGc2OgmTTf5MIitOK4m38Vl/HR8Y0JUrqaTJkQWxIn9GIi?= =?us-ascii?Q?RV3rp+zFxqXXJVLebjniwG6yU1vkLJ332pZod30XqA5wW8lyfaNA/kVbz8tG?= =?us-ascii?Q?TFdNczAl32mvEAscsPvOBn0Un4Y6vu1hnjtp/+JfILP0cmG5E9op9tQIXvRn?= =?us-ascii?Q?H4XI3ZSC4QSckZgb4wzjmxuHZ+IGI4qYcjdTVVY598EAUdRuYWBpb+2dhkkI?= =?us-ascii?Q?NAVbPpNs+j+PB4d8baurB7u9xop5nijG8ZHBu11RLNdAG6QrZPvT8xY10xae?= =?us-ascii?Q?vRJL6lhtm9sUyfstNSZO0IvcBmG90EOTOwQfb9e+s628uOZfexvetFzxb9Pb?= =?us-ascii?Q?ZbAGUzOu5dbZ6nQXQ3h5qQgb1EaOAzgED7Ewf8hl+vhVyHDA/wujqVX4H3IQ?= =?us-ascii?Q?Tn3gw7M7Reg+DCYS+gCR9Rt8y8Bs9/Lh44QQ+sUtxGS4+/3KDNO6Il6m2Q04?= =?us-ascii?Q?MjNGk9Gd3fzq4LLzjg/gwjGadh0YxUTk6OlbCX88pq1S1RCP1JlVOg2FfEiT?= =?us-ascii?Q?ORVpkGh7SlxcbiWO3aDOGQWUWnb/A0pP+9HW4YxfaHibr5DWZY8Y/Esbc33H?= =?us-ascii?Q?Ksg1ycY+dShTvHlPAYyRz+Syy9qkFZHkxUMvdPYwNcid+d0Ya94grF4pmhW9?= =?us-ascii?Q?IRsf/Zr5yX02wq91Ro+Oa/vc4u9tC0O8h+sD8ZkIT6l4Vw2xMFJfS6sSejGV?= =?us-ascii?Q?RwOfSDvNMWsaWZFhK072Uw1Lz7w2uejMtHsAz6GQKlbBHkVGdOxuXwY6XSz1?= =?us-ascii?Q?yYJENHbYQ3U37n7FJeg3OW3riPTfzn8d2tOuGytKbfPi9OyhFYFwVFKpvtuo?= =?us-ascii?Q?ud0U+TnxC935ij0MMpLCN65UobDozYqruRR6tR5BSV6sH+7R4VmNR0AVr/r0?= =?us-ascii?Q?6KIQ47nll4lU2l1NORtZVbIbnpqJTLWEOPKskjmD6YMmx9m5c9Zx49eukGTc?= =?us-ascii?Q?jYGegA/decmfz5g7QPHZGpenHupBzh8Usyvm3q4t/zoMaLvxiy/bK/dGihVs?= =?us-ascii?Q?if5jmuC1odmNLzEmruerBiMGgvGn+uEi2Rq8P+f2y8eWFLFzbB2L/KzEOHaB?= =?us-ascii?Q?2ckLK/YuXzpgyKBCVmxud+HqA+iq9qx/DY4hwwGuL9nRGdNyshSX4OP5FxDw?= =?us-ascii?Q?mdunDo04chBt9pm8zclv4MQG0Q3fKNHTyJmqwcvvnUJDlHVFIyINN4s/x6za?= =?us-ascii?Q?Le889WS1tzb23KYZ8CrXxRj/6dkcDKzEv/O3G4MaHccqpE0VBslRcgX1SzHp?= =?us-ascii?Q?6v0IrC52cDr9Xzr9sD/lZo4TstAj5YRUCLjZbOUvHiaFgnq9yiWCQAfNqI0j?= =?us-ascii?Q?VUNbgOt8685/ThdBjBkdycC79iXwdhG4p+sINMT0kGyLfkuaovn7Mv2/JIf8?= =?us-ascii?Q?qIzfog58N5vGkGtqldlSuSBLpMWqioQcCtH5/N+r7rPmSEdZoKp36lG3RZJ2?= X-MS-Exchange-AntiSpam-MessageData-1: 55bRwmzFhZp9uQ== X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c1c67a9-3cd4-4189-bb55-08dee0984e85 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB9180.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2026 04:36:29.1092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 22jorbsHWrMlf/B5NHxVcWqmiC69V/G/EzQfwixZego/YlYImnmmM59FnqmwyE7vWVsGw81AfPGhRE/VUOiHje0PLD1ABkjRQD2fBsAKDH4qbIwU196SubBJZy3H5HvJ X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10666 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260712_213631_832649_729CB45C X-CRM114-Status: GOOD ( 14.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Luke Wang The tuning save/restore during system PM is conditioned on mmc_card_wake_sdio_irq(), but this check is unrelated to whether tuning values need to be preserved. The actual requirement is that the card keeps power during suspend and the controller is a uSDHC. SDIO devices using out-of-band GPIO wakeup maintain power during suspend but do not set the SDIO IRQ wake flag. In this case the tuning delay values are not saved/restored. Remove the unnecessary mmc_card_wake_sdio_irq() condition from both the suspend save and resume restore paths. Fixes: c63d25cdc59a ("mmc: sdhci-esdhc-imx: Save tuning value when card stays powered in suspend") Acked-by: Adrian Hunter Reviewed-by: Frank Li Reviewed-by: Haibo Chen Signed-off-by: Luke Wang --- drivers/mmc/host/sdhci-esdhc-imx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 18ecddd6df6f..6526d65538de 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -2064,8 +2064,7 @@ static int sdhci_esdhc_suspend(struct device *dev) * to save the tuning delay value just in case the usdhc * lost power during system PM. */ - if (mmc_card_keep_power(host->mmc) && mmc_card_wake_sdio_irq(host->mmc) && - esdhc_is_usdhc(imx_data)) + if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data)) sdhc_esdhc_tuning_save(host); if (device_may_wakeup(dev)) { @@ -2124,8 +2123,7 @@ static int sdhci_esdhc_resume(struct device *dev) * restore the saved tuning delay value for the device which keep * power during system PM. */ - if (mmc_card_keep_power(host->mmc) && mmc_card_wake_sdio_irq(host->mmc) && - esdhc_is_usdhc(imx_data)) + if (mmc_card_keep_power(host->mmc) && esdhc_is_usdhc(imx_data)) sdhc_esdhc_tuning_restore(host); pm_runtime_put_autosuspend(dev); -- 2.34.1