From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CDB3C44508 for ; Wed, 15 Jul 2026 07:16:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9Z6cjgr6a2AD91mY5jk5k57YvTdBE3AQg9dojPDbHtQ=; b=CX8nS8Jd7dBALLLIUC/zn2tw0g csGY+wH1yO2AmEpbz5k8XlUWQttFmOdpZW/Q5+05rdmKEjGIfPT5F8q/PwpLpnFheJmyTEAKFF5KG eVjhCte2hkjgcRUh0stRYjfb8VTRcmkE5nnBRoi1cCOiiRSwqMFqf0/bgCf2yt1AfhMX/dODPp5iC jp5L3ZAznZVpzR1uh31KoM4fwXA4JajL7rRoiAQwC5buW1PXi5FS62ptvzyjOXPJRPKNTIDhKs9sI lBwsFA5FvGbtEDdULYBM3vp4SftEZEsGNSPJ4142caziBFbZOzQf+zqHd34EuMnYUUM9GN5fnHpO0 aBpOxNEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjtrK-0000000E03e-1PCM; Wed, 15 Jul 2026 07:16:46 +0000 Received: from mail-northeuropeazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c200::5] helo=DUZPR83CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wjtrH-0000000E007-3DyE for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2026 07:16:44 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LUoOcqlxDaqGuvhUqGJn6MxPcE4P9bJ/QuhnJiDEMT/s7F0DLqjYfSNDitgrBg74U9ham32xCDOH8bN6vhYHxcA1r57CgH5b+LIxmg/mdAwqQj3yx4ow8kRZUjqERmzpzE7rjAkpn4/Vyi+NCYtxBZ/BL52piJQzfVbWkrQvmWjv9wq3HHne+Cu3wwKIxPC1VkF1hUbH/cizLLxJ1jT3ZVzzgLf7/1CmZTP5OTNXNX1BAahpvhRiyS5/aBF+HJYA7gxXOs6NOKc9c0tJfJ1mEVkvRe7bAH6q8NuxMvA0ePn6PvzRl+wWhXur4tN3UzV00aeW9Ff0InAdjwnm5YC0oA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9Z6cjgr6a2AD91mY5jk5k57YvTdBE3AQg9dojPDbHtQ=; b=scn70nxBjFj7Ps1hHafdUVliCrdY1Kylfarrx7q2TOboOCkj4du7VBwvJHJeiRf08mLHqP6THdIxZvbvZNSaxAReY4beTzeK2KtCwBgshSwFBt8tmET17BpQzrQGifPcLyLWbRFXJ0xMGiPVPKaGeChaqo2pjIvijwaR3WNTRudJv2y+ibgal0dj/fBuQYU8rwIO9FC0rDkQYiLIyMhyevsHC99iK9+j/YrFfrnwTiGS9Yo5+oacteCUVsJz7z8gCGOlGV+kqMucTBYMvX91GvOHA72vS7RdwzN0Q6KtZHFWdx2BbUvnxYdz/UoWAzfUV+DVf6ny+rkvvZbmVi2PFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9Z6cjgr6a2AD91mY5jk5k57YvTdBE3AQg9dojPDbHtQ=; b=rrO3Uv7wtqIcL/wj25958Mf3yzwrM2HmyEAjYG+8SUiDG7Y2ZcSoRyY24hhxPEwQM1dRXynl/57AZ3BjpxMZWhBnuAo/1dFPKKcG4PfF6ErhEZw7MyGSuqdzyhIJLx4kJfBfsfpRu2OMqTWsAzTj0sS3mRdo4O9tXRZbjtZj4FANhLJcQ0hKOhqDp78shmhy2pEga5E5E3qimZEbztrrB4zipueEAWdeWjXKr53FK3tesZzY2p02nRO/8eRGgzyPWWCKQM2MM1G6UgdaD5SaD+/d/L2C7UWev75gB7AF6nBSli3D2Gz15j2CLn3sYREi8S/0c0vCB0jdWZe8HJEYNg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB9185.eurprd04.prod.outlook.com (2603:10a6:102:231::11) by PA1PR04MB12197.eurprd04.prod.outlook.com (2603:10a6:102:560::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.223.11; Wed, 15 Jul 2026 07:16:39 +0000 Received: from PAXPR04MB9185.eurprd04.prod.outlook.com ([fe80::b4c0:6119:2228:2ceb]) by PAXPR04MB9185.eurprd04.prod.outlook.com ([fe80::b4c0:6119:2228:2ceb%5]) with mapi id 15.21.0181.016; Wed, 15 Jul 2026 07:16:39 +0000 From: ziniu.wang_1@oss.nxp.com To: adrian.hunter@intel.com, ulfh@kernel.org, haibo.chen@nxp.com, Frank.Li@nxp.com Cc: s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, imx@lists.linux.dev, linux-mmc@vger.kernel.org, s32@nxp.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 7/8] mmc: sdhci-esdhc-imx: make non-fatal errors non-blocking in suspend Date: Wed, 15 Jul 2026 15:18:17 +0800 Message-Id: <20260715071818.272318-8-ziniu.wang_1@oss.nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260715071818.272318-1-ziniu.wang_1@oss.nxp.com> References: <20260715071818.272318-1-ziniu.wang_1@oss.nxp.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MA5P287CA0173.INDP287.PROD.OUTLOOK.COM (2603:1096:a01:1af::9) To PAXPR04MB9185.eurprd04.prod.outlook.com (2603:10a6:102:231::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9185:EE_|PA1PR04MB12197:EE_ X-MS-Office365-Filtering-Correlation-Id: 6c8ac6bd-4afe-4575-2998-08dee2410371 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|366016|19092799006|23010399003|1800799024|18002099003|22082099003|56012099006|5023799004|11063799006|6133799003; X-Microsoft-Antispam-Message-Info: STKhmNqCqzJVJoaEqC1GvcgeBaUMElUiXzUALmzQlLZPUYqzr1nXpJ/xUhOAs60mMr0kDBhfKnVUnqwDvnwUksR0yY7NRe7T631bYwWCGygxmuGD8pD6T3iBrUY8q9QGzFKBX6/uTa8AM0C9S9eZIyI/nd6Rm/DZm1oKqEpHpyfPDS5Da4TMCQUMHEZZSHKodMRJBBI2nn7CsxnLahs0PegQvH0WwBR4UjisiSGKBVIrjIatgJ1waCPweM0ewGWeLRryKIXRZyNs0EkrE+Y9ZRYSTOtUNIDbM2skWKdTcLkFlEsK5MXCHrfJdfFZ3Z+uxhEQafuqwpKR9IaKSPC7tzlK/wd/Tey+Eg7N4ZmuR8zUEtUovzxeW1gsgmrvoqB7DYZac2r2RAyvq2NW9WRFp4SmEDd908x2PyCVD7QA28S+ue7qshtQWIMQ2nuIrDbjaIUaCZ244agdNweCHSlVqhQH46JGQU+kxJ6u6GDBiGKaEGpYXl1+N4vDLY45q2FR5f8N6W2WA65Hj034hzZWDc0OD+TNTUUuyXtVwep9XMXyCiphdvxnepshuPwDEtq6ouyFdBbrfdJ23Nzq5v0L1bGg2uOvgi2P5gT6tEc6+rgOzf+Rg0bEmGZ/h9WK7JGty9bORSvj5GKB1D+LDZZv0v35VZ2cv0dLWDWv0oOKM1M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9185.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(366016)(19092799006)(23010399003)(1800799024)(18002099003)(22082099003)(56012099006)(5023799004)(11063799006)(6133799003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Nb+N2FZZObjruN0dw442UQsC7uMtjIlSQKgHJTJfscADqbFEzgL2dcAfkXTm?= =?us-ascii?Q?zyXaz3jE0sGkHYmFPK21S5CxuPa1LXuybp+K2scm937eIdqyXH1XIKz9swfu?= =?us-ascii?Q?rA8LqxAuqIWbMFIbbC5UE4+Pv1+XmCCvy1IGPLZhH+JsfOtFmVcWDUSZ7EzS?= =?us-ascii?Q?opCioZJlOBnSvq08OGEV7ORlfto1ecU5zbr530FYYrJy+1qQUle6IkTmdC6D?= =?us-ascii?Q?zFkZQ/Gva5eG9RYFqcTArMMXGF4EgZLSQN4V9D7RXYomsUD+13bF+qA/a/my?= =?us-ascii?Q?JCdIxWc494fqTYddnPYmTYiewFw9pBqFpzZb4GEFajfFWMpYXH59QK3Wx4mQ?= =?us-ascii?Q?AxK8UEiAJWGo0CNeKoqKlscQbPEEx50kJ+HIwuko81zmu//WXP/wH0rvbINF?= =?us-ascii?Q?ZMgtnO0v5CkSRJ2vuxwyEU4QaSOwlnhXEzeCQoDUA/e0nr5yVO2qwKukJ21A?= =?us-ascii?Q?LBUlI68yW5HQ/EHAucghQI8dkzgovuChqG8pdF1zXWFeu7TArAzpPG9AF94/?= =?us-ascii?Q?JSCxCO2eTRBSJeGvZ7YgSiPlYC/jd6auAuln/vS1v/h08fwd0J47VSakjGyx?= =?us-ascii?Q?y2hTPxYXxIPbQKnmVjNY9A2T0QJUTrnaNwcEJ0J5iazvnyfbJnA2IUyOoZVX?= =?us-ascii?Q?qRTfJ47/TtBCbE8si6sSqqXky6h5Qrkj4WOHQJciZBYDzGbzzfs3nyw3zC0D?= =?us-ascii?Q?AHb3N+sS3B5gULyfUe2iDxEf3NReX0n9dQsp03Iy/+eHal0yufxGCcHuw5+4?= =?us-ascii?Q?cAXh6Q15I0PD1iZ5oFEMVtAINCX/T6z4HJ5PAmkBZSfyHedvSJOH+A200of5?= =?us-ascii?Q?IR1AvYAPTpf9y1iAeGaZTZ0e0HaOt61VvdgajeMuHaR1Arnt3FKkWeeg5Fej?= =?us-ascii?Q?Z0SbTEKwFGX8/gi+IivnDoNHq6WDt/WAx0ZmowEOd4rwW7gRvsN1yREPqLBR?= =?us-ascii?Q?BhYPf1/WqSupkxu/dYuy/P7eYeCpbtUSBsqwkU/uUX0C+syovTdcZ9WK+9/Q?= =?us-ascii?Q?TWlTy0W8HB/yxI97agRRKMDWTnqQFc07mODgxLNtxelseloKT3P0a8vF23Yf?= =?us-ascii?Q?soSJiaFv5Zcsgq+ozhTIhxmxH+rVdnySjlpt28Lak26+MMoOJRbUmY+mR141?= =?us-ascii?Q?/xP16h8PHI+9SNKeGmC/0GpRnljAM3zW+jU3sIrjeNZ8aFdGkPO/WgNJDNk/?= =?us-ascii?Q?FQVfboi8jKKIoUqskMrMlaTCc5rKrgU5lZ/ASgoLnYO1iCI5MJMyeqgJB04D?= =?us-ascii?Q?GvDaLgnqJR7M4dsRZ7hMdcmum6zmBZ+gUfEfWe1sDFhEUdKugRSlP8RjwlBS?= =?us-ascii?Q?oKlI662mL1dsc+cimWIovxfv2BMuMHQ9f7GdpRAE0Y32rCoOLHumctYMmagN?= =?us-ascii?Q?zfI0KADQOFUothnG2LTNwvoDHtT75+vO69J3HWimxrWybsqPZndflUAeIk/j?= =?us-ascii?Q?6cHYqIlFh68qvW7al4gmXmYJHojFmqezJc+W2/tgKWgZEbbQX9HupUqAoqF2?= =?us-ascii?Q?YaKaddFL7MAq2+PYuPOTRcOrIC5EgDgLBropexLEMsGYty5xiIEDDF6jahCr?= =?us-ascii?Q?UGrVzFJun3BqBa0HjrS4n/ysaR0DECeCoU4tGzbcmLxBDWALvjuKSm5nzgIH?= =?us-ascii?Q?7/ekQFD4pP9O1Wr8N5WD7+XAOkDzFKzIVGGPyHEFBUKHuhmY6TKt+d8+5/6z?= =?us-ascii?Q?ZDYGtL4tvJvhuVARyECcAp2xS10X0VerGp7g3xmqJun5zGQmZ/UyGAMdOFJD?= =?us-ascii?Q?e+6lEAlejynKLF6hJRRBUtvfd7kOfftSIgmUHcL2fURKf1CwRMCT?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6c8ac6bd-4afe-4575-2998-08dee2410371 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jul 2026 07:16:39.4594 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VL9Wm1LFbXyNPQSQkr+fHpCG48PRSA4Y37zJWj93E0NFLUjIclw8Aijkgvz9DG6uYQVUbLoi/QW1VxlrajiB0MuVBlBtBaWZsaEGRy6h8ZiOHpeed2EHig9/E4uPxbq+ X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB12197 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260715_001643_832329_E2EC8ABA X-CRM114-Status: GOOD ( 12.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Luke Wang Make pinctrl_pm_select_sleep_state() and mmc_gpio_set_cd_wake() failures non-fatal in the suspend path. These failures only mean slightly higher power consumption or missing CD wakeup capability, but should not block system suspend. Also change the function to always return 0 on the success path instead of propagating non-fatal warning return values. Fixes: 676a83855614 ("mmc: host: sdhci-esdhc-imx: refactor the system PM logic") Acked-by: Adrian Hunter Signed-off-by: Luke Wang --- drivers/mmc/host/sdhci-esdhc-imx.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c index 7818f351a58a..290a3172931b 100644 --- a/drivers/mmc/host/sdhci-esdhc-imx.c +++ b/drivers/mmc/host/sdhci-esdhc-imx.c @@ -2083,8 +2083,7 @@ static int sdhci_esdhc_suspend(struct device *dev) disable_irq(host->irq); if (device_may_wakeup(dev)) { - ret = sdhci_enable_irq_wakeups(host); - if (!ret) + if (!sdhci_enable_irq_wakeups(host)) dev_warn(dev, "Failed to enable irq wakeup\n"); } else { /* @@ -2095,12 +2094,12 @@ static int sdhci_esdhc_suspend(struct device *dev) * other function like GPIO function to save power in PM, * which finally block the SDIO wakeup function. */ - ret = pinctrl_pm_select_sleep_state(dev); - if (ret) - return ret; + if (pinctrl_pm_select_sleep_state(dev)) + dev_warn(dev, "Failed to select sleep pinctrl state\n"); } - ret = mmc_gpio_set_cd_wake(host->mmc, true); + if (mmc_gpio_set_cd_wake(host->mmc, true)) + dev_warn(dev, "Failed to enable cd wake\n"); /* * Make sure invoke runtime_suspend to gate off clock. @@ -2108,7 +2107,7 @@ static int sdhci_esdhc_suspend(struct device *dev) */ pm_runtime_force_suspend(dev); - return ret; + return 0; } static int sdhci_esdhc_resume(struct device *dev) -- 2.34.1