From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F0FFC44501 for ; Wed, 15 Jul 2026 14:28:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=it2bj0iHfY1ZsJXyOTWPHloFBQau6EPewPLcCaqCr3M=; b=Oqj3HuEkSUhQWlENC9wogNIWHG AdYSw0XqXxmI921HWaP1houkPG3/uULOWVBUCnrktQJlaNlcGP5BNGI2cT4D0lGAM9QJ9bs5kBT/2 HrfEeUxV4GyOmbx3UGHgrxRX/cvnQXA8n90wlvKGbzcZ2zwLWJ+KOpS9e8qtwQbOCrjPmIdIIjOni VwsXzqZth5sj88Qw9N39AdQhjnKS9WqAskjrp69hW+C3H8J2SXw/YcAXc8GVIKAtWyD5eL9gzWEUH kxZSfD9Ubopty6z5eA88tIO+eMhMT2Io0Uo+hGgEQ+LqTLAy/JeaH2zybyBE0RF9B9T50C7G424f1 8B8Is9tA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wk0bG-0000000F7XS-2yXO; Wed, 15 Jul 2026 14:28:38 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wk0b3-0000000F7Mq-3KpF for linux-arm-kernel@lists.infradead.org; Wed, 15 Jul 2026 14:28:27 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 833EC153B; Wed, 15 Jul 2026 07:28:20 -0700 (PDT) Received: from e122027.cambridge.arm.com (e122027.cambridge.arm.com [10.1.25.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4CEFD3F7B4; Wed, 15 Jul 2026 07:28:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784125704; bh=KZgZh+TlRITfiUhnLxGy5a8BYgDYUWfooEUpxGbDDgQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Zk/uGkjKFeQvrYAghMIb5a6cRiqHAfeUIh0RH/1zSkWsz8wxvNrRaGsUY2GLWYtdE YM9ZbeWn0ObkWjIlbRN+MCyIXOONeP1gRivHiO8WHumQ/LRFdkdij/KLDqQiI/dX3/ TmBOBBltC2n6bgKRAl1gErIzRBaOWvkYuoDuU8p4= From: Steven Price To: kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Steven Price , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , WeiLin.Chang@arm.com, Lorenzo Pieralisi Subject: [PATCH 6/6] firmware: arm_rmm: Ensure the RMM has GPT entries for memory Date: Wed, 15 Jul 2026 15:27:37 +0100 Message-ID: <20260715142739.80398-7-steven.price@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260715142739.80398-1-steven.price@arm.com> References: <20260715142739.80398-1-steven.price@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260715_072825_914026_1E4F0F16 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The RMM maintains the state of all the granules in the system to make sure that the host is abiding by the rules. This state can be maintained at different granularity, per page (TRACKING_FINE) or per region (TRACKING_COARSE). The region size depends on the underlying "RMI_GRANULE_SIZE". For a "coarse" region all pages in the region must be of the same state, this implies we need to have "fine" tracking for DRAM, so that we can delegate individual pages. For now we only support a statically carved out memory for tracking granules for the "fine" regions. This can be extended in the future to allow modifying the tracking granularity and remove the need for a static allocation. Similarly, the firmware may create L0 GPT entries describing the total address space. But if we change the "PAS" (Physical Address Space) of a granule then the firmware may need to create L1 tables to track the PAS at a finer granularity. Signed-off-by: Steven Price --- Changes since v14: * Move the implementation into drivers/firmware/arm_rmm. Changes since v13: * Moved out of KVM --- drivers/firmware/arm_rmm/rmi.c | 92 ++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) diff --git a/drivers/firmware/arm_rmm/rmi.c b/drivers/firmware/arm_rmm/rmi.c index 6a9f61760fd7..d0c083bdf251 100644 --- a/drivers/firmware/arm_rmm/rmi.c +++ b/drivers/firmware/arm_rmm/rmi.c @@ -12,6 +12,8 @@ #include #include +static bool arm64_rmi_is_available; + /* Currently only the first 2 registers are used by Linux */ #define RMI_FEAT_REG_COUNT 2 static __ro_after_init unsigned long rmi_feat_reg_cache[RMI_FEAT_REG_COUNT]; @@ -604,6 +606,89 @@ static int rmi_configure(void) return 0; } +/* + * Make sure the area is tracked by RMM at FINE granularity. + * We do not support changing the tracking yet. + */ +static int rmi_verify_memory_tracking(phys_addr_t start, phys_addr_t end) +{ + while (start < end) { + unsigned long ret, category, state, next; + + ret = rmi_granule_tracking_get(start, end, &category, &state, &next); + if (ret != RMI_SUCCESS || + state != RMI_TRACKING_FINE || + category != RMI_MEM_CATEGORY_CONVENTIONAL) { + /* TODO: Set granule tracking in this case */ + pr_err("Granule tracking for region isn't fine/conventional: %llx\n", + start); + return -ENODEV; + } + start = next; + } + + return 0; +} + +static int rmi_create_gpts(phys_addr_t start, phys_addr_t end) +{ + struct rmi_sro_state *sro; + unsigned long l0gpt_sz; + + sro = kmalloc_obj(*sro, GFP_KERNEL); + if (!sro) + return -ENOMEM; + + l0gpt_sz = 1UL << (30 + FIELD_GET(RMI_FEATURE_REGISTER_1_L0GPTSZ, + rmi_feat_reg(1))); + start = ALIGN_DOWN(start, l0gpt_sz); + end = ALIGN(end, l0gpt_sz); + + while (start < end) { + int ret = rmi_gpt_l1_create(start, sro, GFP_KERNEL); + + /* + * Make sure the L1 GPT tables are created for the region. + * RMI_ERROR_GPT indicates the L1 table already exists. + */ + if (ret != RMI_SUCCESS && RMI_RETURN_STATUS(ret) != RMI_ERROR_GPT) { + pr_err("GPT Level1 table missing for %llx\n", start); + kfree(sro); + return -ENOMEM; + } + start += l0gpt_sz; + } + + kfree(sro); + return 0; +} + +static int rmi_init_metadata(void) +{ + phys_addr_t start, end; + const struct memblock_region *r; + + for_each_mem_region(r) { + int ret; + + start = memblock_region_memory_base_pfn(r) << PAGE_SHIFT; + end = memblock_region_memory_end_pfn(r) << PAGE_SHIFT; + ret = rmi_verify_memory_tracking(start, end); + if (ret) + return ret; + ret = rmi_create_gpts(start, end); + if (ret) + return ret; + } + + return 0; +} + +bool is_rmi_available(void) +{ + return arm64_rmi_is_available; +} + static int __init arm64_init_rmi(void) { int ret; @@ -621,6 +706,13 @@ static int __init arm64_init_rmi(void) if (ret) return ret; + ret = rmi_init_metadata(); + if (ret) + return ret; + + arm64_rmi_is_available = true; + pr_info("RMI configured"); + return 0; } -- 2.43.0