From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1903C44507 for ; Fri, 17 Jul 2026 07:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uIIyMwAcqVkt+px899RrpC9+Fguty7npn2U4kEL+f9I=; b=AfEQrsgvL53oef6yeEbyf0114C oYgaRQcZMDqPdGfrC2YUzMB1CfAYDlL+CcONHG27ACc/X+Fn9ZZtzpnEdl5WeCT3jS/tZNxj7WYU3 h0o2s5zUwbEMbOfVMe3eUfg9IKDyWWHJ22uDKTjxG5p+n5SfEgLeUKYJd7ytEFv6quXk7q0vndpmQ he0gAxNHgfFSjzIIVgHxDEGA2bSWC8dsBrS6jLJPy3zaT3NMmlkLeVTPzh/foSTJmfFvxxisRR4FZ 6/egkRQnt3dxCwoDD0qzewC+H28o3cTZyYTm4MNpsl5/O8jSHnFExzoTGOEe5Z5GW88kOjCM0Succ Lyx7K+9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkcY9-00000001LOO-2cg1; Fri, 17 Jul 2026 06:59:57 +0000 Received: from flow-b4-smtp.messagingengine.com ([202.12.124.139]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wkcY7-00000001LMi-2qsk; Fri, 17 Jul 2026 06:59:56 +0000 Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailflow.stl.internal (Postfix) with ESMTP id AF23E13002E2; Fri, 17 Jul 2026 02:59:54 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-02.internal (MEProxy); Fri, 17 Jul 2026 02:59:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gahingwoo.com; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to; s=fm1; t=1784271594; x= 1784275194; bh=uIIyMwAcqVkt+px899RrpC9+Fguty7npn2U4kEL+f9I=; b=k bFlxD+e6niwqY1tiKSQgm/1EIA4GgO5TGNo3Ufd6/kR66jIfwM2fFGBj0koX5z5q Dism3PjcU68iYVHm+MwOHuFBeb/u+RCTAabsxKjmuwSU/lBFzXmR7zFaZhhjnQok WlGfSgKRv69HuNf7nAe1YWbUlS1H6FlTbomB0aUqS5vVkMUsxUY320wAc2pYlz17 Fpn3VFuSpAIm+v9mGCPFgWCCbtiAkcUxZb15EnoQihNu112G91b7MEDWQeSxabr5 jijsCmstZiNWbRrjKYyiz7h1q8zTPJgwvb79HxF2XhxwmN9uvZ3LdjMMmKjvRfme JT+9YSHaJhcAJn+Z7w1ng== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1784271594; x=1784275194; bh=u IIyMwAcqVkt+px899RrpC9+Fguty7npn2U4kEL+f9I=; b=BNKZlXH0gVneubIGH mFSun4XmlX1ytpbO6oONoaytREBXZ5TILPagxBvqFJjuFiljM3CdFT6Ycq9d0WsV A1NbxTPAaeyw4SEqr0Nq6msxm/ZWxrnkKrpJBoNH/fzCXXjeXZUgnDmiZ24gopvD ndrnswzJ5364Hfwkub3Jo+Km2/rU9DPEO3jvab9KMmZlMne5au17djpJf0BQyOSt I0XZEq+mg+nTuZ5GyimpRFQziTJPQTrqfEFgNX+bWWDOzy7pIneKRLDeuYpoPWS1 Qi3Y9wxNhX+2xOvKjEwW9wZp6i3PB93XdbSGP3NQHAxQFgiIRyQwEjExfO3zaVwr onxHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGLHoAYSuSv1o2npO99y2j4JkxLBJgWvGtMoWzVR091WtPJ1Xci9p6O9uorqIXytS qgiXLBX5pDi0cPzeDICNt6t/BjVh6mt6bhnC1C9CdJS3gO9mNnV/Rt+6btcqroSenMILop voSGMzPtXFidDk7Dp2YoPeT50jUo5Q3onDmNotbFDoLJF/D3BCYCo8e2eP7pyPHIz2TSZC jsi6aJHydnCg5nKTF+BekS20EeckpNO8KO0n0tfCCCM8qMgu4tlj8ReyNRU5j9Oz6Mh4EJ V2sIjpMsj8gCmoVqK3xuHwBHpYYmhbaxejpxfiWeEKyUfqC8zJxs1qeJl6zVpKllXpKBAI QmsQGq4Oe2fjIaSKONDkMpKaNQ/2YbfFu+2VjSH2vvfAged8qiT9ds2xi/eY8zrSKZo5Xg UiVX3GqojPDOBM5zZ44nwJ3/64hUfSF0NyO0S9a+k1v9yw3TIJYTc/GX/JoTQKYnQ8mI8d ZRrfCFDUtkEYgHzp5cp/a06g33DHbP+MqCfQqXKerG2CIgRGWJjesR2pQ5WwJuJMOJIbbP 8hDmdi8p4vh1jVXx/McSWsg8az8VLn1glcMKnFg8y+1I71PNsBw33mFvn9tgej2PaYXO66 orGyfrxUtH0EjJh49PqzjQoD+mJcjYaIbMqNePw3LkPCO/j1Nwx+Z5O5Q8qQ X-ME-Proxy: Feedback-ID: i7a5e4b5f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Jul 2026 02:59:49 -0400 (EDT) From: Jiaxing Hu To: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, heiko@sntech.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com Cc: netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, maxime.chevallier@bootlin.com, Jiaxing Hu Subject: [PATCH net-next v2 2/2] net: stmmac: dwmac-rk: enable the reference clock for output mode Date: Fri, 17 Jul 2026 18:59:33 +1200 Message-ID: <20260717065933.2629501-3-gahing@gahingwoo.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260717065933.2629501-1-gahing@gahingwoo.com> References: <20260717065933.2629501-1-gahing@gahingwoo.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260716_235955_755770_D65A232E X-CRM114-Status: GOOD ( 10.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org rk_gmac_clk_init() only requests the refout clock group for RMII. The ArmSoM CM5 has an on-module YT8531 RGMII PHY with no crystal that needs the SoC 25 MHz reference (clk_mac_refout), so in RGMII the clock was never enabled and the PHY did not respond on MDIO. Request the group whenever the SoC drives the clock (clock_in_out = "output"), not just for RMII. The clocks are optional, so other boards are unaffected. Signed-off-by: Jiaxing Hu --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 8d7042e68..dd060e4b8 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -1112,7 +1112,7 @@ static int rk_gmac_clk_init(struct plat_stmmacenet_data *plat) bsp_priv->clk_enabled = false; bsp_priv->num_clks = ARRAY_SIZE(rk_clocks); - if (phy_iface == PHY_INTERFACE_MODE_RMII) + if (phy_iface == PHY_INTERFACE_MODE_RMII || !bsp_priv->clock_input) bsp_priv->num_clks += ARRAY_SIZE(rk_rmii_clocks); bsp_priv->clks = devm_kcalloc(dev, bsp_priv->num_clks, @@ -1123,7 +1123,7 @@ static int rk_gmac_clk_init(struct plat_stmmacenet_data *plat) for (i = 0; i < ARRAY_SIZE(rk_clocks); i++) bsp_priv->clks[i].id = rk_clocks[i]; - if (phy_iface == PHY_INTERFACE_MODE_RMII) { + if (phy_iface == PHY_INTERFACE_MODE_RMII || !bsp_priv->clock_input) { for (j = 0; j < ARRAY_SIZE(rk_rmii_clocks); j++) bsp_priv->clks[i++].id = rk_rmii_clocks[j]; } -- 2.43.0