From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 04288C4450A for ; Sun, 19 Jul 2026 15:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Cc:To: Content-Transfer-Encoding:Content-Type:MIME-Version:Message-Id:Date:Subject: From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=I/LnTSHiKky2n5cLQsA/ffverxrdv8v0OCOhlGCMi5k=; b=nDdnktX9aNSdU5 KCuAAgrSQ3+kIuhJeoPM6a1TaYLOXNcHrpcr4C5jcHaFrIfhqWWlmh6F8oxktw+US2tNLR3YmjeJL pPbkwvQ6afHNDSQBNvGJXs4LvoRMGuwGqojn2WVzNwh/Te2/ad7El7l4xu5saaMFEvpjAj9feMLfK fjeu1welD2k2j5Jc1clm5iMYvWUyofQ2mmgVIj5qOkWzlo3sKdoWJriIL6m8QR+6FOccTlnucxFPg AWZqNeJUkavwTz/UKZ/i6Vrlf/zKzOtgT31KEen8FyxkTEahwPFmrOfxvYmanmQMrxAsmCf17cwNJ FZKBEuvOWdvkJBzlZ1nA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlTGd-000000056Hb-0jC2; Sun, 19 Jul 2026 15:17:23 +0000 Received: from mail-lf1-x130.google.com ([2a00:1450:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlTGa-000000056Gx-2rdQ for linux-arm-kernel@lists.infradead.org; Sun, 19 Jul 2026 15:17:22 +0000 Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-5b01cb18515so8909439e87.2 for ; Sun, 19 Jul 2026 08:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784474238; x=1785079038; darn=lists.infradead.org; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:from:to:cc:subject:date:message-id :reply-to:content-type; bh=I/LnTSHiKky2n5cLQsA/ffverxrdv8v0OCOhlGCMi5k=; b=TRpR3cDtk82nwTxZ8iG8bAgZzGk34nz61P6KDFJU09IdD+omGcEsICnIWHlXi3M1Hg NdBFkeXEl2XXlgmOBs1ehAIAqbfYw58YrwoMvsUUARYyXxb2iKrDxdt3J6x0pDN/uRzE mZkbFREXLDsR8ztVZVePPRLVWTS7hgitVUkV8J/ITcor1QGndEVU7vUpENYcon7OVC97 jVZxB+GvzC07wqpU6TKkzjy1rJxUweDu6NzbGINPn6244tdjbTvD08eNgJScFYAe6qNi 7xRMTLVnDRbeWUEWQf/NdM14n2RRBvMspTTceCKAUaQxnta+68G6oWZTJDf+kZFOf7fK e0IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784474238; x=1785079038; h=cc:to:content-transfer-encoding:content-type:mime-version :message-id:date:subject:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=I/LnTSHiKky2n5cLQsA/ffverxrdv8v0OCOhlGCMi5k=; b=lSWSDvvWcrJrIBA24SCEF3pWfQi7nCxRQgy8pxNEVoc02Mkf1Hv42cMeHbUhNC1HuF 0Th+D/tWexp7CrgmK2dcFmJcFhaXCp/eE9NIHkqMGi+eYZZcO/hU2ENqg5ecs/Ue33Hb Gwosp7SXhlqa/XfEoqYPW+4xGpH/WH0IL3NAH1aITn+EsmA5951MAvC0y+7tZHwS1OyU 5xvi1IJ9BBhgDFspYQl1e5xAYuH5rij/ZSc+kEVdXtVzzFtv+wxjBrceh6E3Es+Tt7Qp lPgjZvKGyfsLZA7xKA7gH+kmeRIs3s6q/2h4Nwc4AqqFmE0BhQd8Ni6H4rCwN0qRCk8F E8QA== X-Forwarded-Encrypted: i=1; AHgh+RoVukWC/XjY30M1QAXlqxcP+fBVI7mmQocPynrzwHrmoOex2PYlgpuNcFcX5eqlBut2i8QAwF8n/nY82YsTSqzg@lists.infradead.org X-Gm-Message-State: AOJu0YwepzrEAjtJ2ToN+C7qRRVtWgnaWwBfB03xuSHyWBbXzUi2FWv0 Wj+FlZMCLtDhvZVmZ22QMILbH5Col2rjPl01amQHV4rj0xv+EVGUJZSYic3ybxBK/W8= X-Gm-Gg: AfdE7clPqzUxyIrUO5shZ5II9dXR/5FF+Ve/3jIe75hzJ6yey/iNZ2red/lb/zhykFM 6N178u/ZoJAP8ozuc47Q2OOsqH391iMXUeyNQ7guZDVQckfpyr3nh8bNi1faKrW1H0ErA3/2Q2L zQGUWIi0aicwPN+0c+MHerubhZifnWv9IGrvi6GhzPSXXBFSVNABY4qRN1841nMpZJLY8jXLCpl jFSUbGiAbtaNIunlzXKm4giZQejK9CRCB+90exV5HUlh4xN4fUtSzhDcBK0BIj2QqeWmP7ueJCo ujmIQCWSFl3AEMKH9x6jDmOWoWUw5KDlR+kRDhdM8kiwNo6SlBk4uMGXDe/ZaVoFbhspw8t0rfY 21Gwzejo4jh5+LZpvl3QPimGWVD0+Wbl384+iei3KuQcu9mGwh+oR+h1gC9ouvXxESnCZxey5Hk a5RIimE7ulnOd+GUy1Xsfs8r8kVM6ZM5T66HIc5twli0IUsdA= X-Received: by 2002:ac2:4846:0:b0:5b2:8ad7:93b7 with SMTP id 2adb3069b0e04-5b28fabf50cmr1657172e87.53.1784474237928; Sun, 19 Jul 2026 08:17:17 -0700 (PDT) Received: from [192.168.1.135] (83-233-6-197.cust.bredband2.com. [83.233.6.197]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b291e26e5fsm1835096e87.80.2026.07.19.08.17.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Jul 2026 08:17:17 -0700 (PDT) From: Marcus Folkesson Subject: [PATCH v12 0/7] I2C Mux per channel bus speed Date: Sun, 19 Jul 2026 16:59:43 +0200 Message-Id: <20260719-i2c-mux-v12-0-a5010d623a57@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAAAAAAAC/2XSTU7DMBAF4KtUWRM0M/5nxT0QC3s8aS3RFiUQF VW9O24FjdUsPfL3/DTyuZtkLDJ1L5tzN8pcpnI81APS06bjXTxspS+5DjoCMhBQ9YW433+f+gR gVRaKonNXb3+OMpTTLertvZ53Zfo6jj+35Bmv078MonvGjD305DnoaBGCgtftPpaPZz7uu2vGT HeHAI2j6pIN3ljNORj76FTjCBanqgvgIxseahH16PS/s4DkF6eryyI6sJCzvOppFkfNjmZT3ZC I0xCCC2n1nm2dXZy99kxCXnjITlbONY6a91x1ws4kQu3Qx0fnF6dQL87feqJTPuo8wMqFxlHjQ nWGAiWw4EmveiIs0EGzUIQqIWSOoNhHNCuJjWxXitc/4yglHwcv4rmVl8vlFx27YNvTAgAA X-Change-ID: 20250913-i2c-mux-b0063de2ae4d To: Wolfram Sang , Michael Hennerich , Bartosz Golaszewski , Andi Shyti , Andy Shevchenko , Bartosz Golaszewski , Peter Rosin , Peter Rosin Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marcus Folkesson , Bartosz Golaszewski X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=6027; i=marcus.folkesson@gmail.com; h=from:subject:message-id; bh=bcWDFKcgyhIs5bog7jMtKo6/CTYa/LKbmtC2jB5pRu8=; b=owEBbQKS/ZANAwAKAYiATm9ZXVIyAcsmYgBqXOpwiRwuBmWCPUKepGUL76+q6Ng3w2ml+qoCd jxG142Efw+JAjMEAAEKAB0WIQQFUaLotmy1TWTBLGWIgE5vWV1SMgUCalzqcAAKCRCIgE5vWV1S MqVeD/99aADfF4PSI4PHuRo1pm5Bs7RjOmUroMsbXTA3Jprxg9xCJO9pA8aOjCqtWxomd5SvjwJ /3Gl3cJl3cxIiz3VIg4Vmu5BoR1IbEOCiGg68nzIqvbu8nKiln8WbDCpuBFK3BRXE7bsQpFvqEp tO0gkepp+n58aXP33KZ3hNMnlXb/yRdh0iCk1sWO8d4sWYihGf0d2l5JUxL3GtG0HZR1kWWbVLN 4c1H2Mag5vDQhGYI2OY/aRdYFV+E3CJU08qIXFVjxr0tEebr16H74U7jo6ltkQlCGvZwsX9M+sk 5H1uT3Cg/WZYuPEtWAmNvwV9hm1FC5Kp7iyAGuR6M63hjqI012zL6lkpVmFQqD1sEZyKfJYrzGa xN0Xs5PxkjpMB9b6JZZ59iQVl8GUXrx2W6GJ8xlJLEQy0apBz6scg5k8Ajnyz7MEhf2d5OEKJAH vC5BkWYtUE+EbbCASr1lqBmkrihQXVHYSr61gbMlPTEn0wbjJYxHfSqWtsie4ml1OfR0yc1M3la r1J0UJa2HoGAaOmpt4/JCmAzWCKELqqmQg6DXTm4Pj6mvciDOcsKOMhN1kpiAtNZXucPbBw7/SH tWW+S1QmsANk5f1V1OUqbljbQkSNLLqM9mry/QMRjKhMztKMR8t+xjfAfVinvjoKZa8Emjjw+F0 CR7Yz9uUWmZIlGQ== X-Developer-Key: i=marcus.folkesson@gmail.com; a=openpgp; fpr=AB91D46C7E0F6E6FB2AB640EC0FE25D598F6C127 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260719_081720_848768_B42D430E X-CRM114-Status: GOOD ( 24.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This was a RFC on how to implement a feature to have different bus speeds on different channels with an I2C multiplexer/switch. As no major complaints on the design came up during the review, I decided to submit the series without the RFC tag. The benefit with this feature is that you may group devices after the fastest bus speed they can handle. A real-world example is that you could have e.g. a display running @400kHz and a smart battery running @100kHz using the same I2C controller. There are many corner cases where this may cause a problem for some hardware topologies. I've tried to describe those I could think of in the documentation, see Patch #5. E.g. one risk is that if the mux driver does not disconnect channels when Idle, this may cause a higher frequency to "leak" through to devices that are supposed to run at lower bus speed. This is not only a "problem" for changing bus speed but could also be an issue for potential address conflicts. This patchset has been used and tested heavily the last months on a custom board based on a da850 (DaVinci) platform. The implementation is split up into several patches: Patch #1 Introduce a callback for the i2c controller to set bus speed Patch #2 Introduce functionality to adjust bus speed depending on mux channel. Patch #3 Cleanup i2c-davinci driver a bit to prepare it for set_clk_freq Parch #4 Implement set_clk_freq for the i2c-davinci driver Parch #5 Update documentation with this feature Signed-off-by: Marcus Folkesson --- Changes in v12: - Defined new idle states in i2c-mux.h - Replaced _hz with _Hz where appropriate - Reword comment and commit message about idle states - Link to v11: https://patch.msgid.link/20260713-i2c-mux-v11-0-72bb8af8ee8c@gmail.com Changes in v11: - Rebased on i2c-next - Use _Hz instead of _hz for local variables in i2c-davinci.c. - Link to v10: https://patch.msgid.link/20260708-i2c-mux-v10-0-09dca03c8a15@gmail.com Changes in v10: - Fix gramatics in documentation - Move {__,}i2c_adapter_set_clk_freq() to i2c-mux.c - Make set_clk_freq() return actual frequency - Reimplement idle_state (from earlier version) - Implement example on idle_state for ltc4306 - Link to v9: https://lore.kernel.org/r/20260324-i2c-mux-v9-0-5292b0608243@gmail.com Changes in v9: - Fix stray blank line - Link to v8: https://lore.kernel.org/r/20260314-i2c-mux-v8-0-fb1738a4df0a@gmail.com Changes in v8: - Fix gramatics and change %d to %u were appropriate - Link to v7: https://lore.kernel.org/r/20260223-i2c-mux-v7-0-ec75b214718a@gmail.com Changes in v7: - Remove code for finding first mux-locked ancestor - Introduce a unlocked (i2c_adapter_set_clk_freq) and unlocked (__i2c_adapter_set_clk_freq) variant - Let the locking be handled in __i2c_adapter_set_clk_freq - Use I2C_MAX_STANDARD_MODE_FREQ instead of magic numbers where appropriate - Link to v6: https://lore.kernel.org/r/20260216-i2c-mux-v6-0-9be28ecfd7e3@gmail.com Changes in v6: - Change logic to find which ancestor to lock with I2C_LOCK_ROOT_ADAPTER It now find the first mux-locked ancestor and then lock its parent. - Remove bus_freq_hz in i2c-davinci and only use clock_hz instead - Mention in commit message that clock_hz can be used to store frequency in an uniform way - Swap order for change freq/deselect to keep symmetry - Only allow bus frequency to be lowered in select() This to not allow an intermediate frequency to be set when it is not supposed to - check if(ret) instead of ret(<0) where appropriate - Fix typos in documentation - Change i2c_adapter.clock_hz from int to u32 - Simplify i2c_adapter_set_clk_freq() by removing 'ret' - Link to v5: https://lore.kernel.org/r/20260213-i2c-mux-v5-0-fb2cbf9979b3@gmail.com Changes in v5: - Take the lock of the top-most mutex locked mux to make sure that the root is locked - Link to v4: https://lore.kernel.org/r/20260128-i2c-mux-v4-0-dee49ce276c0@gmail.com Changes in v4: - Rebase on master - Swap order for printing warning about "channel %u is slower than parent on a non parent-locked mux\n" - Fix typo in comment, adaper->adapter - Link to v3: https://lore.kernel.org/r/20251020-i2c-mux-v3-0-908ac5cf9223@gmail.com Changes in v3: - Return -EINVAL if channel is faster than parent (kernel test robot) - Link to v2: https://lore.kernel.org/r/20251002-i2c-mux-v2-0-b698564cd956@gmail.com Changes in v2: - Changed bus_freq field to bus_freq_hz in davinci_i2c_dev (Bartosz Golaszewski) - Removed idle_state from mux core (Peter Rosin) - Link to v1: https://lore.kernel.org/r/20250922-i2c-mux-v1-0-28c94a610930@gmail.com To: Andi Shyti To: Peter Rosin To: Bartosz Golaszewski To: Michael Hennerich Cc: linux-i2c@vger.kernel.org Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- Marcus Folkesson (7): i2c: core: add callback to change bus frequency i2c: mux: add idle_state property to i2c_mux_core i2c: mux: add support for per channel bus frequency i2c: davinci: calculate bus freq from Hz instead of kHz i2c: davinci: add support for setting bus frequency i2c: mux: ltc4306: set correct idle_state in i2c_mux_core docs: i2c: i2c-topology: add section about bus speed Documentation/i2c/i2c-topology.rst | 178 ++++++++++++++++++++++++++++++++++++ drivers/i2c/busses/i2c-davinci.c | 35 +++++-- drivers/i2c/i2c-mux.c | 162 +++++++++++++++++++++++++++++--- drivers/i2c/muxes/i2c-mux-ltc4306.c | 3 + include/linux/i2c-mux.h | 30 ++++++ include/linux/i2c.h | 5 + 6 files changed, 392 insertions(+), 21 deletions(-) --- base-commit: 5489063ced8c6afdd1f4134a1a05a666b0834b31 change-id: 20250913-i2c-mux-b0063de2ae4d Best regards, -- Marcus Folkesson