From: Leo Yan <leo.yan@arm.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@arm.com>,
James Clark <james.clark@linaro.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jie Gan <jie.gan@oss.qualcomm.com>,
coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] coresight: dummy: add missing MODULE_DEVICE_TABLE()
Date: Mon, 20 Jul 2026 13:37:04 +0100 [thread overview]
Message-ID: <20260720123704.GC3998092@e132581.arm.com> (raw)
In-Reply-To: <20260720114514.51656-1-pengpeng@iscas.ac.cn>
On Mon, Jul 20, 2026 at 07:45:14PM +0800, Pengpeng Hou wrote:
> The CoreSight dummy driver has an OF match table wired into its platform
> driver, but does not export the table to module metadata. A modular build
> therefore lacks OF aliases for automatic loading.
>
> Export dummy_match with MODULE_DEVICE_TABLE().
>
> Fixes: 9d3ba0b6c056 ("Coresight: Add coresight dummy driver")
> Reviewed-by: Jie Gan <jie.gan@oss.qualcomm.com>
> Signed-off-by: Pengpeng Hou <pengpeng@iscas.ac.cn>
Reviewed-by: Leo Yan <leo.yan@arm.com>
> ---
> Changes since v1: https://lore.kernel.org/all/20260704121621.48544-1-pengpeng@iscas.ac.cn/
> - add the requested Fixes tag
> - carry Jie Gan's conditional Reviewed-by after making that change
> - rebase onto v7.2-rc4
>
> drivers/hwtracing/coresight/coresight-dummy.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-dummy.c b/drivers/hwtracing/coresight/coresight-dummy.c
> index c176a2f57300..04880d38feb7 100644
> --- a/drivers/hwtracing/coresight/coresight-dummy.c
> +++ b/drivers/hwtracing/coresight/coresight-dummy.c
> @@ -212,6 +212,7 @@ static const struct of_device_id dummy_match[] = {
> {.compatible = "arm,coresight-dummy-sink"},
> {},
> };
> +MODULE_DEVICE_TABLE(of, dummy_match);
>
> static struct platform_driver dummy_driver = {
> .probe = dummy_probe,
>
prev parent reply other threads:[~2026-07-20 12:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 11:45 [PATCH v2] coresight: dummy: add missing MODULE_DEVICE_TABLE() Pengpeng Hou
2026-07-20 12:37 ` Leo Yan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720123704.GC3998092@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=coresight@lists.linaro.org \
--cc=james.clark@linaro.org \
--cc=jie.gan@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@arm.com \
--cc=pengpeng@iscas.ac.cn \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox