From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Wayen Yan <win847@gmail.com>,
netdev@vger.kernel.org, horms@kernel.org, pabeni@redhat.com,
edumazet@google.com, andrew+netdev@lunn.ch,
angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net] net: airoha: fix HTB class modification offload
Date: Mon, 20 Jul 2026 14:49:43 -0700 [thread overview]
Message-ID: <20260720144943.0f4d1771@kernel.org> (raw)
In-Reply-To: <akthM-O5eea52MN6@lore-desk>
On Mon, 6 Jul 2026 10:02:59 +0200 Lorenzo Bianconi wrote:
> > HTB core does not populate parent_classid for TC_HTB_NODE_MODIFY.
> > Airoha currently checks parent_classid against TC_HTB_CLASSID_ROOT
> > in a helper shared by both TC_HTB_LEAF_ALLOC_QUEUE and
> > TC_HTB_NODE_MODIFY. Since the modify path leaves parent_classid as
> > zero, the check always fails and changing parameters of an already
> > offloaded HTB class is rejected with -EINVAL.
> >
> > Move the root-parent check into the allocation path and validate
> > modify requests using the per-netdev QoS channel bitmap, consistent
> > with the delete and query paths.
> >
> > Fixes: ef1ca9271313 ("net: airoha: Add sched HTB offload support")
> > Signed-off-by: Wayen Yan <win847@gmail.com>
>
> Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
ditto, please repost
prev parent reply other threads:[~2026-07-20 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 6:18 [PATCH net] net: airoha: fix HTB class modification offload Wayen Yan
2026-07-06 8:02 ` Lorenzo Bianconi
2026-07-20 21:49 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720144943.0f4d1771@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=win847@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox