From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8476C4452A for ; Mon, 20 Jul 2026 15:06:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A2sTffJ1ZiwupTetcfcyRy6Hq17YZeO9fnKxr3wzrZA=; b=LJoFAZVggSlRlGZQxwguzhzvrE ELhRoJySTwUcACN4+nbWGZ5MK4F2IDeNpmzkA+ZrYNjQSq3+/1U+yqqwzX1QfFejS2m5SJ3iN1A4M c7vz6xEr/bLMyeqz66NHf4R+Yjuv/ixGuInBbAnmkKN64aUT9b7LPit4oku6LoY9IMRqCtwW4taw7 CHngSdwxjhXmUmEz5rf4dKNzsFww6l2VVrR4y0RNL6HXGGVXE3ZOEePayk99K4Race3gxEjfFkWaS FOi0v1T94Karl9XRuur7RLju1PJB3zDwu2jmoij+UoN58nv87WJ68HOSfbrf7vqbHo5zgkgVFBNIK zNGDa+Ug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlpZP-000000074zc-1QkF; Mon, 20 Jul 2026 15:06:15 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wlpZL-000000074yc-3ldI for linux-arm-kernel@lists.infradead.org; Mon, 20 Jul 2026 15:06:13 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 51D76289; Mon, 20 Jul 2026 17:05:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1784559908; bh=kx2U3JzsAJE/W0InIkz6dN6aTr44P0qWHwoMKu4ZJ68=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bXYdBR+5FvG2b17Bc1D4J6FIL6CHtumZ4wPEVZMShKSWykoXKiyfHvqCbS55s/PTF pHHB7qyYt0BykwdCGAtjoE1rBL9qt0OiNR+pIw1PYattdRLbczEcUM5KdZFDLfI9Lh t/ojktcf4tAd2pLuBoOD1ZkVe9IrmFwiYWALWriQ= Date: Mon, 20 Jul 2026 18:06:05 +0300 From: Laurent Pinchart To: guoniu.zhou@oss.nxp.com Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Frank Li , Loic Poulain , Bryan O'Donoghue , Abel Vesa , Peng Fan , Michael Turquette , Stephen Boyd , imx@lists.linux.dev, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Guoniu Zhou , Krzysztof Kozlowski Subject: Re: [PATCH v13 1/3] media: dt-bindings: Add CSI Pixel Formatter DT bindings Message-ID: <20260720150605.GA27524@killaraus.ideasonboard.com> References: <20260720-csi_formatter-v13-0-4dc9a80e4cfd@oss.nxp.com> <20260720-csi_formatter-v13-1-4dc9a80e4cfd@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260720-csi_formatter-v13-1-4dc9a80e4cfd@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260720_080612_088259_DD5B804A X-CRM114-Status: GOOD ( 20.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Guoniu, Thank you for the patch. On Mon, Jul 20, 2026 at 05:59:46PM +0800, guoniu.zhou@oss.nxp.com wrote: > From: Guoniu Zhou > > The i.MX95 CSI pixel formatting module uses packet info, pixel and > non-pixel data from the CSI-2 host controller and reformat them to > match Pixel Link(PL) definition. > > Signed-off-by: Guoniu Zhou > Reviewed-by: Frank Li > Reviewed-by: Krzysztof Kozlowski Reviewed-by: Laurent Pinchart > --- > Changes in v11: > - Add Rb tags from Frank Li and Krzysztof Kozlowski > > Changes in v10: > - Drop syscon parent node from example > - Drop Reviewed-by tags from Frank and Krzysztof due to binding changes > - Add description for reg property > - Add space after formatter@20 before opening brace in example > - Enhance the port description with more detailed information > - Delete the blank line immediately following the endpoint in example > > Changes in v9: > - Use direct node instead of syscon wrapper in example > > Changes in v8: > - Use standard port reference instead of video-interfaces.yaml > - Add parent syscon node in example to show device integration > - Add required constraints for port@0 and port@1 in ports node > > Changes in v7: > - Change compatible to imx95-csi-formatter as IP is i.MX95 specific per Marco's suggestion > Link: https://lore.kernel.org/linux-media/20260511-csi_formatter-v6-0-01028e312e2b@oss.nxp.com/T/#mcd135b3de179b3cb69daa1fd6e0e8e27c85b3332 > --- > .../bindings/media/fsl,imx95-csi-formatter.yaml | 88 ++++++++++++++++++++++ > 1 file changed, 88 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml b/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml > new file mode 100644 > index 000000000000..58c4e1cc056b > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/fsl,imx95-csi-formatter.yaml > @@ -0,0 +1,88 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/fsl,imx95-csi-formatter.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX95 CSI Pixel Formatter > + > +maintainers: > + - Guoniu Zhou > + > +description: > + The CSI pixel formatting module found on i.MX95 uses packet info, pixel > + and non-pixel data from the CSI-2 host controller and reformat them to > + match Pixel Link(PL) definition. > + > +properties: > + compatible: > + const: fsl,imx95-csi-formatter > + > + reg: > + maxItems: 1 > + description: Register offset and size within the parent syscon > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Input port, connects to MIPI CSI-2 receiver output (IDI interface) > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port, connects to ISI input via Pixel Link (PL) > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - clocks > + - power-domains > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + > + formatter@20 { > + compatible = "fsl,imx95-csi-formatter"; > + reg = <0x20 0x100>; > + clocks = <&cameramix_csr IMX95_CLK_CAMBLK_CSI2_FOR0>; > + power-domains = <&scmi_devpd 3>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + endpoint { > + remote-endpoint = <&mipi_csi_0_out>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + endpoint { > + remote-endpoint = <&isi_in_2>; > + }; > + }; > + }; > + }; -- Regards, Laurent Pinchart