From: Krzysztof Kozlowski <krzk@kernel.org>
To: Simon Glass <sjg@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Fabio Estevam <festevam@nabladev.com>,
devicetree@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Bartosz Golaszewski <brgl@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Michael Riesch <michael.riesch@collabora.com>,
Rob Herring <robh@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Yao Zi <ziyao@disroot.org>, huang lin <hl@rock-chips.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/6] dt-bindings: soc: rockchip: grf: Add RV1106 compatibles
Date: Tue, 21 Jul 2026 10:16:33 +0200 [thread overview]
Message-ID: <20260721-didactic-tan-dodo-112ffc@quoll> (raw)
In-Reply-To: <20260714193656.2196447-4-sjg@chromium.org>
On Tue, Jul 14, 2026 at 01:36:40PM -0600, Simon Glass wrote:
> Add the compatibles for the general register files of the Rockchip
> RV1106: the main GRF, and the per-bank GPIO IOC blocks used by the pin
> controller.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2:
> - Drop the grf-cru clock-controller child and use the syscon-only
> group for the main GRF, since the CRU now provides the MMC phase
> clocks
> - Use a single gpio-ioc compatible for the per-bank IOC blocks in
> place of the ioc and pmuioc regions
>
> Documentation/devicetree/bindings/soc/rockchip/grf.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> index 2cc43742b8e3..fd9235ac1334 100644
> --- a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml
> @@ -64,6 +64,8 @@ properties:
> - rockchip,rk3588-vo1-grf
> - rockchip,rk3588-vop-grf
> - rockchip,rv1103b-ioc
> + - rockchip,rv1106-gpio-ioc
And this also answers my previous email (pinctrl/gpio bank): you have
one GPIO IOC, not multiple ones, although commit msg tells different
story. Confusing. The compatible here defines register layout (see
writing bindings - it is explicitly documented there) so do you have one
device or multiple with the same register layout?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-21 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 19:36 [PATCH v2 0/6] Add support for the Rockchip RV1106 and RV1103 Simon Glass
2026-07-14 19:36 ` [PATCH v2 1/6] dt-bindings: clock: rockchip: Add RV1106 CRU support Simon Glass
2026-07-14 19:36 ` [PATCH v2 2/6] clk: rockchip: Add clock controller for the RV1106 Simon Glass
2026-07-21 23:20 ` Brian Masney
2026-07-14 19:36 ` [PATCH v2 3/6] dt-bindings: soc: rockchip: grf: Add RV1106 compatibles Simon Glass
2026-07-21 8:16 ` Krzysztof Kozlowski [this message]
2026-07-21 12:30 ` Heiko Stübner
2026-07-14 19:36 ` [PATCH v2 4/6] ARM: dts: rockchip: Add support for RV1106 and RV1103 Simon Glass
2026-07-14 19:36 ` [PATCH v2 5/6] dt-bindings: arm: rockchip: Add Luckfox Pico Mini B Simon Glass
2026-07-14 19:36 ` [PATCH v2 6/6] ARM: dts: " Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260721-didactic-tan-dodo-112ffc@quoll \
--to=krzk@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@nabladev.com \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@collabora.com \
--cc=robh@kernel.org \
--cc=sjg@chromium.org \
--cc=vkoul@kernel.org \
--cc=ziyao@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox