From: Pan Chuang <panchuang@vivo.com>
To: Linus Walleij <linusw@kernel.org>, Imre Kaloz <kaloz@openwrt.org>,
linux-arm-kernel@lists.infradead.org (moderated list:ARM/INTEL
IXP4XX ARM ARCHITECTURE),
linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH v2] soc: ixp4xx: Remove redundant dev_err()
Date: Wed, 22 Jul 2026 10:35:18 +0800 [thread overview]
Message-ID: <20260722023523.42269-2-panchuang@vivo.com> (raw)
In-Reply-To: <20260722023523.42269-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/soc/ixp4xx/ixp4xx-qmgr.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/soc/ixp4xx/ixp4xx-qmgr.c b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
index 475e229039e3..6e1fca630b80 100644
--- a/drivers/soc/ixp4xx/ixp4xx-qmgr.c
+++ b/drivers/soc/ixp4xx/ixp4xx-qmgr.c
@@ -421,19 +421,13 @@ static int ixp4xx_qmgr_probe(struct platform_device *pdev)
err = devm_request_irq(dev, irq1, handler1, 0, "IXP4xx Queue Manager",
NULL);
- if (err) {
- dev_err(dev, "failed to request IRQ%i (%i)\n",
- irq1, err);
+ if (err)
return err;
- }
err = devm_request_irq(dev, irq2, handler2, 0, "IXP4xx Queue Manager",
NULL);
- if (err) {
- dev_err(dev, "failed to request IRQ%i (%i)\n",
- irq2, err);
+ if (err)
return err;
- }
used_sram_bitmap[0] = 0xF; /* 4 first pages reserved for config */
spin_lock_init(&qmgr_lock);
--
2.34.1
next prev parent reply other threads:[~2026-07-22 2:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 2:35 [PATCH v2] soc: fsl: dpio: Remove redundant dev_err() Pan Chuang
2026-07-22 2:35 ` Pan Chuang [this message]
2026-07-22 2:35 ` [PATCH v2] soc: mediatek: mtk-svs: Remove redundant dev_err_probe() Pan Chuang
2026-07-22 2:35 ` [PATCH v2] soc: ti: wkup_m3_ipc: Remove redundant dev_err() Pan Chuang
2026-07-22 13:10 ` Nishanth Menon
2026-07-23 2:34 ` Pan Chuang
2026-07-22 2:35 ` [PATCH v2] soc: xilinx: " Pan Chuang
2026-07-22 13:14 ` Michal Simek
2026-07-23 2:09 ` Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722023523.42269-2-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=kaloz@openwrt.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox