From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 475C7C4453A for ; Wed, 22 Jul 2026 22:00:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1yt0WgvKT27v4eREUBs6jn/NX4CYQFhNSkUReMZx1fo=; b=pk2svlsLrgnIwKiYPFGXU9OYPi 0qmaf1Z5NSi4uNZ//Vp3E6fGjaJHZ9yln6GatP7nGYmyqIIxw56UT1/vg1iALA6Hav9qT0F68SZll VjIePWenPEaQAfAQsAitnIOKdFx6UitvwIHIsz1Yj5y3w5GH0dR/uYVJySHkb0HAFxcAmiw2JDvSX +ZiKZlmK+UFDZo9aeHAl440TV79tYBSN85Lf5+kGdi+TeeN/4hk7GiUKDPX8SfNseYbwqdCXWffbw KLVWlXESENWA9KOkI8G4PkYS9s8/8JiK5HDyj7kZT54EvxznKlYSvBt8LNy4wA3iRKyRgQ3Rl6UXX 4/TcrR9A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmezl-0000000Cs6m-0RrK; Wed, 22 Jul 2026 22:00:53 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmezi-0000000Cs5r-1Mqu for linux-arm-kernel@lists.infradead.org; Wed, 22 Jul 2026 22:00:52 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4BB981595; Wed, 22 Jul 2026 15:00:43 -0700 (PDT) Received: from ryzen.lan (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 869EB3F66F; Wed, 22 Jul 2026 15:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784757647; bh=3MvGD1eFKe1vEcFRnSpsEpa0JYSXdYF12OcBVgaAJiU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DQelirpGLPKsacn9h+egBlDB6+GT1AZD7LVjwqMTd3idUcsZvgDYICoe/gUxKIqCK s6ZXmpdcAHCbOExSqv7gGQiIgYeecP4lSpCG3FFz4vxwglYSPa13gxgOLJtmN6I6fz hdgoCzSVUFfQHN739oMqQilKLOdMDAa7q24D4hr4= Date: Wed, 22 Jul 2026 23:56:48 +0200 From: Andre Przywara To: Justin Suess Cc: Sean Young , Mauro Carvalho Chehab , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maxime Ripard , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Sashiko Subject: Re: [PATCH v2 2/3] arm64: dts: allwinner: a523: add IR receiver nodes Message-ID: <20260722235648.40350459@ryzen.lan> In-Reply-To: <20260722201717.2205609-3-utilityemal77@gmail.com> References: <20260722201717.2205609-1-utilityemal77@gmail.com> <20260722201717.2205609-3-utilityemal77@gmail.com> Organization: Arm Ltd. X-Mailer: Claws Mail 4.4.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260722_150050_540295_015B58D7 X-CRM114-Status: GOOD ( 20.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 22 Jul 2026 16:17:16 -0400 Justin Suess wrote: Hi Justin, thanks for the update! > The A523 has two CIR receivers, both compatible with the A31 CIR: one > in the CPUX domain, clocked from the main CCU, and one in the RTC > power domain, clocked from the R-CCU. > > Add nodes for both instances, disabled by default. Since the RX signal > of each instance can be routed to more than one pin, boards with an IR > receiver are expected to add the pinctrl properties next to where they > enable the node. Keep the PL11 pin description in the dtsi, as boards > commonly use that pin for the RTC domain instance. > > Cc: Andre Przywara > Signed-off-by: Justin Suess I compared the values against the manual, and can confirm that they match. Also tested both interfaces. Just one nit below, but regardless: Reviewed-by: Andre Przywara > --- > .../arm64/boot/dts/allwinner/sun55i-a523.dtsi | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > index ca6a16807049..19771aac68e5 100644 > --- a/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > +++ b/arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi > @@ -327,6 +327,17 @@ ccu: clock-controller@2001000 { > #reset-cells = <1>; > }; > > + ir: ir@2005000 { > + compatible = "allwinner,sun55i-a523-ir", > + "allwinner,sun6i-a31-ir"; > + reg = <0x02005000 0x400>; > + interrupts = ; > + clocks = <&ccu CLK_BUS_IR_RX>, <&ccu CLK_IR_RX>; > + clock-names = "apb", "ir"; > + resets = <&ccu RST_BUS_IR_RX>; > + status = "disabled"; > + }; > + > ledc: led-controller@2008000 { > compatible = "allwinner,sun55i-a523-ledc", > "allwinner,sun50i-a100-ledc"; > @@ -927,6 +938,23 @@ r_i2c_pins: r-i2c-pins { > allwinner,pinmux = <2>; > function = "r_i2c0"; > }; > + > + r_ir_rx_pin: r-ir-rx-pin { > + pins = "PL11"; > + allwinner,pinmux = <2>; > + function = "s_cir"; I think the function name should be "s_cir_rx", as there are IR TX pins as well. And we used "{s_,}[c]ir_rx" for previous SoCs already. Cheers, Andre > + }; > + }; > + > + r_ir: ir@7040000 { > + compatible = "allwinner,sun55i-a523-ir", > + "allwinner,sun6i-a31-ir"; > + reg = <0x07040000 0x400>; > + interrupts = ; > + clocks = <&r_ccu CLK_BUS_R_IR_RX>, <&r_ccu CLK_R_IR_RX>; > + clock-names = "apb", "ir"; > + resets = <&r_ccu RST_BUS_R_IR_RX>; > + status = "disabled"; > }; > > pck600: power-controller@7060000 {