From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B96DC531F9 for ; Fri, 24 Jul 2026 08:44:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qjG3+Srh1l1zMMK/k1OHJ2IZC5GaA1LItCzYqUBfaa0=; b=1DcLV4+WV189vrvWIkhqRt2E+E vLYMBmcypXqE22+haxMUBTK6th8/9S7lWrmFHeOOnfacLVxuuV1FsEMh3O6/2vtSV9o36lP56X8Sk LwReaZEPcg3Xv+qp49VU0jwJDoeWvZIY46Ot37CWAC/0Gj0h+OXwW36+Wuj6xK/LEDiEYU4QZbet4 P2NlBO/jjDIDDrEcYOmYC98ahflxqVDiKaZ+twQhmNA9PHPLKYF+JWLIf7SAAcg+a1gZXz/wa0sbQ aGHuTy0ybQNOJ3g6EP3gtQvNzYml+QIR5O3W4LHr7K5NNVATHJdjAoIkKm4F3GpP24bP8mnUz0Uei 9I2A2ddg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnBWM-0000000Fqp1-41zV; Fri, 24 Jul 2026 08:44:42 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnBW9-0000000Fqf1-3G2x for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2026 08:44:31 +0000 Received: by mail-pj1-x1034.google.com with SMTP id 98e67ed59e1d1-38e07ebd263so94501a91.1 for ; Fri, 24 Jul 2026 01:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1784882669; x=1785487469; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qjG3+Srh1l1zMMK/k1OHJ2IZC5GaA1LItCzYqUBfaa0=; b=niqVoCNCb4miM6Idg5lVXjzOnFwsAWNkrJMmtumFuROlKw+JQkSG3xFX1mo+3AWkw2 0Eh6POCc5uQjZaDWzVFzV3h9pQII6vMgTevbMxEn4fqtiJlsP1iwNpZlwhB1QnSFHsAp 6iimy8foYpEFNyOLq/wqyChnT/jDtTkcHgusE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784882669; x=1785487469; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=qjG3+Srh1l1zMMK/k1OHJ2IZC5GaA1LItCzYqUBfaa0=; b=WaGvi2eY4/m6maPE03OOXtcPBdbXpn3O4ZohhYWUsV57nIMsP0gumvE0d/C7Ji8y4g YXyzpXz1siNR0R+qjBeYW4q8pd43LLQpqVEQegnPaYgD4ge0UGPH6ev31HeL4QYs6fi+ cp+41XkbNZ6jzjrDTHzWNqvxMRm4P07GEOdIgzJ7EWm3d2KdpXE/hGSvyy1s+JGfDSPs GMUXAvDeV8jNSA70Zkw+OjMfBOmXx9Jq9l4512m1aHr+dA6i7nC7F6vImj/rr72E7B3Y 6a/Bdec9BcusOSlhmr3oeKmlis7jaErHM892D9yAZhtGH0wRM395xhibHXCrLjqXmCvS S/2Q== X-Forwarded-Encrypted: i=1; AHgh+RqTihwf/UWH5EqJYCPuIDu4umM7gfkIPotp/2EB6eWt0DFYwdQ/8SZPugIUsBuAkZcU+lkFDp34SqvRALKZAj/s@lists.infradead.org X-Gm-Message-State: AOJu0YyygxCL4A+z1aEvyZ6SDPp9dcuiu0pIslokj8P4PiCyV3AdlzIG MO8DtH3zy4zha8UrufCqLQYed1HMczuCaUEDAswcRwkyXAM/Kk+T78/SlkR8GZeq9w== X-Gm-Gg: AR+sD10vJgRX9BqfiBdezdBSm/s/Pzk8uzT8iEmRy9FSAcxdvUAEf+H8QDuVlhSZrGT EzrF5tAt9QAH2yg4FduNcG9YnPMgDC80IWLzFCRYAAB9nzF+dyhM8oewTZY8F3GFV0nnBb5NW6Q ybYUcGWC9rzDf6AW16fWXTxgiV/L6kSbKutPoDvRn5B6+vjO9bXo1Xu1vYWsg7Uxk3fMxNL5GXA uqVYjfMtXxCgu0TCP2t4XARC2U4qBxe0zuiBMajry2LHiOOXgtjH4vtbZnu45HqhHSE+OAawEok f7T21mrOdwwTuSFMCyFgyCrLNR5GgS0pBJ2jB20ghA51xBAgyUGS3DsYphMLuDuDrnJOJE8HAkQ zL1sfu/4oVVjl3NbSPCDZ7KX9GPrQDtSGExzZTiVZit1PP32pvDRoXUp/1MYuhUJ0zUovwJeygO hs9lXTYSm0nkvyBU2sNnK849OacKmyLWu2KnV0U7FWSN7J9fielwD48peYfBI= X-Received: by 2002:a17:90b:2e03:b0:38f:1f8:1fa with SMTP id 98e67ed59e1d1-38f01f802b5mr3474310a91.15.1784882669036; Fri, 24 Jul 2026 01:44:29 -0700 (PDT) Received: from wenstp920.tpe.corp.google.com ([2a00:79e0:201d:8:f131:86cc:5858:7325]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f089ac6d8sm434546a91.2.2026.07.24.01.44.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 01:44:28 -0700 (PDT) From: Chen-Yu Tsai To: Bartosz Golaszewski , Greg Kroah-Hartman , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , "Rafael J. Wysocki" , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno Cc: Wei Deng , Chen-Yu Tsai , linux-acpi@vger.kernel.org, driver-core@lists.linux.dev, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , Alan Stern , Bartosz Golaszewski Subject: [PATCH v7 05/16] usb: hub: Return actual error from hub_configure() in hub_probe() Date: Fri, 24 Jul 2026 16:43:14 +0800 Message-ID: <20260724084328.3943997-6-wenst@chromium.org> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog In-Reply-To: <20260724084328.3943997-1-wenst@chromium.org> References: <20260724084328.3943997-1-wenst@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260724_014429_871706_017FC6AD X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The addition of power sequencing descriptor handling in the USB hub code requires dealing with deferred probing from pwrseq_get(). The power sequencing provider may not yet be available when the USB hub probes. Return the actual error code from hub_configure() when it fails, so that the driver core can notice the deferred probe request. Also rewrite this section into the standard error handling pattern: if (error) { # handle error return error; } # do more work return 0; Reviewed-by: Bartosz Golaszewski Reviewed-by: Andy Shevchenko Signed-off-by: Chen-Yu Tsai --- Changes since v2: - Rewrite into standard error handling pattern Changes since v1: - Moved "int ret" declaration in hub_configure() over here from the next patch --- drivers/usb/core/hub.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index 715f26f05a31..8f8624a0d36a 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1875,6 +1875,7 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) struct usb_host_interface *desc; struct usb_device *hdev; struct usb_hub *hub; + int ret; desc = intf->cur_altsetting; hdev = interface_to_usbdev(intf); @@ -2006,14 +2007,15 @@ static int hub_probe(struct usb_interface *intf, const struct usb_device_id *id) usb_set_interface(hdev, 0, 0); } - if (hub_configure(hub, &desc->endpoint[0].desc) >= 0) { - onboard_dev_create_pdevs(hdev, &hub->onboard_devs); - - return 0; + ret = hub_configure(hub, &desc->endpoint[0].desc); + if (ret < 0) { + hub_disconnect(intf); + return ret; } - hub_disconnect(intf); - return -ENODEV; + onboard_dev_create_pdevs(hdev, &hub->onboard_devs); + + return 0; } static int -- 2.55.0.229.g6434b31f56-goog