From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5AF7C531C9 for ; Sat, 25 Jul 2026 11:37:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wig+0XIfRY0W21VeVW18yyn6ePyyTMXktBSzXCeMhuY=; b=uMjp6AC2ZxowXaQ6CN/7hg/W9N YJj7YvH/AWRjbImX/4Xp0nWFOMru0Dg+eWV8rw+cb2fEFrY98SxLNGQ+OilpJMJK9BvkUz0BaECsL +Tgq6z+9FnH55S9HEKXbJAj49nVOnRrsmEqOXZhsggrEDCsRNAKlPlie4YUYkyIFrU6tq8Mxg3qch xqDRIzI6EUHe8ZGeMF6/iae6O2CGKGFmKzbrcqS/s2eCVlbSMb3nvNlUXhEhy8i6rDDE+F/VtRsa8 wc8wI7krT34FxmigieBITLSYh9dLnTeJlE8wPnWATIoHafqBiveeP4xElI9wqslOdSH0nJ2ldf+4M ZP31x3OQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnagm-00000000IEK-1k9O; Sat, 25 Jul 2026 11:37:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnagj-00000000ID1-2C0N for linux-arm-kernel@lists.infradead.org; Sat, 25 Jul 2026 11:37:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 634AF1476; Sat, 25 Jul 2026 04:36:58 -0700 (PDT) Received: from e129823.cambridge.arm.com (e129823.arm.com [10.2.213.3]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 100693F86F; Sat, 25 Jul 2026 04:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1784979422; bh=08jMdtod7Ir4RxqBmMzY3RvBdF+D2iKjLfEjJc2o1Go=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S9qci7mYedvhvRtSBerQHnwoFSG5TF+D7QRExnCf53c/OdCSQcqLCv+D1DF2/NPDP nzttSkLwajCEaRV1JS7rgNKL8WPs/f1zX+vMF57Mm82Jr0MZ7jhsUghPyBqJ7tZrPw yjSwTola15PJnl+LZQTkV3QSH1toxQnitdOaGHqk= From: Yeoreum Yun To: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: suzuki.poulose@arm.com, mike.leach@arm.com, james.clark@linaro.org, alexander.shishkin@linux.intel.com, leo.yan@arm.com, jie.gan@oss.qualcomm.com, Yeoreum Yun Subject: [PATCH v9 03/13] coresight: etm4x: fix leaked trace id Date: Sat, 25 Jul 2026 12:36:35 +0100 Message-ID: <20260725113645.57519-4-yeoreum.yun@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260725113645.57519-1-yeoreum.yun@arm.com> References: <20260725113645.57519-1-yeoreum.yun@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260725_043706_200842_A4359767 X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If etm4_enable_sysfs() fails in cscfg_csdev_enable_active_config(), the trace ID may be leaked because it is not released. To address this, call etm4_release_trace_id() when etm4_enable_sysfs() fails in cscfg_csdev_enable_active_config(). Fixes: 7ebd0ec6cf94 ("coresight: configfs: Allow configfs to activate configuration") Reviewed-by: Jie Gan Reviewed-by: Leo Yan Signed-off-by: Yeoreum Yun --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c b/drivers/hwtracing/coresight/coresight-etm4x-core.c index 1884960cfe6f..8363c55b3952 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x-core.c +++ b/drivers/hwtracing/coresight/coresight-etm4x-core.c @@ -920,8 +920,10 @@ static int etm4_enable_sysfs(struct coresight_device *csdev, struct coresight_pa cscfg_config_sysfs_get_active_cfg(&cfg_hash, &preset); if (cfg_hash) { ret = cscfg_csdev_enable_active_config(csdev, cfg_hash, preset); - if (ret) + if (ret) { + etm4_release_trace_id(drvdata); return ret; + } } raw_spin_lock(&drvdata->spinlock); -- LEVI:{C3F47F37-75D8-414A-A8BA-3980EC8A46D7}