From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77B72C54F4C for ; Tue, 28 Jul 2026 14:29:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:CC:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UAo0uqSG7n/cT28ANLDuD/7yiX6B3x9r3UDLW6fTeoU=; b=fiGk3bTlSyFtk56bfvty1Z2wbb rHz+CH5wiTWaf50xC7BDQQW+6UlB0hgGBtuaPEYppq1yW6Bz9rIFRNgmgL5j6OWHOeRY/6YXIHY8n x8N/Vr3YV4bqbq8tFJGWXm8biS0T6a8L/Wbbi7M0QrBLq/xJJYb0fnBmoT6zvf7CmxPK2674nRiGv fQYlFmuy4QtBFVr67UbcxI/yexzsQ+K2SAJ7A2EqpQOlLI9NfRRGGr5OpggFUtJs1E05fEEwpQ3Wm M1tYYsP7Bukc/78EuN8dR4ysGKx9LrpzvMmVgV0JT8K/0/cuWHnNaO7B7ibRweoVcvxkEKhwRwv0H YObqL7dg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1woinv-00000005TxR-1xVo; Tue, 28 Jul 2026 14:29:11 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1woinu-00000005Tx1-0pt4; Tue, 28 Jul 2026 14:29:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:Content-Transfer-Encoding :MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=UAo0uqSG7n/cT28ANLDuD/7yiX6B3x9r3UDLW6fTeoU=; b=Gch54CLE45f48TFVO2qDXPs+k/ +zJVs9IIwXrxPlmNP2EV1LXSQCRjaN/5hM24o34y1XFnZiPHk/8en8D3c8IZvOwt/pcBE/zjciFMG P6/ZX0BcbiDCn3plLbwZxe0E1WBFBTWax+mNPxyffvTRCPhbaGgt+fCImW+DOrFL1Sg/BbXAMK3/x e479+x6D2GvGa6ZWl2v3fNpPBXmfrpSDma5fDCbkWnsY4U8Y493UEdgHufFMak9i9a4DPPsNNQXNc jEEhkeby4ByML+yYwZoJGyXDCRemjqMDMFTbFZvG3Tp8a2c8zJdwTC2ce0Jmh7YmWJF9PGJO6rDJ0 L9wViPhQ==; Received: from rtits2.realtek.com ([211.75.126.72] helo=rtits2.realtek.com.tw) by desiato.infradead.org with esmtps (Exim 4.99.2 #2 (Red Hat Linux)) id 1woinq-000000051Ah-1IVa; Tue, 28 Jul 2026 14:29:08 +0000 X-SpamFilter-By: ArmorX SpamTrap 5.80 with qID 66SES60x83929832, This message is accepted by code: ctloc85258 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=realtek.com; s=dkim; t=1785248886; bh=UAo0uqSG7n/cT28ANLDuD/7yiX6B3x9r3UDLW6fTeoU=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding:Content-Type; b=LNc2Fo0kN2PeA9cW8+Fo23wY5J+pKuj0+U//b4TK9U+F/r2cD7+eCVi9F++MZKcUb oMeki76BILcEi7BG0G7YlJlgQyS7YoaFWJieYXc42Wbc/8B2hFcugcxO2bDyh6SFqi cZ+erWOF2rnLhttA74fnOshKgwNYTO6Vsh5ZWD15DWmAhJ6AJ3j+TDocPFevdmEL9C kgZoM7GPDfFe9e8yUt4+tb8RmgxW9kzcs48HHDgjfCIQyE83GaJKKbixPciV/UWRvR HXpqzze19CGZlAa1LgkMthtjBkLIJkpWVbYVGPgw+NpaqHkJ4VQ+aro7WY3StDTUwD myy05+u51wa6A== Received: from mail.realtek.com (rtkexhmbs03.realtek.com.tw[10.21.1.53]) by rtits2.realtek.com.tw (8.15.2/3.29/5.94) with ESMTPS id 66SES60x83929832 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 Jul 2026 22:28:06 +0800 Received: from RTKEXHMBS05.realtek.com.tw (10.21.1.55) by RTKEXHMBS03.realtek.com.tw (10.21.1.53) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Tue, 28 Jul 2026 22:28:06 +0800 Received: from cn1dhc-k02 (172.21.252.101) by RTKEXHMBS05.realtek.com.tw (10.21.1.55) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Tue, 28 Jul 2026 22:28:06 +0800 From: Yu-Chun Lin To: , , , , , , , , CC: , , , , , , , , , Subject: [PATCH v11 02/11] reset: Add Realtek basic reset support Date: Tue, 28 Jul 2026 22:27:57 +0800 Message-ID: <20260728142806.1954638-3-eleanor.lin@realtek.com> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20260728142806.1954638-1-eleanor.lin@realtek.com> References: <20260728142806.1954638-1-eleanor.lin@realtek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260728_152907_030842_2A27D8F6 X-CRM114-Status: GOOD ( 18.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Cheng-Yu Lee Define the common reset operations backed by a regmap-based register interface for Realtek SoCs. This library exports the standard reset control operations (assert, deassert, and status) to be utilized by other specific Realtek reset drivers. The implementation supports handling an optional write-enable bit required by certain Realtek reset controllers. Reviewed-by: Philipp Zabel Signed-off-by: Cheng-Yu Lee Co-developed-by: Yu-Chun Lin Signed-off-by: Yu-Chun Lin --- Changes in v11: - Update the commit message and Kconfig description. - Remove unused header and add the header I use. - Add Reviewed-by tag from Philipp. --- MAINTAINERS | 1 + drivers/reset/Kconfig | 1 + drivers/reset/Makefile | 1 + drivers/reset/realtek/Kconfig | 8 +++ drivers/reset/realtek/Makefile | 2 + drivers/reset/realtek/reset-rtk-common.c | 73 ++++++++++++++++++++++++ drivers/reset/realtek/reset-rtk-common.h | 29 ++++++++++ 7 files changed, 115 insertions(+) create mode 100644 drivers/reset/realtek/Kconfig create mode 100644 drivers/reset/realtek/Makefile create mode 100644 drivers/reset/realtek/reset-rtk-common.c create mode 100644 drivers/reset/realtek/reset-rtk-common.h diff --git a/MAINTAINERS b/MAINTAINERS index 65dd2be63903..130440224e55 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -22748,6 +22748,7 @@ L: devicetree@vger.kernel.org L: linux-clk@vger.kernel.org S: Supported F: Documentation/devicetree/bindings/clock/realtek* +F: drivers/reset/realtek/* F: include/dt-bindings/clock/realtek* F: include/dt-bindings/reset/realtek* diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index d009eb0849a3..45a4227b5f44 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -418,6 +418,7 @@ config RESET_ZYNQMP source "drivers/reset/amlogic/Kconfig" source "drivers/reset/hisilicon/Kconfig" +source "drivers/reset/realtek/Kconfig" source "drivers/reset/spacemit/Kconfig" source "drivers/reset/starfive/Kconfig" source "drivers/reset/sti/Kconfig" diff --git a/drivers/reset/Makefile b/drivers/reset/Makefile index 3e52569bd276..7330fee91365 100644 --- a/drivers/reset/Makefile +++ b/drivers/reset/Makefile @@ -2,6 +2,7 @@ obj-y += core.o obj-y += amlogic/ obj-y += hisilicon/ +obj-y += realtek/ obj-y += spacemit/ obj-y += starfive/ obj-y += sti/ diff --git a/drivers/reset/realtek/Kconfig b/drivers/reset/realtek/Kconfig new file mode 100644 index 000000000000..5ddf8e5c09c7 --- /dev/null +++ b/drivers/reset/realtek/Kconfig @@ -0,0 +1,8 @@ +# SPDX-License-Identifier: GPL-2.0-only +config RESET_RTK_COMMON + tristate "Realtek common reset driver" if COMPILE_TEST + help + This option enables the common reset controller library for + Realtek SoCs. It provides shared reset control operations + (assert, deassert, status) that other Realtek-specific reset + drivers can use. diff --git a/drivers/reset/realtek/Makefile b/drivers/reset/realtek/Makefile new file mode 100644 index 000000000000..6d68e41748bf --- /dev/null +++ b/drivers/reset/realtek/Makefile @@ -0,0 +1,2 @@ +# SPDX-License-Identifier: GPL-2.0-only +obj-$(CONFIG_RESET_RTK_COMMON) += reset-rtk-common.o diff --git a/drivers/reset/realtek/reset-rtk-common.c b/drivers/reset/realtek/reset-rtk-common.c new file mode 100644 index 000000000000..6900932b0a32 --- /dev/null +++ b/drivers/reset/realtek/reset-rtk-common.c @@ -0,0 +1,73 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (C) 2019-2026 Realtek Semiconductor Corporation + */ + +#include +#include +#include +#include "reset-rtk-common.h" + +static inline struct rtk_reset_data *to_rtk_reset_controller(struct reset_controller_dev *r) +{ + return container_of(r, struct rtk_reset_data, rcdev); +} + +static inline const struct rtk_reset_desc *rtk_reset_get_desc(struct rtk_reset_data *data, + unsigned long idx) +{ + return &data->descs[idx]; +} + +static int rtk_reset_assert(struct reset_controller_dev *rcdev, + unsigned long idx) +{ + struct rtk_reset_data *data = to_rtk_reset_controller(rcdev); + const struct rtk_reset_desc *desc; + unsigned int mask, val; + + desc = rtk_reset_get_desc(data, idx); + mask = desc->write_en ? (0x3U << desc->bit) : BIT(desc->bit); + val = desc->write_en ? (0x2U << desc->bit) : 0; + + return regmap_update_bits(data->regmap, desc->ofs, mask, val); +} + +static int rtk_reset_deassert(struct reset_controller_dev *rcdev, + unsigned long idx) +{ + struct rtk_reset_data *data = to_rtk_reset_controller(rcdev); + const struct rtk_reset_desc *desc; + unsigned int mask; + + desc = rtk_reset_get_desc(data, idx); + mask = desc->write_en ? (0x3U << desc->bit) : BIT(desc->bit); + + return regmap_set_bits(data->regmap, desc->ofs, mask); +} + +static int rtk_reset_status(struct reset_controller_dev *rcdev, + unsigned long idx) +{ + struct rtk_reset_data *data = to_rtk_reset_controller(rcdev); + const struct rtk_reset_desc *desc; + unsigned int val; + int ret; + + desc = rtk_reset_get_desc(data, idx); + ret = regmap_read(data->regmap, desc->ofs, &val); + if (ret) + return ret; + + return !((val >> desc->bit) & 1); +} + +const struct reset_control_ops rtk_reset_ops = { + .assert = rtk_reset_assert, + .deassert = rtk_reset_deassert, + .status = rtk_reset_status, +}; +EXPORT_SYMBOL_NS_GPL(rtk_reset_ops, "REALTEK_RESET"); + +MODULE_DESCRIPTION("realtek reset infrastructure"); +MODULE_LICENSE("GPL"); diff --git a/drivers/reset/realtek/reset-rtk-common.h b/drivers/reset/realtek/reset-rtk-common.h new file mode 100644 index 000000000000..3ea35d9573a4 --- /dev/null +++ b/drivers/reset/realtek/reset-rtk-common.h @@ -0,0 +1,29 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (C) 2026 Realtek Semiconductor Corporation + * Author: Yu-Chun Lin + */ + +#ifndef __RESET_REALTEK_COMMON_H +#define __RESET_REALTEK_COMMON_H + +#include +#include + +struct regmap; + +struct rtk_reset_desc { + u32 ofs; + u32 bit; + bool write_en; +}; + +struct rtk_reset_data { + struct reset_controller_dev rcdev; + const struct rtk_reset_desc *descs; + struct regmap *regmap; +}; + +extern const struct reset_control_ops rtk_reset_ops; + +#endif /* __RESET_REALTEK_COMMON_H */ -- 2.43.0