Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hongyang Zhao <hongyang.zhao@thundersoft.com>
To: konrad.dybcio@oss.qualcomm.com
Cc: Frank.Li@nxp.com, andersson@kernel.org, conor+dt@kernel.org,
	devicetree@vger.kernel.org, festevam@gmail.com,
	hongyang.zhao@thundersoft.com, imx@lists.linux.dev,
	kernel@pengutronix.de, konradybcio@kernel.org,
	krzk+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	robh@kernel.org, rosh@debian.org, s.hauer@pengutronix.de
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: qcs6490-rubikpi3: Add IMX219 camera overlays
Date: Thu, 30 Jul 2026 14:32:09 +0800	[thread overview]
Message-ID: <20260730063209.101985-1-hongyang.zhao@thundersoft.com> (raw)
In-Reply-To: <df03eb18-6928-453e-971b-681875e9cb0d@oss.qualcomm.com>

Thanks for the review!

On 7/22/26 6:12 PM, Hongyang Zhao wrote:
> > RUBIK Pi 3 ships without camera sensors, and its two connectors support
> > multiple modules. Keep module-specific nodes out of the base board DTS
> > and add per-connector overlays for Raspberry Pi Camera Module V2 IMX219
> > sensors.
> >
> > CAM1 uses CCI1 and CSIPHY1, while CAM2 uses CCI0 and CSIPHY4. Each
> > overlay describes the 24 MHz sensor input clock and the three sensor
> > rails derived from the switched 3.3 V connector supply.
> >
> > Describe each connector CAMERA_GPIO signal as a privacy indicator LED
> > and associate it with the corresponding sensor. This lets the V4L2 core
> > control the LED while the sensor is streaming.
> >
> > Signed-off-by: Hongyang Zhao <hongyang.zhao@thundersoft.com>
> > ---
>
> [...]
>
> > +	/* The module enables its three sensor rails together through PWR_EN. */
> > +	vreg_cam2_pwr: regulator-camera2-pwr {
> > +		compatible = "regulator-fixed";
> > +
> > +		regulator-name = "vreg_camera2_pwr";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +
> > +		gpio = <&tlmm 58 GPIO_ACTIVE_HIGH>;
>
> Is this (and the other) regulator on the SBC, or on the module (with
> the PWR_EN pin just being an output to the module connector)?

The per-camera power regulation is located on the camera module, not on
the baseboard. The board-level VCC3V3_OUTPUT rail supplies both the
40-pin header and the two camera connectors. On the baseboard, U1500
only level-shifts the PWR_EN signals before routing them to the camera
connectors; there is no dedicated per-camera regulator.

The fixed-regulator node in the module-specific Device Tree overlay
models the camera module's power domain controlled through the
connector's PWR_EN signal.

Hardware Schematic:
https://thundercomm.s3-accelerate.amazonaws.com/uploads/web/rubik-pi-3/RUBIKPI3-IOB-V02-RELEASE.pdf

Thanks,
Hongyang


      reply	other threads:[~2026-07-30  6:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22 16:12 [PATCH v2 0/2] arm64: dts: qcom: qcs6490-rubikpi3: Add IMX219 camera overlays Hongyang Zhao
2026-07-22 16:12 ` [PATCH v2 1/2] arm64: dts: qcom: qcs6490-rubikpi3: Add 3.3 V output supply Hongyang Zhao
2026-07-22 21:53   ` Bryan O'Donoghue
2026-07-28 12:06   ` Konrad Dybcio
2026-07-30  3:31     ` Hongyang Zhao
2026-07-22 16:12 ` [PATCH v2 2/2] arm64: dts: qcom: qcs6490-rubikpi3: Add IMX219 camera overlays Hongyang Zhao
2026-07-22 21:55   ` Bryan O'Donoghue
2026-07-29 12:13   ` Konrad Dybcio
2026-07-30  6:32     ` Hongyang Zhao [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260730063209.101985-1-hongyang.zhao@thundersoft.com \
    --to=hongyang.zhao@thundersoft.com \
    --cc=Frank.Li@nxp.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rosh@debian.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox