From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2D25C531D0 for ; Thu, 30 Jul 2026 08:08:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aAz9Rtu2zYb+J22X9MI4UNKE36YjdvyEjAhDmovlVZs=; b=gC6+DOwuqY0rfc8x2CojCCYzKI qY8scjsgjk7loGhBhvc1bnYZQ+tGcZbA34njk3co4PFUs220Zr57juT/8AMV9CjiRDVrylnWwznaz L6jTU6xCWbNCKsxoHAwGHmynQs9xpZv5im5L6SWBjrKBRnkza+r6p8yw6VdI3hscvFobYtEKDZPfM tP0X54tDT/UwMG2Q20F1RCzAgwGhRLo8dDG76GyoNIaMN/ELxnoIve3B07Zi7uCTT+vALKKUnjdd1 sWRj4rKyrD0zQipcOfBgNbj0UtbzSP+9DxclLKRqBrNg86lEZfJsnAzmELP4eWCfYs73Vytf9k31H ifZCy3/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpLoE-00000009o1w-3NfK; Thu, 30 Jul 2026 08:08:06 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpLnx-00000009ntB-06fs for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2026 08:07:50 +0000 Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66U839A2013077 for ; Thu, 30 Jul 2026 08:07:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=aAz9Rtu2zYb +J22X9MI4UNKE36YjdvyEjAhDmovlVZs=; b=V1Lhs74Ve7Jj0ABM7V57N7naJgY NMRFvvX3X9cEGMg13QNkFYZ/laVcbfV9ZJGO+kifJQxWvojHMbes9ddfy5KbXWkd HwrDGNZ7G/XRwhUgzccpoqjyy91hvx1u8rymm/ydhrPubpXhk/syyZRdsibOgkg5 AKmiLldpQBaChmUA6rb7XzftSsv980oIpm6TDf2aiKVqXy2E7ORPwTcppczhAg0W kn2s8CYphWkWwkQJQk67F7sfRDCe/JUEHjgoHdkzI5qgqp5Z2oYu1SNhG74LMB7G MaZC4UYx6xXDz/Iu1ncvPXfldsZryW8WmsDWbvr6ViJRMkwY2P23Sn38f/A== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fr2rx00qf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Jul 2026 08:07:48 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-38e7b87ce77so4324222a91.0 for ; Thu, 30 Jul 2026 01:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785398867; x=1786003667; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aAz9Rtu2zYb+J22X9MI4UNKE36YjdvyEjAhDmovlVZs=; b=SNLPQKTbNogfxqk6KReujfUqCdocUfRyPt8djCTwSAJDdZI4b/C89GXlnMxixbeY/r 61Oz7c73E1vsIDnSSf/aW7oMC+t0nNu5SSx32x7ROch+pG+UqTiXy8R/cR8cfgikfV5Z WkPnwFUmP5AARyZtR4fLdpzxKqJQmdwyadBU9XoKBZwN0WkYh+u7f69hcojOV2G+k8k8 WJjZd9vHYaeNJR54HPDF7huBkIAfwqeDG19nli98XyDpoa1YW/Q/AXi77NmmjxvNaOWd 5+sm3gXT0QFLlA0ciz/OKslXSJmteVA024kYKNr9aV+bJ6RFlkbNWssSgPBwAMyQ1bDl 7h0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785398867; x=1786003667; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=aAz9Rtu2zYb+J22X9MI4UNKE36YjdvyEjAhDmovlVZs=; b=BVL+AUTd32repJu1bFRjzyyNN7hVW2/qN/prrZx0uHbHWJRw+JPuzYBejenCpHPPAc MtYXa4vQPlwDLs6t1Of3xzE9WeEbfC/eYz5X+si/adD7Bah/hrJGaD9fgk9p93Evc6tZ 3r4KTLtMH2S3k0p6zsx+riuaxdcCSwEIqc0+GZQmlKnpxn4buIRlTzlJHbiCLkT8O6As tRST7dZh53KmihEATwUJuqfy9cdc8fkrkf8O1m4vY8KZWdaYoON450egRF5JOn4SDYOA Xu6OfxeqLirsMP2NCbjaG0uH+wW9Pw0K9pUFlJl1/BDRawxezJc+E/DY6IQ0djmO4cmk 3BkQ== X-Forwarded-Encrypted: i=1; AHgh+RrU38X3zIj7AlXLIbWNhyeyze03ZwINi/5Gl/M6pNNr5jDqIt+rKfkWD2r4vky92MxIERmxZsrXxl9zq+7MZNye@lists.infradead.org X-Gm-Message-State: AOJu0YwLmFtJwdICTbEB0RvhRRcC2mietlYosaDoddITmYtGOepgyoUs svWU7F+2A7nUVK27A/SawZjSCLqP3QlsE9CJgnWHuXUNCpQ+xq2duBOp0E4qmFbzP6bKk6Il/ac rhyLNxjs2ZgANrar5hvcqSJimrFUc2FgbZ014wqtO+msRwt5fr9glloF1CjYu7hK6eTLiVgsPBc NkDA== X-Gm-Gg: AR+sD10JmiLS7eCLq7epO7ujZIPIF+bu5BekRpRFT/ojLdeoVbdxOu0Oopw8OH9l8Gh ts813BVBfjOoSquUGtPPB1SN+ss/pWpFRykfIifXB+j9dKvorsVv8X6HtZgMqCo8bHXAI6guC2X Jdeax1NgK66ks+62KFF/j9IXslVQT1a+dEGx9nBoapCQV3zrJeuEZl4BjdGN4RBqIfdlPA6EnFG HySDE7zH3QRTPo/mjlkVhgUmOy1WfOBfpPB8nJexruAd+vjszYPMFAiTL+Mot5NWiXaAb978zcS 3O5fY9sfwKv3mDI/mK1wwuHk3vLPEjxcgBgVhSYMoD11K6PIY7M3hZaQBLzs61e7lRyGJpTl6df ysP8eu2myYcgUQqclgIfiCbbZ/IksheepUK6Op4vbtTlvru6mf4xxTvQ= X-Received: by 2002:a17:90b:3c8c:b0:38d:a8be:a597 with SMTP id 98e67ed59e1d1-38f9c0815c9mr1635514a91.37.1785398867157; Thu, 30 Jul 2026 01:07:47 -0700 (PDT) X-Received: by 2002:a17:90b:3c8c:b0:38d:a8be:a597 with SMTP id 98e67ed59e1d1-38f9c0815c9mr1635476a91.37.1785398866681; Thu, 30 Jul 2026 01:07:46 -0700 (PDT) Received: from hu-songchai-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38f9bab61desm619516a91.13.2026.07.30.01.07.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 01:07:46 -0700 (PDT) From: Songwei Chai To: andersson@kernel.org, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, konrad.dybcio@oss.qualcomm.com, suzuki.poulose@arm.com, james.clark@arm.com, krzk+dt@kernel.org, conor+dt@kernel.org Cc: Songwei Chai , songwei.chai@oss.qualcomm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, coresight@lists.linaro.org, devicetree@vger.kernel.org, gregkh@linuxfoundation.org, Jie Gan Subject: [PATCH v16 4/7] qcom-tgu: Add TGU decode support Date: Thu, 30 Jul 2026 01:07:01 -0700 Message-Id: <20260730080704.2903540-5-songwei.chai@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260730080704.2903540-1-songwei.chai@oss.qualcomm.com> References: <20260730080704.2903540-1-songwei.chai@oss.qualcomm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDA1NyBTYWx0ZWRfXxtIFqDn97lXd 9YNWqJxPBsF85XVmkAr5vqEJrRiXLJIVmL3CyIT9GlYHMtAHH1G+AlxpE924WXSlW6wcrPONXwH 4rvJxRxy53m7lNdcL0XSH8TLjpnxUwo= X-Proofpoint-GUID: 2JMLQJ8gbhE-__LHy-8I4uBL5liiDdQk X-Authority-Analysis: v=2.4 cv=aO3Ab79m c=1 sm=1 tr=0 ts=6a6b0654 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=-Xdq57HJl2SVtTrRoKoA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDA1NyBTYWx0ZWRfX3MX2sQgR/nI6 b6Wy4r2r9pa2NHqHFmVoZ+20SciGzwC5hNabp6FKG5r9I1wa3P/iq5uYrYws0Od1z+hHy2SdPK8 4hJCd6kIutNqbTL/TxUtsU21PBRehYLKIvApSuLO+/YBBMnl38dGtkmbt7kneXd8s6DNSMfOhr1 VHSNAZBScFptbh7GSsod/KOXGdoORiXi+FHQk+cY35DH852g43HX5kTcCT9ATEf4GhhJkZWyivX 2PXMGgcwCstefEQfIS/QkQqI4X0buoRaAfqNswihozONMGv8F0pdSwAeyIj6OTrhy5u0/UzqBwe t8dXy1TTx1L51mfTfwlFm94EMssj8ZDfJNAEbEkkHqNw1prTkYXJCiyotMQrwg7bQMl3PQRvZ3M d8ciARsHkAtw0JvZtctb30QJFrvjR7P/flB0Ck5si6u0NBOwmLNiJ5R+LRe0W60NkHRN08OYgEX JkH0KEjkt7ktt47B6fQ== X-Proofpoint-ORIG-GUID: 2JMLQJ8gbhE-__LHy-8I4uBL5liiDdQk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_02,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 spamscore=0 malwarescore=0 impostorscore=0 phishscore=0 adultscore=0 priorityscore=1501 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300057 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260730_010749_082249_554EB9BC X-CRM114-Status: GOOD ( 23.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Songwei Chai Decoding is when all the potential pieces for creating a trigger are brought together for a given step. Example - there may be a counter keeping track of some occurrences and a priority-group that is being used to detect a pattern on the sense inputs. These 2 inputs to condition_decode must be programmed, for a given step, to establish the condition for the trigger, or movement to another steps. Reviewed-by: Jie Gan Signed-off-by: Songwei Chai --- .../ABI/testing/sysfs-bus-amba-devices-tgu | 7 + drivers/hwtracing/qcom/tgu.c | 182 ++++++++++++++++-- drivers/hwtracing/qcom/tgu.h | 37 ++++ 3 files changed, 206 insertions(+), 20 deletions(-) diff --git a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu index 7dd24314592d..705e75c776d4 100644 --- a/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu +++ b/Documentation/ABI/testing/sysfs-bus-amba-devices-tgu @@ -14,3 +14,10 @@ KernelVersion: 7.2 Contact: Jinlong Mao , Songwei Chai Description: (RW) Set/Get the sensed signal with specific step and priority for TGU. + +What: /sys/bus/amba/devices//step[0:7]_condition_decode/reg[0:3] +Date: August 2026 +KernelVersion: 7.2 +Contact: Jinlong Mao , Songwei Chai +Description: + (RW) Set/Get the decode mode with specific step for TGU. diff --git a/drivers/hwtracing/qcom/tgu.c b/drivers/hwtracing/qcom/tgu.c index 0e88b437f191..e83295217e7a 100644 --- a/drivers/hwtracing/qcom/tgu.c +++ b/drivers/hwtracing/qcom/tgu.c @@ -19,8 +19,33 @@ static int calculate_array_location(struct tgu_drvdata *drvdata, int step_index, int operation_index, int reg_index) { - return operation_index * (drvdata->num_step) * (drvdata->num_reg) + - step_index * (drvdata->num_reg) + reg_index; + switch (operation_index) { + case TGU_PRIORITY0: + case TGU_PRIORITY1: + case TGU_PRIORITY2: + case TGU_PRIORITY3: + return operation_index * (drvdata->num_step) * + (drvdata->num_reg) + + step_index * (drvdata->num_reg) + reg_index; + case TGU_CONDITION_DECODE: + return step_index * (drvdata->num_condition_decode) + + reg_index; + default: + break; + } + + return -EINVAL; +} + +static int check_array_location(struct tgu_drvdata *drvdata, int step, + int ops, int reg) +{ + int result = calculate_array_location(drvdata, step, ops, reg); + + if (result == -EINVAL) + dev_err(drvdata->dev, "check array location - Fail\n"); + + return result; } static ssize_t tgu_dataset_show(struct device *dev, @@ -31,9 +56,11 @@ static ssize_t tgu_dataset_show(struct device *dev, container_of(attr, struct tgu_attribute, attr); int index; - index = calculate_array_location(drvdata, tgu_attr->step_index, - tgu_attr->operation_index, - tgu_attr->reg_num); + index = check_array_location(drvdata, tgu_attr->step_index, + tgu_attr->operation_index, tgu_attr->reg_num); + + if (index == -EINVAL) + return index; /* * Serialise against tgu_dataset_store() and tgu_enable(), which read @@ -42,8 +69,20 @@ static ssize_t tgu_dataset_show(struct device *dev, */ guard(mutex)(&drvdata->lock); - return sysfs_emit(buf, "0x%x\n", - drvdata->value_table->priority[index]); + switch (tgu_attr->operation_index) { + case TGU_PRIORITY0: + case TGU_PRIORITY1: + case TGU_PRIORITY2: + case TGU_PRIORITY3: + return sysfs_emit(buf, "0x%x\n", + drvdata->value_table->priority[index]); + case TGU_CONDITION_DECODE: + return sysfs_emit(buf, "0x%x\n", + drvdata->value_table->condition_decode[index]); + default: + break; + } + return -EINVAL; } static ssize_t tgu_dataset_store(struct device *dev, @@ -66,9 +105,27 @@ static ssize_t tgu_dataset_store(struct device *dev, tgu_attr->operation_index, tgu_attr->reg_num); - tgu_drvdata->value_table->priority[index] = val; + if (index == -EINVAL) + return index; + + switch (tgu_attr->operation_index) { + case TGU_PRIORITY0: + case TGU_PRIORITY1: + case TGU_PRIORITY2: + case TGU_PRIORITY3: + tgu_drvdata->value_table->priority[index] = val; + ret = size; + break; + case TGU_CONDITION_DECODE: + tgu_drvdata->value_table->condition_decode[index] = val; + ret = size; + break; + default: + ret = -EINVAL; + break; + } - return size; + return ret; } static umode_t tgu_node_visible(struct kobject *kobject, @@ -85,22 +142,41 @@ static umode_t tgu_node_visible(struct kobject *kobject, if (tgu_attr->step_index >= drvdata->num_step) return SYSFS_GROUP_INVISIBLE; - if (tgu_attr->reg_num >= drvdata->num_reg) - return 0; + switch (tgu_attr->operation_index) { + case TGU_PRIORITY0: + case TGU_PRIORITY1: + case TGU_PRIORITY2: + case TGU_PRIORITY3: + if (!drvdata->num_reg) + return SYSFS_GROUP_INVISIBLE; + if (tgu_attr->reg_num < drvdata->num_reg) + return attr->mode; + break; + case TGU_CONDITION_DECODE: + if (!drvdata->num_condition_decode) + return SYSFS_GROUP_INVISIBLE; + if (tgu_attr->reg_num < drvdata->num_condition_decode) + return attr->mode; + break; + default: + break; + } - return attr->mode; + return 0; } -static void tgu_write_all_hw_regs(struct tgu_drvdata *drvdata) +static ssize_t tgu_write_all_hw_regs(struct tgu_drvdata *drvdata) { - int i, j, k, index; + int i, j, k, index = 0; TGU_UNLOCK(drvdata->base); for (i = 0; i < drvdata->num_step; i++) { for (j = 0; j < MAX_PRIORITY; j++) { for (k = 0; k < drvdata->num_reg; k++) { - index = calculate_array_location( + index = check_array_location( drvdata, i, j, k); + if (index == -EINVAL) + goto exit; writel(drvdata->value_table->priority[index], drvdata->base + @@ -108,9 +184,23 @@ static void tgu_write_all_hw_regs(struct tgu_drvdata *drvdata) } } } + + for (i = 0; i < drvdata->num_step; i++) { + for (j = 0; j < drvdata->num_condition_decode; j++) { + index = check_array_location(drvdata, i, + TGU_CONDITION_DECODE, j); + if (index == -EINVAL) + goto exit; + + writel(drvdata->value_table->condition_decode[index], + drvdata->base + CONDITION_DECODE_STEP(i, j)); + } + } /* Enable TGU to program the triggers */ writel(1, drvdata->base + TGU_CONTROL); +exit: TGU_LOCK(drvdata->base); + return index >= 0 ? 0 : -EINVAL; } static void tgu_set_reg_number(struct tgu_drvdata *drvdata) @@ -153,10 +243,31 @@ static void tgu_set_steps(struct tgu_drvdata *drvdata) } } -static void tgu_enable(struct tgu_drvdata *drvdata) +static int tgu_enable(struct tgu_drvdata *drvdata) { - tgu_write_all_hw_regs(drvdata); + int ret; + + ret = tgu_write_all_hw_regs(drvdata); + if (ret) + return ret; + drvdata->enabled = true; + return 0; +} + +static void tgu_set_conditions(struct tgu_drvdata *drvdata) +{ + u32 devid; + + devid = readl(drvdata->base + TGU_DEVID); + drvdata->num_condition_decode = TGU_DEVID_CONDITIONS(devid); + + if (drvdata->num_condition_decode > TGU_MAX_CONDITION_DECODE) { + dev_warn(drvdata->dev, + "DEVID reports %d condition decode regs, clamping to %d\n", + drvdata->num_condition_decode, TGU_MAX_CONDITION_DECODE); + drvdata->num_condition_decode = TGU_MAX_CONDITION_DECODE; + } } static void tgu_disable(struct tgu_drvdata *drvdata) @@ -210,7 +321,11 @@ static ssize_t enable_tgu_store(struct device *dev, if (ret) return ret; - tgu_enable(drvdata); + ret = tgu_enable(drvdata); + if (ret) { + pm_runtime_put(dev); + return ret; + } } else { if (!drvdata->enabled) return -EINVAL; @@ -266,6 +381,14 @@ static const struct attribute_group *tgu_attr_groups[] = { PRIORITY_ATTRIBUTE_GROUP_INIT(7, 1), PRIORITY_ATTRIBUTE_GROUP_INIT(7, 2), PRIORITY_ATTRIBUTE_GROUP_INIT(7, 3), + CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(0), + CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(1), + CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(2), + CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(3), + CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(4), + CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(5), + CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(6), + CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(7), NULL, }; @@ -273,8 +396,9 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id) { struct device *dev = &adev->dev; struct tgu_drvdata *drvdata; - unsigned int *priority; - size_t priority_size; + unsigned int *priority, *condition; + size_t priority_size, condition_size; + int i, j; int ret; drvdata = devm_kzalloc(dev, sizeof(*drvdata), GFP_KERNEL); @@ -294,6 +418,7 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id) tgu_set_reg_number(drvdata); tgu_set_steps(drvdata); + tgu_set_conditions(drvdata); drvdata->value_table = devm_kzalloc(dev, sizeof(*drvdata->value_table), GFP_KERNEL); @@ -310,6 +435,23 @@ static int tgu_probe(struct amba_device *adev, const struct amba_id *id) drvdata->value_table->priority = priority; + condition_size = drvdata->num_condition_decode * drvdata->num_step; + + condition = devm_kcalloc(dev, condition_size, + sizeof(*(drvdata->value_table->condition_decode)), + GFP_KERNEL); + if (!condition) + return -ENOMEM; + + drvdata->value_table->condition_decode = condition; + + /* Initialize all condition decode registers to NOT */ + for (i = 0; i < drvdata->num_step; i++) + for (j = 0; j < drvdata->num_condition_decode; j++) + condition[calculate_array_location( + drvdata, i, TGU_CONDITION_DECODE, j)] = + TGU_CONDITION_DECODE_NOT; + drvdata->enabled = false; /* * Create the sysfs groups only after the backing storage is fully diff --git a/drivers/hwtracing/qcom/tgu.h b/drivers/hwtracing/qcom/tgu.h index 7a3e1161c4cf..8b6a46995a5f 100644 --- a/drivers/hwtracing/qcom/tgu.h +++ b/drivers/hwtracing/qcom/tgu.h @@ -19,6 +19,8 @@ ((int)FIELD_GET(GENMASK(17, 10), devid_val)) #define TGU_DEVID_STEPS(devid_val) \ ((int)FIELD_GET(GENMASK(6, 3), devid_val)) +#define TGU_DEVID_CONDITIONS(devid_val) \ + ((int)FIELD_GET(GENMASK(2, 0), devid_val)) #define TGU_BITS_PER_SIGNAL 4 #define LENGTH_REGISTER 32 @@ -52,6 +54,7 @@ */ #define STEP_OFFSET 0x1D8 #define PRIORITY_START_OFFSET 0x0074 +#define CONDITION_DECODE_OFFSET 0x0050 #define PRIORITY_OFFSET 0x60 #define REG_OFFSET 0x4 @@ -63,6 +66,7 @@ * * TGU_MAX_STEPS static tables define step0..step7 * TGU_MAX_PRIORITY_REGS STEP_PRIORITY_LIST defines reg0..reg17 + * TGU_MAX_CONDITION_DECODE decode region 0x50..0x5F holds 4 u32 registers * * A device whose DEVID reports counts above these bounds is clamped, so writes * never fall outside the ioremap()'d window or spill into an adjacent region. @@ -70,12 +74,16 @@ #define TGU_MAX_STEPS 8 #define TGU_MAX_PRIORITY_REGS 18 +#define TGU_MAX_CONDITION_DECODE 4 /* Calculate compare step addresses */ #define PRIORITY_REG_STEP(step, priority, reg)\ (PRIORITY_START_OFFSET + PRIORITY_OFFSET * priority +\ REG_OFFSET * reg + STEP_OFFSET * step) +#define CONDITION_DECODE_STEP(step, decode) \ + (CONDITION_DECODE_OFFSET + REG_OFFSET * decode + STEP_OFFSET * step) + #define tgu_dataset_rw(name, step_index, type, reg_num) \ (&((struct tgu_attribute[]){ { \ __ATTR(name, 0644, tgu_dataset_show, tgu_dataset_store), \ @@ -87,6 +95,8 @@ #define STEP_PRIORITY(step_index, reg_num, priority) \ tgu_dataset_rw(reg##reg_num, step_index, TGU_PRIORITY##priority, \ reg_num) +#define STEP_DECODE(step_index, reg_num) \ + tgu_dataset_rw(reg##reg_num, step_index, TGU_CONDITION_DECODE, reg_num) #define STEP_PRIORITY_LIST(step_index, priority) \ {STEP_PRIORITY(step_index, 0, priority), \ @@ -110,6 +120,14 @@ NULL \ } +#define STEP_DECODE_LIST(n) \ + {STEP_DECODE(n, 0), \ + STEP_DECODE(n, 1), \ + STEP_DECODE(n, 2), \ + STEP_DECODE(n, 3), \ + NULL \ + } + #define PRIORITY_ATTRIBUTE_GROUP_INIT(step, priority)\ (&(const struct attribute_group){\ .attrs = (struct attribute*[])STEP_PRIORITY_LIST(step, priority),\ @@ -117,16 +135,32 @@ .name = "step" #step "_priority" #priority \ }) +#define CONDITION_DECODE_ATTRIBUTE_GROUP_INIT(step)\ + (&(const struct attribute_group){\ + .attrs = (struct attribute*[])STEP_DECODE_LIST(step),\ + .is_visible = tgu_node_visible,\ + .name = "step" #step "_condition_decode" \ + }) + enum operation_index { TGU_PRIORITY0, TGU_PRIORITY1, TGU_PRIORITY2, TGU_PRIORITY3, + TGU_CONDITION_DECODE, }; /* Maximum priority that TGU supports */ #define MAX_PRIORITY 4 +/* + * Neutral ('NOT') value for the condition decode registers. This is the + * driver's default so that, before userspace programs a real decode, an + * enabled step does not spuriously match. Used both when seeding the shadow + * table at probe and when clearing it via reset_tgu. + */ +#define TGU_CONDITION_DECODE_NOT 0x1000000 + struct tgu_attribute { struct device_attribute attr; u32 step_index; @@ -136,6 +170,7 @@ struct tgu_attribute { struct value_table { unsigned int *priority; + unsigned int *condition_decode; }; static inline void TGU_LOCK(void __iomem *addr) @@ -166,6 +201,7 @@ static inline void TGU_UNLOCK(void __iomem *addr) * @value_table: Store given value based on relevant parameters * @num_reg: Maximum number of registers * @num_step: Maximum step size + * @num_condition_decode: Maximum number of condition_decode * * This structure defines the data associated with a TGU device, * including its base address, device pointer, the lock serialising @@ -179,6 +215,7 @@ struct tgu_drvdata { struct value_table *value_table; int num_reg; int num_step; + int num_condition_decode; }; #endif -- 2.34.1