From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CEEB4C5516E for ; Thu, 30 Jul 2026 18:15:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hGyNUr7fBhXY6LyFNtiiX9bN9EXJPu/P8HqPzvigmCk=; b=ShKO+EWyZp20c91BQinnon0HMj UtR4jJeR7PvppKDG218g1rbTcsGSRxvGQIG4XvDQo9/S2hkZyUC1/Nf2vKYrX4OgIu47iZyWYpc0F iTmTqAeKuchlIyVaigKQjlpJiJpyfWkeH80WKNGiFjcBQImJx8fsFEIKhp1ckX6OgGEM5MqnT1Y1C 4Iq1FP5SnmIOIdDwOEtv0hASL9HhIjqgXqfBCRn8UASOJIHJTTAUHOeGLzUKOiopvOB6zDlERzNL2 +x5NEQT7ImEpYrIroUx5fLCufNfKclsIG1lN8u3olva+15/7rpYhQ3NH8RU1AW2cYc9kmnF4hY5Cq JVEh0//A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpVHN-0000000B8v1-40gw; Thu, 30 Jul 2026 18:14:49 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpVHK-0000000B8tH-3ySI for linux-arm-kernel@lists.infradead.org; Thu, 30 Jul 2026 18:14:48 +0000 Received: from killaraus.ideasonboard.com (2001-14ba-70f3-e800--a06.rev.dnainternet.fi [IPv6:2001:14ba:70f3:e800::a06]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B18411E4; Thu, 30 Jul 2026 20:13:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1785435215; bh=F6+Om4p+4oo6ZFQCdI73ewqN7GtwaTrmcvQiBnOu/Y0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LFQS8PGvLUXcVO9hXUO7yjUvuMrfoYeFfqgPRhlZA1/M5CacOvTHFAttRNwEJMr4V uTm2W/bVzaPnN3S+Xa71H+xLOjeNJ+D/iLefMGf2TnlItELijO0xfBy41cjbQH6izR Ug7vW3uOvgFEElhDlwMuG8XkERfjmD2vZ+RMtrCM= Date: Thu, 30 Jul 2026 21:14:40 +0300 From: Laurent Pinchart To: Guoniu Zhou Cc: Mauro Carvalho Chehab , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Christian Hemp , Stefan Riedmueller , Jacopo Mondi , Loic Poulain , Bryan O'Donoghue , Dong Aisheng , Guoniu Zhou , linux-media@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v5 1/4] media: nxp: imx8-isi: Use BIT_ULL() for 64-bit stream masks Message-ID: <20260730181440.GA1600813@killaraus.ideasonboard.com> References: <20260728-isi-v5-0-1d22ab91602a@oss.nxp.com> <20260728-isi-v5-1-1d22ab91602a@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260728-isi-v5-1-1d22ab91602a@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260730_111447_130513_179E932B X-CRM114-Status: GOOD ( 16.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Guoniu, Thank you for the patch. On Tue, Jul 28, 2026 at 02:58:56PM +0800, Guoniu Zhou wrote: > Use BIT_ULL() instead of BIT() for u64 stream masks to avoid incorrect > results on 32-bit architectures when stream IDs are 32 or greater. > > Fixes: cf21f328fcaf ("media: nxp: Add i.MX8 ISI driver") > Cc: stable@vger.kernel.org I'm not sure this deserves being backported, as streams IDs won't be larger than 31 in normal use cases, but it doesn't hurt. > Signed-off-by: Guoniu Zhou Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > index 9f0231ca47a3..9db9c6e55c2c 100644 > --- a/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > +++ b/drivers/media/platform/nxp/imx8-isi/imx8-isi-crossbar.c > @@ -157,10 +157,10 @@ mxc_isi_crossbar_xlate_streams(struct mxc_isi_crossbar *xbar, > */ > for_each_active_route(&state->routing, route) { > if (route->source_pad != source_pad || > - !(source_streams & BIT(route->source_stream))) > + !(source_streams & BIT_ULL(route->source_stream))) > continue; > > - sink_streams |= BIT(route->sink_stream); > + sink_streams |= BIT_ULL(route->sink_stream); > sink_pad = route->sink_pad; > } > -- Regards, Laurent Pinchart