From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F811C5516F for ; Fri, 31 Jul 2026 03:56:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-Type: Content-Transfer-Encoding:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=m2w7jZ1KH1RvIYaYXMlMmItVP/gdyni9Fk6pSH/rnPk=; b=zakrh45mY0/617+aqeEenk2jhn bAHzfWcXG3u+qmAXx/vjekZ5y9YsfAkBnN6JREbIUj/RlfPTfVesdufEb+obHCaGukEHX9lXpjbn3 h/VAI8zqXl3GamLp+WCYSfLaJ5u5UlskCeHmM0C/bnwBVak6/gU7uHCpb+/HPXW/O+pP3OJpOCgHE frCcLlgOZmxfg057zrAZjSrzl23PVRpsvdHjBDVdSuOsxnYb89Xfol+TUMpdFg+Oe1AnPFOT7sBNT yWrrPC6E4JrMgr0UGNMW2Wl3C9SG60wpQHqc0Q1GTK9D0dv5ZNoqzownpoPjlJxU1U05GaIEIHRKn oM9/EUyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpeLh-0000000BiJo-2tyn; Fri, 31 Jul 2026 03:55:53 +0000 Received: from mail-japaneastazlp170120005.outbound.protection.outlook.com ([2a01:111:f403:c405::5] helo=TYPPR03CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpeLe-0000000BiHx-1P0N for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2026 03:55:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=KjcdcCPErXrEtt8KJHnzUuBNTAxFNhprs0IniK//DWNGinumrRuPhDYUXk9hdvTmAfErwd7R4bLYJiGTvtpGOg+udNJ8fVTHCkTTU09S0UEof396vPlK7/MwSEn7fVvgg9Yb/Fyoc/9NU+zS+SeumZkHVVBkGsLNxQGm5J2kmGXZ9OWYrSaFrtxeJzr1n1/a6z5bnxqHUqvoEs88mqAns47q9xMPtuxF2TDDh17HlSFI7W92jZQ1b77KEdcBAVwyCCCW98QpEh5N+argKFgkQdJwfNzeHuWHZj31VrNh9m1kB6hbx9NAlB/dsx6TDQCxnVrpwIshdbMYysGLijXzlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m2w7jZ1KH1RvIYaYXMlMmItVP/gdyni9Fk6pSH/rnPk=; b=I3/JVwyuG5jBuEwagxYZKGMdBx9KQqPYuQaEZu96bct/E4JPGT+P3Ap36aZQmg2RwAcrE5OyLiOUlanNmVXv8aeO0Y5+T23C26eift2QEBqr634u9xfrJXfa1o1yulpG78Vt8tV7RhJCd+ZHO5whLA5h9yp5+qj/j/wHDNKcxbxm0PNz6shFwJ8DIdruPN5+J8ZY9+w4EnZRY5lDjNw1o/jsmZ0GpP1CKO+/6GK27cy9Gsu/Efn9jNo3AbQaOeP489SeVjxzszGdzFeD9N1A9DAer2TEzmdbIDvqLRP1cqCzKnglZQeTsU4ygZSSifa3m1/7B2Z7JtUzieFm32xqWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=vivo.com; dmarc=pass action=none header.from=vivo.com; dkim=pass header.d=vivo.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vivo.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m2w7jZ1KH1RvIYaYXMlMmItVP/gdyni9Fk6pSH/rnPk=; b=Q+zzyjD3Uw8jz3hiAUb7aveEb50bESn7i4/1rkT+0FDK6a9blr721ukxyIixRYTZ4HrMbH8epakkRk6h8nziHq51pV6lHnyX6CeKcKBVqfG00ipwobUPh/f5zQz/Wt+KjlObY5qDeWT4P6OXgBHXQnNleY7NyOMXawqn3te0S4M/bwZj83Bm6Wd0nKLeltdI0sQ0UwUx9K1wUhZTl0tqqm0+6YgD7Ip1XIy9dTrh7GF71L2IFa+muJJICsW+a2Pi4Pkw61xJOq1LlvIbk6rKKd5jxG2H5M5n1aBzwP7g4nSadnLb4DCrGDHZVn/WnEPpi7sJKzKnssDSft0LIiQQeA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=vivo.com; Received: from SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) by TYNPR06MB8782.apcprd06.prod.outlook.com (2603:1096:405:3c5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.270.15; Fri, 31 Jul 2026 03:55:21 +0000 Received: from SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b]) by SEZPR06MB5832.apcprd06.prod.outlook.com ([fe80::f98:5e32:4ccb:d07b%6]) with mapi id 15.21.0245.012; Fri, 31 Jul 2026 03:55:21 +0000 From: Pan Chuang To: Peter Griffin , =?UTF-8?q?Andr=C3=A9=20Draszik?= , Tudor Ambarus , Thinh Nguyen , Greg Kroah-Hartman , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , linux-arm-kernel@lists.infradead.org (moderated list:GOOGLE TENSOR SoC SUPPORT), linux-samsung-soc@vger.kernel.org (open list:GOOGLE TENSOR SoC SUPPORT), linux-usb@vger.kernel.org (open list:DESIGNWARE USB3 DRD IP DRIVER), linux-kernel@vger.kernel.org (open list), imx@lists.linux.dev (open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE), linux-omap@vger.kernel.org (open list:OMAP USB SUPPORT) Cc: Pan Chuang Subject: [PATCH 04/11] usb: dwc3: Remove redundant dev_err()/dev_err_probe() Date: Fri, 31 Jul 2026 11:54:38 +0800 Message-Id: <20260731035448.252289-5-panchuang@vivo.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260731035448.252289-1-panchuang@vivo.com> References: <20260731035448.252289-1-panchuang@vivo.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: TY4PR01CA0115.jpnprd01.prod.outlook.com (2603:1096:405:379::17) To SEZPR06MB5832.apcprd06.prod.outlook.com (2603:1096:101:c8::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SEZPR06MB5832:EE_|TYNPR06MB8782:EE_ X-MS-Office365-Filtering-Correlation-Id: 8968bc90-5e83-43fc-5920-08deeeb78b1d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|52116014|23010399003|366016|1800799024|38350700014|921020|6133799003|56012099006|11063799006|10067099003|5023799004|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: H81BeyXTWTZYFXvu1saL3Lt8mbxFxLMywCSXdXe5IkHHVDZYJz9xeBFXY7/32DFNuhYweQcOEATuEco4BARLXvK+V4INP25RbmTNittItFaqs7u/erpAISociw3fcJR19ONU0EIVJT5dnF8/plUtgUB1tgLXrl8PLgwfHaDGx2OriKXr1gkCgTakEgJ+mZVVSToCVKYrew4SL2C9ppqZ0XayLFMH68vNwAaF1j5az1jb/Kw7FsJY5gz6NidcGgogxJ83YoUHoaN+ME0IMLlp3KiO2Gvry/y8pfMYILKLfVX535oyjZkIu7faG+qQrsmlIrli8Xn4jMvuIY+wnJHcukAUUu8NxPjOLGJfMAzg9UbR5tmg6h3CQni5omYQLbMOgwBH//tC8dDydN+U7Zx2vneHXpirA/4qIN/ebchIxB/rUICEJedcDqOyRB5evfy+Z3jr1lPhHbGP7BUKupzC8g7Me9UiIP8yEjXBJq9ggxMcIw0OuN6RdK4LwPfsjS4u9rcT5uWU9jPeZajdtHwHSXHI3P6C9zir2iBsPJ3RrXBXeb0wSy1juacA2DskfuACv70/Ar2N0gzQJtoUgs/OO/Ix10O4K+Id2p8nUnmCe4lZ7fjb+HeiV8D/6AD5EsekjJz88O1WG8ibzWSqM6LeezXBSodV6jHrws3Bq/qn6Gh9SDjfCI3xxyft/aDW/vsieAZCnKnk8ECDHCoIHxjLEVgvH3VVtHgILJ49XX7XqUBK7btA0Zka4smHU5iKX0cE X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEZPR06MB5832.apcprd06.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(7416014)(52116014)(23010399003)(366016)(1800799024)(38350700014)(921020)(6133799003)(56012099006)(11063799006)(10067099003)(5023799004)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?J5U1G/0akIAAT5qLyvcCqxGgqpZqfojh35KZJej57K67G9dFxtGoYhAAfS6Y?= =?us-ascii?Q?lweGZ72AV39y4zp2ejjsoFF5RLuJVWO1daSS6jBp/QVfoZDEdYGFanH2b2p7?= =?us-ascii?Q?7qJEiAqLksNft35x+G3tbiL1SvsXHRckkKvkucJfQ/PnuJ8IXIqVTdbweMm1?= =?us-ascii?Q?DC2cSHBm5EDelzF/T749qwme1vvMNlrt0Z+I+9fnKZiSk1Tqk6/Uvv2Jwna5?= =?us-ascii?Q?laUmVapsnUMoIsM5Px52nLA6o5Ey0HculTfxvF3KRljT09MLcdHBye3lw6z7?= =?us-ascii?Q?lmAWR+gVnpKjTdXEtrTHJbvkRMUUefvpdHKXcaLlWrSiKjO2D1C52LGUSoqw?= =?us-ascii?Q?2D4JbCmn0w5R20al0q0JGbJXYdn8460quDBbtmjNoL2iine2zDQrE5j9olJ4?= =?us-ascii?Q?TGwd67R7cljQA+t6O0jQQ9qBlgO2KHxZN0gc/jZdZOQWyk4sC/0MPvcVtIWF?= =?us-ascii?Q?A1BG8CBBRynW2gOmWO8uhXlfIV6geF4pCeV7CMTnv+YUWKTLHnOkIJJjalMT?= =?us-ascii?Q?GATQ0WpA5wTiu1QfYcYk4h25Tnz9P6JLemg/bLCQfYihoVDd1at5FTh4xjnH?= =?us-ascii?Q?/7Liar2Bp+EUGBffEpUBUR/w2O+dly82fB7edmFT10UUvhvZbmKenEqCiA7x?= =?us-ascii?Q?uUx63WP5gh29Z9BVkATEBmpqnLPU5tBg1dqEOBmnOn82mqLRET9EANlGfngl?= =?us-ascii?Q?R8Fq/7SpdkqTV1How3bxLEo8Z3BhgaQX9yQW1yeIWXdjUTPd2yo+mwtMDQyX?= =?us-ascii?Q?qZMWn6JJNUGqUVQ1+RoCCgiDVqs+DInu5bmAFMH1DSgzo0p46eDeAED4xujc?= =?us-ascii?Q?pbFc3Yc2ZSOSIUH2Eh4jLdDRn8VApo7ocAXCQ9YxOotRMmlQqyMtoprlyTgQ?= =?us-ascii?Q?Rah/+rNE8wyKFczg1zyMpF/bG6hZuX2cYnWHZ6FwlwNpih3bY+LidGMsZGUB?= =?us-ascii?Q?yKhgfmis8HvK6IVo1H2sp544tGIeYZ6QHBguyttQ6ubW7Qvjk4V6hSC3Zu+h?= =?us-ascii?Q?oFh8+BkvFWiuPMluXwy6q5CAk/GfMxG0nVaUqEatvem7HqYI1HXxL8EDrDQL?= =?us-ascii?Q?+U6z7E1XnekCOERze9j6qkA44YV31UyU561lkNR5UBeiaHoy4QDBenwuIO12?= =?us-ascii?Q?9PRzXk8dbdj7DVLCHDtZ1zrtp26iVI7By87kzOYi5JQKhYOJDeq7jan5yrh4?= =?us-ascii?Q?GelprjroR802z9ESSDoK2AnQKZ5Z1RSAEUHaWPwuBvZgKAy/qvgGWSbrduSr?= =?us-ascii?Q?VKoLXsOyjAQ+vgQBegXKGZCrmJ7XL+FBQVVnw64bn65V4Cwk3wPhR4ZU1onF?= =?us-ascii?Q?Hn3/PWyV0zEYNFEWCM4gD6Ag5Eje5I/o/iFbGpyppktVg3RczK0wvz9h6p2y?= =?us-ascii?Q?M/WzXGT7MKWWQEc/dpBe7vqJqJWRmiv2FKfmg8jXCeKcFeMj+tqA65LW098u?= =?us-ascii?Q?1UsSJkOfBOlTB0CKnK/3shi0zAAZ6ICsJmAEDV043s38mqIj1qRC8YbNSTVA?= =?us-ascii?Q?B4xW6p52i1X9jPBx2caNm1xBA0tawarlQjryqZ1XjxUi8JO8v3/l9U+VfOFk?= =?us-ascii?Q?XqtN2XhyGIq198kaVmShEnPzgVP+m1GuuvWAf/kyqCVDyHeTHvN/WzOz9fiA?= =?us-ascii?Q?J42Ko02FQpAevOGjMCHIbZa1NIdtQsjzNfM1SRILA6+CuKem1FKJ3YyYCHc5?= =?us-ascii?Q?37n/w/t3hn9uuV2AXc/p3KeOiYSgptItcPlqiICjTC2pzqY+UTy2iSAjxdof?= =?us-ascii?Q?eusRiaVyNA=3D=3D?= X-OriginatorOrg: vivo.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8968bc90-5e83-43fc-5920-08deeeb78b1d X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5832.apcprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jul 2026 03:55:21.5480 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 88uBg0oAT46aYtXEC9mqnOEuEtVihCVZc3+kAQ2SNed+9jnKFWl6QDyWKeoDYsOSxtkGaH+Hbq9KnOgzUxk1iQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYNPR06MB8782 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260730_205550_377401_5E431082 X-CRM114-Status: GOOD ( 11.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq() automatically log detailed error messages on failure. Remove the now-redundant driver-specific dev_err() and dev_err_probe() calls. Signed-off-by: Pan Chuang --- drivers/usb/dwc3/dwc3-google.c | 4 +--- drivers/usb/dwc3/dwc3-imx.c | 2 +- drivers/usb/dwc3/dwc3-imx8mp.c | 4 +--- drivers/usb/dwc3/dwc3-keystone.c | 5 +---- drivers/usb/dwc3/dwc3-omap.c | 5 +---- 5 files changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-google.c b/drivers/usb/dwc3/dwc3-google.c index 60ee4cc99b28..e581d407b872 100644 --- a/drivers/usb/dwc3/dwc3-google.c +++ b/drivers/usb/dwc3/dwc3-google.c @@ -235,10 +235,8 @@ static int dwc3_google_request_irq(struct dwc3_google *google, struct platform_d dwc3_google_resume_irq, IRQF_TRIGGER_HIGH | IRQF_ONESHOT, req_name, google); - if (ret < 0) { - dev_err(google->dev, "failed to request irq %s\n", req_name); + if (ret < 0) return ret; - } return irq; } diff --git a/drivers/usb/dwc3/dwc3-imx.c b/drivers/usb/dwc3/dwc3-imx.c index 973a486b544d..d967acd43d44 100644 --- a/drivers/usb/dwc3/dwc3-imx.c +++ b/drivers/usb/dwc3/dwc3-imx.c @@ -250,7 +250,7 @@ static int dwc3_imx_probe(struct platform_device *pdev) IRQF_ONESHOT | IRQF_NO_AUTOEN, irq_name, dwc_imx); if (ret) - return dev_err_probe(dev, ret, "failed to request IRQ #%d\n", irq); + return ret; ret = device_add_software_node(dev, &dwc3_imx_swnode); if (ret) diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c index 1cf96540b66e..ee92a5efaa6e 100644 --- a/drivers/usb/dwc3/dwc3-imx8mp.c +++ b/drivers/usb/dwc3/dwc3-imx8mp.c @@ -273,10 +273,8 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev) err = devm_request_threaded_irq(dev, irq, NULL, dwc3_imx8mp_interrupt, IRQF_ONESHOT, dev_name(dev), dwc3_imx); - if (err) { - dev_err(dev, "failed to request IRQ #%d --> %d\n", irq, err); + if (err) goto put_dwc3; - } device_set_wakeup_capable(dev, true); pm_runtime_put(dev); diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c index 7ee1610162b9..8ad302abe883 100644 --- a/drivers/usb/dwc3/dwc3-keystone.c +++ b/drivers/usb/dwc3/dwc3-keystone.c @@ -144,11 +144,8 @@ static int kdwc3_probe(struct platform_device *pdev) error = devm_request_irq(dev, irq, dwc3_keystone_interrupt, IRQF_SHARED, dev_name(dev), kdwc); - if (error) { - dev_err(dev, "failed to request IRQ #%d --> %d\n", - irq, error); + if (error) goto err_irq; - } kdwc3_enable_irqs(kdwc); diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c index fe74d11bb629..3bff775fbe4e 100644 --- a/drivers/usb/dwc3/dwc3-omap.c +++ b/drivers/usb/dwc3/dwc3-omap.c @@ -518,11 +518,8 @@ static int dwc3_omap_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(dev, omap->irq, dwc3_omap_interrupt, dwc3_omap_interrupt_thread, IRQF_SHARED, "dwc3-omap", omap); - if (ret) { - dev_err(dev, "failed to request IRQ #%d --> %d\n", - omap->irq, ret); + if (ret) goto err2; - } dwc3_omap_enable_irqs(omap); return 0; -- 2.34.1