From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83539C54F54 for ; Fri, 31 Jul 2026 17:04:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Q6uM3mVpB+a9s2rT3tVLZz3AOwReJZ0tYQFu6EK1jmI=; b=QS1sylYaHrlGjEl86V4C8s8Ga/ SVfPWdhr/h6mnIFqn2THV8HJeInlyiCctaG5/vA9JFdT3cl+7iy1Q4cV5xXaVO5euZLZqfcRNradx D0/sl/eYeFiUKvUDGP/ZAJd0gGiQ3g0hLSUKcSElMqtRL4IWn6dyvTScJ+Z3j1BoZ8Uxgf5zx0oEj +o7z4YqIBCyURO/62wMjk6F17cTz3Narle7Yrkwq/8e0c/4ksKg5wWV3IL6KA/K/we/lz6MeICXM+ 7Vlx3pasDCpVue2iwR2JxYBSKie0Eyg9sQIjNIWXxyT7tAuhf+FHIycb8y19jJOOlTuVvSaEhnfk+ cC08oIzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpqeT-0000000DCXR-0R1l; Fri, 31 Jul 2026 17:04:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wpqeP-0000000DCVX-00jG for linux-arm-kernel@lists.infradead.org; Fri, 31 Jul 2026 17:04:02 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 67DC1204C; Fri, 31 Jul 2026 10:03:56 -0700 (PDT) Received: from e142021.fritz.box (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E80E93F66F; Fri, 31 Jul 2026 10:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1785517440; bh=gx2sJjkF0UHE+KRG16kTE2Zuv4r4Qdh+PeWJ6EjL7JA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lRa/cNqa+c77MRtEjdjdS73Wjq6gRDeZgvT84OdEfV13EPU7MbJYUBGuTtcasE/UE k4BkRNlmYEoPmQ9QMvQiw6r9A01ZCiLT5CDRJ+kAp00XcGRROZrB47HOCPjpdQa4Qg y8g+nV3NobvKRv2qu+KYxObRaMdDeekAImG8h7HI= From: Andre Przywara To: Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , James Morse , Ben Horgan , Reinette Chatre , Fenghua Yu Cc: Jonathan Cameron , Srivathsa L Rao , Ganapatrao Kulkarni , Trilok Soni , Srinivas Ramana , Niyas Sait , Lee Trager , Ritwick Sharma , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v7 06/11] arm_mpam: propagate MSC access errors for state saving function Date: Fri, 31 Jul 2026 19:03:19 +0200 Message-ID: <20260731170324.2927758-7-andre.przywara@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260731170324.2927758-1-andre.przywara@arm.com> References: <20260731170324.2927758-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260731_100401_072019_3E5E601D X-CRM114-Status: GOOD ( 10.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Allow the mpam_save_mbwu_state() function to return an error, and propagate read and write errors from the lower level up. Signed-off-by: Andre Przywara Reviewed-by: Jonathan Cameron Reviewed-by: Ben Horgan --- drivers/resctrl/mpam_devices.c | 29 ++++++++++++++++++++++------- 1 file changed, 22 insertions(+), 7 deletions(-) diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c index fa8ed20a6740..38450c55e45e 100644 --- a/drivers/resctrl/mpam_devices.c +++ b/drivers/resctrl/mpam_devices.c @@ -1838,22 +1838,37 @@ static int mpam_save_mbwu_state(void *arg) mon_sel = FIELD_PREP(MSMON_CFG_MON_SEL_MON_SEL, i) | FIELD_PREP(MSMON_CFG_MON_SEL_RIS, ris->ris_idx); - mpam_write_monsel_reg(msc, CFG_MON_SEL, mon_sel); - mpam_read_monsel_reg(msc, CFG_MBWU_FLT, &cur_flt); - mpam_read_monsel_reg(msc, CFG_MBWU_CTL, &cur_ctl); - mpam_write_monsel_reg(msc, CFG_MBWU_CTL, 0); + ret = mpam_write_monsel_reg(msc, CFG_MON_SEL, mon_sel); + if (ret) + return ret; + ret = mpam_read_monsel_reg(msc, CFG_MBWU_FLT, &cur_flt); + if (ret) + return ret; + ret = mpam_read_monsel_reg(msc, CFG_MBWU_CTL, &cur_ctl); + if (ret) + return ret; + ret = mpam_write_monsel_reg(msc, CFG_MBWU_CTL, 0); + if (ret) + return ret; if (mpam_ris_has_mbwu_long_counter(ris)) { ret = mpam_msc_read_mbwu_l(msc, &val); if (ret) return ret; - mpam_msc_zero_mbwu_l(msc); + ret = mpam_msc_zero_mbwu_l(msc); + if (ret) + return ret; } else { u32 val32; - mpam_read_monsel_reg(msc, MBWU, &val32); + ret = mpam_read_monsel_reg(msc, MBWU, &val32); + if (ret) + return ret; + val = val32; - mpam_write_monsel_reg(msc, MBWU, 0); + ret = mpam_write_monsel_reg(msc, MBWU, 0); + if (ret) + return ret; } cfg->mon = i; -- 2.43.0