From: Janne Grunau <j@jannau.net>
To: Sasha Finkelstein <k@chaosmail.tech>
Cc: "Sven Peter" <sven@kernel.org>, "Vinod Koul" <vkoul@kernel.org>,
"Frank Li" <Frank.Li@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Martin Povišer" <povik+lin@cutebit.org>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Joshua Peisach" <jpeisach@ubuntu.com>
Subject: Re: [PATCH v2 1/2] dt-bindings: dma: apple,admac: Add M3 generation ADMACs
Date: Sun, 2 Aug 2026 10:55:56 +0200 [thread overview]
Message-ID: <20260802085556.GB806854@robin.jannau.net> (raw)
In-Reply-To: <20260729-t603x-admac-v2-1-e4b2bb6ca45e@chaosmail.tech>
On Wed, Jul 29, 2026 at 01:46:34PM +0200, Sasha Finkelstein wrote:
> The admacs seen in M3-generation SoCs (t603x, t8122) need additional
> configuration writes and so are getting a new compatible chain.
>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Reviewed-by: Joshua Peisach <jpeisach@ubuntu.com>
> Signed-off-by: Sasha Finkelstein <k@chaosmail.tech>
> ---
> Documentation/devicetree/bindings/dma/apple,admac.yaml | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/apple,admac.yaml b/Documentation/devicetree/bindings/dma/apple,admac.yaml
> index 6a200cbd7d02..5b4fd8348f99 100644
> --- a/Documentation/devicetree/bindings/dma/apple,admac.yaml
> +++ b/Documentation/devicetree/bindings/dma/apple,admac.yaml
> @@ -10,7 +10,7 @@ description: |
> Apple's Audio DMA Controller (ADMAC) is used to fetch and store audio samples
> on SoCs from the "Apple Silicon" family.
>
> - The controller has been seen with up to 24 channels. Even-numbered channels
> + The controller has been seen with up to 32 channels. Even-numbered channels
> are TX-only, odd-numbered are RX-only. Individual channels are coupled to
> fixed device endpoints.
>
> @@ -33,6 +33,12 @@ properties:
> - apple,t8103-admac
> - apple,t8112-admac
> - const: apple,admac
> + - items:
> + - enum:
> + - apple,t6030-admac
> + - apple,t6031-admac
> + - const: apple,t8122-admac
> + - const: apple,t8122-admac
>
> reg:
> maxItems: 1
> @@ -43,7 +49,7 @@ properties:
> Clients specify a single cell with channel number.
>
> dma-channels:
> - maximum: 24
> + maximum: 32
>
> interrupts:
> minItems: 4
Reviewed-by: Janne Grunau <j@jannau.net>
Janne
next prev parent reply other threads:[~2026-08-02 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 11:46 [PATCH v2 0/2] dmaengine: apple-admac: Add support for M3 generation Sasha Finkelstein
2026-07-29 11:46 ` [PATCH v2 1/2] dt-bindings: dma: apple,admac: Add M3 generation ADMACs Sasha Finkelstein
2026-08-02 8:55 ` Janne Grunau [this message]
2026-07-29 11:46 ` [PATCH v2 2/2] dmaengine: apple-admac: " Sasha Finkelstein
2026-08-02 8:54 ` Janne Grunau
2026-08-02 9:03 ` Sasha Finkelstein
2026-08-11 18:28 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260802085556.GB806854@robin.jannau.net \
--to=j@jannau.net \
--cc=Frank.Li@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jpeisach@ubuntu.com \
--cc=k@chaosmail.tech \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=povik+lin@cutebit.org \
--cc=robh@kernel.org \
--cc=sven@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox