From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11E01C55182 for ; Mon, 3 Aug 2026 13:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=nuI73yjYCIJ3JFmgbLf/MaJFoZnqUvhDipfKsPOIBRs=; b=RaqzGaJ+VIt7uF7Cgu9bRBhx0k 9fhu0s6x1crH2rFo+g3NFHdkXvX4f+tGwdVWp/N4eZ37pj1H5lXUtkF6qfpwMi14oxh6kRQfvvjdX zzOy243SuTiAQKxlSiZ6qoQ6mYNXnzCUWG+pUtzfWhx977FaedX1zCZ2Gx2wAqmkrkSuke5Mp4Os4 un9R2iZSFEWNhMrD76Cl+mwoYhDylO61xOgjS/M+DjffCPvt95Vz6xJ04OdGNhecMlP0Dh3xBoa6E EAN+NQ8ki64vvN/IOjIdTpTXcyygVwFEFoL6UTa4mf0gi/NAZDgD4PyIdsV2NsmN6vIJ6pJxNKbF9 hxYqRzcg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqszm-0000000HDb3-2g7Q; Mon, 03 Aug 2026 13:46:22 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqszj-0000000HDXb-3wJ7 for linux-arm-kernel@lists.infradead.org; Mon, 03 Aug 2026 13:46:21 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 579A01476; Mon, 3 Aug 2026 06:46:15 -0700 (PDT) Received: from e122027.cambridge.arm.com (e122027.cambridge.arm.com [10.1.25.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 045D53F66F; Mon, 3 Aug 2026 06:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1785764779; bh=y+n05dedLTYxg5ZLsPACFxdkDqdOljcQG5V8xZ9rCk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dLgpxo4zAgonL3u1UZQW16FNr0tkHTWq+u8XN801444UaWQwj3cNPLHFZV/g/q9bv utGAGRHPzpNxIi09DswgCJiH9prQ8LIqz2mKv8zUZNlyj7HcmEzR4+anRr0AaZM/Fm 7BCD6eePeunUq9I/g/+cbwloljmbwTkLJcpUclBA= From: Steven Price To: kvm@vger.kernel.org, kvmarm@lists.linux.dev Cc: Steven Price , Catalin Marinas , Marc Zyngier , Will Deacon , James Morse , Oliver Upton , Suzuki K Poulose , Zenghui Yu , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Joey Gouly , Alexandru Elisei , Christoffer Dall , Fuad Tabba , linux-coco@lists.linux.dev, Ganapatrao Kulkarni , Gavin Shan , Shanker Donthineni , Alper Gun , "Aneesh Kumar K . V" , Emi Kisanuki , Vishal Annapurve , WeiLin.Chang@arm.com, Lorenzo Pieralisi Subject: [PATCH v16 26/45] KVM: arm64: CCA: Activate realms on first vCPU run Date: Mon, 3 Aug 2026 14:43:42 +0100 Message-ID: <20260803134403.80630-27-steven.price@arm.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260803134403.80630-1-steven.price@arm.com> References: <20260803134403.80630-1-steven.price@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260803_064620_087224_A5B4F745 X-CRM114-Status: GOOD ( 14.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use kvm_arch_vcpu_run_pid_change() to check if this is the first time the realm guest has run. If this is the first run then activate the realm. Signed-off-by: Steven Price --- Changes since v12: * Fix commit message * Change realm_state checks to be >= REALM_STATE_ACTIVE to avoid a dead guest being revived by kvm_activate_realm(). --- arch/arm64/include/asm/kvm_rmi.h | 1 + arch/arm64/kvm/arm.c | 6 +++++ arch/arm64/kvm/rmi.c | 45 ++++++++++++++++++++++++++++++-- 3 files changed, 50 insertions(+), 2 deletions(-) diff --git a/arch/arm64/include/asm/kvm_rmi.h b/arch/arm64/include/asm/kvm_rmi.h index 751659a48be3..90563183a717 100644 --- a/arch/arm64/include/asm/kvm_rmi.h +++ b/arch/arm64/include/asm/kvm_rmi.h @@ -98,6 +98,7 @@ void kvm_init_rmi(void); u32 kvm_rmm_ipa_limit(void); int kvm_init_realm(struct kvm *kvm); +int kvm_activate_realm(struct kvm *kvm); void kvm_destroy_realm(struct kvm *kvm); int kvm_realm_teardown_stage2(struct kvm *kvm); void kvm_destroy_rec(struct kvm_vcpu *vcpu); diff --git a/arch/arm64/kvm/arm.c b/arch/arm64/kvm/arm.c index 3ad2f1d5b9e2..b7c308817d45 100644 --- a/arch/arm64/kvm/arm.c +++ b/arch/arm64/kvm/arm.c @@ -1034,6 +1034,12 @@ int kvm_arch_vcpu_run_pid_change(struct kvm_vcpu *vcpu) return ret; } + if (kvm_is_realm(vcpu->kvm)) { + ret = kvm_activate_realm(kvm); + if (ret) + return ret; + } + mutex_lock(&kvm->arch.config_lock); set_bit(KVM_ARCH_FLAG_HAS_RAN_ONCE, &kvm->arch.flags); mutex_unlock(&kvm->arch.config_lock); diff --git a/arch/arm64/kvm/rmi.c b/arch/arm64/kvm/rmi.c index 31eedf78a752..c8ec766d3dc0 100644 --- a/arch/arm64/kvm/rmi.c +++ b/arch/arm64/kvm/rmi.c @@ -709,7 +709,7 @@ static int realm_set_ipa_state(struct kvm_vcpu *vcpu, return ret; } -static int __maybe_unused realm_ensure_created(struct kvm *kvm) +static int realm_ensure_created(struct kvm *kvm) { lockdep_assert_held(&kvm->arch.config_lock); @@ -829,7 +829,7 @@ int noinstr kvm_rec_enter(struct kvm_vcpu *vcpu) return ret; } -static int __maybe_unused kvm_create_rec(struct kvm_vcpu *vcpu) +static int kvm_create_rec(struct kvm_vcpu *vcpu) { struct user_pt_regs *vcpu_regs = vcpu_gp_regs(vcpu); unsigned long mpidr = kvm_vcpu_get_mpidr_aff(vcpu); @@ -932,6 +932,47 @@ void kvm_destroy_rec(struct kvm_vcpu *vcpu) rec->run_phys = 0; } +int kvm_activate_realm(struct kvm *kvm) +{ + struct realm *realm = &kvm->arch.realm; + struct kvm_vcpu *vcpu; + unsigned long i; + int ret; + + if (kvm_realm_state(kvm) >= REALM_STATE_ACTIVE) + return 0; + + if (!irqchip_in_kernel(kvm)) { + /* Userspace irqchip not yet supported with realms */ + return -EOPNOTSUPP; + } + + guard(mutex)(&kvm->arch.config_lock); + /* Check again with the lock held */ + if (kvm_realm_state(kvm) >= REALM_STATE_ACTIVE) + return 0; + + ret = realm_ensure_created(kvm); + if (ret) + return ret; + + /* Mark state as dead in case we fail */ + kvm_set_realm_state(kvm, REALM_STATE_DEAD); + + kvm_for_each_vcpu(i, vcpu, kvm) { + ret = kvm_create_rec(vcpu); + if (ret) + return ret; + } + + ret = rmi_realm_activate(virt_to_phys(realm->rd)); + if (ret) + return -ENXIO; + + kvm_set_realm_state(kvm, REALM_STATE_ACTIVE); + return 0; +} + void kvm_destroy_realm(struct kvm *kvm) { struct realm *realm = &kvm->arch.realm; -- 2.43.0