From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82E7FC55182 for ; Mon, 3 Aug 2026 14:17:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=13/m9BHJpTOrbyiXp3UlB7/KUp3A1MVFY837aXZLXF8=; b=m9thHoevRALO+Jp0/KnCYEwaK9 4+CrM8J6vCpjtcK5w2m+5dYEcOi3xHceK5iziaWOw9PwNiciHc8oNGc9nav6HU9A7/W3NlwCrq/F3 sSAlNqtrLPnghIwDHJEQPLIE0DldT+5KqD+exOFuJplCVbwxH9uf/Bc7mIuS+ptG+h5U3c7UXi0eq 7CIzxQ2Rnak7n1+FR/Sd+0ROYsYoV5nt5Kb5Q4RJVp2YtkNj25q8wbDfVODPiflBE647BstZ27A9N KkSoDcCo/q8zdl7wz+qncpB2YG0NkPpK2gBeb5Bo02oXulL8GUiuM4A1KmBXLqgnVd6OOiX0It9oZ AcRKzy7A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqtUD-0000000HJt4-0ZRq; Mon, 03 Aug 2026 14:17:49 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wqtU9-0000000HJpF-3lHw for linux-arm-kernel@lists.infradead.org; Mon, 03 Aug 2026 14:17:47 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-38dc69c74b8so3217525a91.0 for ; Mon, 03 Aug 2026 07:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785766665; x=1786371465; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=13/m9BHJpTOrbyiXp3UlB7/KUp3A1MVFY837aXZLXF8=; b=AmOv6fTu/Wl1DypXFSoDRkYUbA33kl1mDcsfwTbyeCfny4PX3uaRzm0HK37GSy0C/t fEwInwaacj3DYwguIuKhSeVMFBaUS/InRwOciSi7vZPMaC6wQDLJ8Jc9Bito/kVbawUt rQKBwHx84M8ENZ2CguJpskSmWlLLRHqZaFGHakgpyIV22VSPzN5dBnoA/ElLT0s390G1 WoKUBuZ7fHGGpgUTpyGu3y24BPqG/c6kJSBWKfvby0YTrrkIm6izfnzGk/KTiILcOXx7 1VkeuTnCr2wdKcyKUIVcSjlo7CW8/REheLDD0w0xm1NrdzzoI8Rlu3quOAMUHxdUqASZ Q8tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785766665; x=1786371465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=13/m9BHJpTOrbyiXp3UlB7/KUp3A1MVFY837aXZLXF8=; b=b7Ka5TyMjP1AOKguoO8U4WLAxaTMp7Yjav95aecOS+n8LS+G/ttOOaQPgZvqqfK00p Aili7rSQkewP6knDj9ywWUWRE2lbaB7fmTuv6balltYHHtbCdcSdUp2R9IeaS1JHuSAG XxUTIx6iogJuKO+iqk9SCk8cPEFAh1Fh50f13rc3boKrMbxG9hv+nZLWBxBLjM/rOkqN SHUTHWOs7OO3PDGHF+GmvPMUgG4ifACgwYngfcyxeN8H+b5Sx8SQus2pDSURS5BOdq47 m9k5uqfcVW8v8Bp+Oqrv6FwSCVouyfg3KV/frJ24Jcpfac54RYHm7Yj+GM1KJgHLBJKK MPvg== X-Forwarded-Encrypted: i=1; AHgh+Rq/x0XG4RnxFsZXZMSoj+tD6wHIryH6U4mTQp71y4Cogjubqb0IUMegOTQbBpqtA06h+5UUPRZjlGGl+yPSTEvb@lists.infradead.org X-Gm-Message-State: AOJu0YxTvq6Fn6+jmVqjRhi4dynyO6MSiYLoc7B2G83rKcBoXF9jR/0l wRXnhrL+T80R/8Xw53O2po4Jm26Bi2ZRefFRg1dz/Vqb/LJjhJ1dpZy2 X-Gm-Gg: AR+sD12AyBK4au+f+rdaSuj0F0G5d1iaXuyHxWeFdag9GFFA3yt3MsROKUWOhpbh/ZN 3Pytt6idYApo3cZP3XQP7HGvjwW4I9gFxQh4T3si6EI+gCS7e5bt8qDBckrSB5+tTfOB8NE0RWF viyjCI0n9A2mvNw/vSggEtxLm+WA3V+t27xFWsjCrMvL51QTwM5hGnKFmdBml15Jiz5ndG/NibM rLMVl1pchNAwbGMIQwrx+ndTP3OVYqqq8nYChtij2Eh7JEOXR8SBBFpeXuEBO5BOHtBkBWcldOn XVFx3rClCFmErLEGFfGgZjxf5+VhhwsfBJV9I5Pj+F9p8RDe/GGrSOOfybfWim9JiYilS4O9IXC +IgCEj6qIWRVh1KEPe77fh3Bbt6CGh5Bxt31hLOpu13MWjbHiyJO//4h3AjhYM7EAg4TsDL9xVC dzl+4FZTD/D+4ct4w3uUb2jIiSggJZC1qeNTeH8/mRPu5Xr32WyebQ63TCnzeaCADhOx4P5bPyj IY3ARKl0wtIGtGnMmbK X-Received: by 2002:a17:90b:544b:b0:37f:be6c:f3f2 with SMTP id 98e67ed59e1d1-38fbc3fe415mr9386869a91.2.1785766664794; Mon, 03 Aug 2026 07:17:44 -0700 (PDT) Received: from buffalo-ssd (M014013071096.v4.enabler.ne.jp. [14.13.71.96]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38fb30dff2esm4078462a91.13.2026.08.03.07.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Aug 2026 07:17:44 -0700 (PDT) From: Akari Tsuyukusa To: Michael Turquette , Stephen Boyd , Brian Masney , Matthias Brugger , AngeloGioacchino Del Regno , Yassine Oudjana , Richard Cochran Cc: Laura Nao , =?UTF-8?q?N=C3=ADcolas=20F=2E=20R=2E=20A=2E=20Prado?= , Chen-Yu Tsai , Akari Tsuyukusa , Bartosz Golaszewski , Danilo Krummrich , Bjorn Helgaas , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?= , Nicolas Frattaroli , Takashi Sakamoto , Haotian Zhang , Kees Cook , Miles Chen , Daniel Golle , Sam Shih , linux-clk@vger.kernel.org (open list:COMMON CLK FRAMEWORK), linux-kernel@vger.kernel.org (open list), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support), netdev@vger.kernel.org (open list:PTP HARDWARE CLOCK SUPPORT:Keyword:(?:\b|_)ptp(?:\b|_)), stable@vger.kernel.org Subject: [PATCH 04/32] clk: mediatek: mt8135: fix memory leak on module removal Date: Mon, 3 Aug 2026 23:16:31 +0900 Message-ID: <20260803141659.559129-5-akkun11.open@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260803141659.559129-1-akkun11.open@gmail.com> References: <20260803141659.559129-1-akkun11.open@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260803_071745_942627_170ADECB X-CRM114-Status: GOOD ( 12.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org clk_mt8135_apmixed_probe() in clk-mt8135-apmixedsys.c does not call platform_set_drvdata(), but clk_mt8135_apmixed_remove() callback calls platform_get_drvdata(). This results in platform_get_drvdata() returning NULL, which leads to calling kfree(NULL) in mtk_free_clk_data(NULL). This leaves clk_data unreleased, causing a memory leak. Fix this by calling platform_set_drvdata() during probe. Fixes: 54b7026f011e ("clk: mediatek: mt8135-apmixedsys: Convert to platform_driver and module") Cc: stable@vger.kernel.org Signed-off-by: Akari Tsuyukusa Reviewed-by: Brian Masney --- drivers/clk/mediatek/clk-mt8135-apmixedsys.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c index 19e4ee489ec3..e3b7dc13b458 100644 --- a/drivers/clk/mediatek/clk-mt8135-apmixedsys.c +++ b/drivers/clk/mediatek/clk-mt8135-apmixedsys.c @@ -66,6 +66,8 @@ static int clk_mt8135_apmixed_probe(struct platform_device *pdev) if (ret) goto unregister_plls; + platform_set_drvdata(pdev, clk_data); + return 0; unregister_plls: -- 2.55.0