From: Christophe Roullier <christophe.roullier@foss.st.com>
To: Andrew Lunn <andrew+netdev@lunn.ch>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Russell King <rmk+kernel@armlinux.org.uk>, <linusw@kernel.org>,
<antonio.borneo@foss.st.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Christophe Roullier <christophe.roullier@foss.st.com>
Cc: <netdev@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH 4/4] net: stmmac: manage error case during stmmac_dvr_probe
Date: Tue, 4 Aug 2026 15:20:52 +0200 [thread overview]
Message-ID: <20260804132052.205273-5-christophe.roullier@foss.st.com> (raw)
In-Reply-To: <20260804132052.205273-1-christophe.roullier@foss.st.com>
In case of error during stmmac_mdio_register, pm_runtime is not
cleaning before exit probe.
Signed-off-by: Christophe Roullier <christophe.roullier@foss.st.com>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 0de4bc949913..852de0f51c09 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -8062,6 +8062,8 @@ static int __stmmac_dvr_probe(struct device *device,
error_pcs_setup:
stmmac_mdio_unregister(ndev);
error_mdio_register:
+ pm_runtime_put_sync(device);
+ pm_runtime_disable(device);
stmmac_napi_del(ndev);
error_hw_init:
destroy_workqueue(priv->wq);
--
2.43.0
next prev parent reply other threads:[~2026-08-04 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-04 13:20 [PATCH 0/4] Some improve for STM32MP2X and fix for stmac_main Christophe Roullier
2026-08-04 13:20 ` [PATCH 1/4] arm64: dts: st: add 3v3 regulator to ethernet on stm32mp235f-dk Christophe Roullier
2026-08-04 13:20 ` [PATCH 2/4] arm64: dts: st: add 3v3 regulator to ethernet on stm32mp257f-dk Christophe Roullier
2026-08-04 13:20 ` [PATCH 3/4] arm64: dts: st: increase deassert of PHY reset in stm32mp257f-ev1 Christophe Roullier
2026-08-04 13:20 ` Christophe Roullier [this message]
2026-08-04 14:16 ` [PATCH 4/4] net: stmmac: manage error case during stmmac_dvr_probe Maxime Chevallier
2026-08-05 9:08 ` Christophe ROULLIER
2026-08-04 17:45 ` Andrew Lunn
2026-08-05 6:39 ` Christophe ROULLIER
2026-08-05 11:59 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260804132052.205273-5-christophe.roullier@foss.st.com \
--to=christophe.roullier@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=antonio.borneo@foss.st.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox