From: Guangshuo Li <lgs201920130244@gmail.com>
To: "Herbert Xu" <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
"Thorsten Blum" <thorsten.blum@linux.dev>,
"Kees Cook" <kees@kernel.org>,
"Maxime Méré" <maxime.mere@foss.st.com>,
"Colin Ian King" <colin.i.king@gmail.com>,
"Guangshuo Li" <lgs201920130244@gmail.com>,
"lionel.debieve@st.com" <lionel.debieve@st.com>,
linux-crypto@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: [PATCH] crypto: stm32/cryp: fix autosuspend cleanup during teardown
Date: Sat, 8 Aug 2026 17:36:23 +0800 [thread overview]
Message-ID: <20260808093623.2744314-1-lgs201920130244@gmail.com> (raw)
stm32_cryp_probe() calls pm_runtime_use_autosuspend(), but neither the
probe failure path nor stm32_cryp_remove() calls the matching
pm_runtime_dont_use_autosuspend() before disabling runtime PM.
If the autosuspend delay is set to a negative value while autosuspend
is enabled, the runtime PM core increments usage_count to prevent
runtime suspend. Without calling pm_runtime_dont_use_autosuspend()
during teardown, this reference is not dropped and usage_count remains
unbalanced.
Add the missing pm_runtime_dont_use_autosuspend() calls to both the
probe failure and remove paths before disabling runtime PM.
This issue was found by manual code inspection.
Fixes: 65f9aa36ee47 ("crypto: stm32/cryp - Add power management support")
Cc: stable@vger.kernel.org
Signed-off-by: Guangshuo Li <lgs201920130244@gmail.com>
---
drivers/crypto/stm32/stm32-cryp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c
index b79877099942..74f6e329b1fa 100644
--- a/drivers/crypto/stm32/stm32-cryp.c
+++ b/drivers/crypto/stm32/stm32-cryp.c
@@ -2691,6 +2691,7 @@ static int stm32_cryp_probe(struct platform_device *pdev)
dma_release_channel(cryp->dma_lch_out);
err_dma:
err_rst:
+ pm_runtime_dont_use_autosuspend(dev);
pm_runtime_disable(dev);
pm_runtime_put_noidle(dev);
@@ -2722,6 +2723,7 @@ static void stm32_cryp_remove(struct platform_device *pdev)
if (cryp->dma_lch_out)
dma_release_channel(cryp->dma_lch_out);
+ pm_runtime_dont_use_autosuspend(cryp->dev);
pm_runtime_disable(cryp->dev);
pm_runtime_put_noidle(cryp->dev);
--
2.43.0
reply other threads:[~2026-08-08 9:39 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260808093623.2744314-1-lgs201920130244@gmail.com \
--to=lgs201920130244@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=colin.i.king@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=kees@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=lionel.debieve@st.com \
--cc=maxime.mere@foss.st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=stable@vger.kernel.org \
--cc=thorsten.blum@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox